From d284f965561cf6b80084e8ba2307fbbe714e4969 Mon Sep 17 00:00:00 2001 From: Emerick Rogul Date: Wed, 13 Sep 2023 19:03:37 -0400 Subject: [PATCH] Disable net::features::kThirdPartyPartitionedStorageAllowedByDefault Chromium change: https://source.chromium.org/chromium/chromium/src/+/e83ad48b7de16798e682a50ab68f5fcb3f09b3f9 commit e83ad48b7de16798e682a50ab68f5fcb3f09b3f9 Author: sbingler Date: Mon Aug 28 18:57:04 2023 +0000 Allow partitioned storage by default when 3p cookies are disabled Blocking third-party cookies by default (ex: through the toggle in a new incognito tab) currently disabled all third-party storage as well. This CL allows access to partitioned storage when third-party cookies are disabled by default. This only applies when third-party cookies are disabled by default across all urls. If cookies are disabled through a user specified rule/pattern then storage will continue to be disabled as well. Bug: 1453783 --- app/brave_main_delegate_browsertest.cc | 1 + chromium_src/net/base/features.cc | 2 ++ 2 files changed, 3 insertions(+) diff --git a/app/brave_main_delegate_browsertest.cc b/app/brave_main_delegate_browsertest.cc index 20a524dd7bf..ff9bc69973f 100644 --- a/app/brave_main_delegate_browsertest.cc +++ b/app/brave_main_delegate_browsertest.cc @@ -243,6 +243,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) { &net::features::kEnableWebTransportDraft07, &net::features::kNoncedPartitionedCookies, &net::features::kPartitionedCookies, + &net::features::kThirdPartyPartitionedStorageAllowedByDefault, &network::features::kFledgePst, &network::features::kPrivateStateTokens, &network_time::kNetworkTimeServiceQuerying, diff --git a/chromium_src/net/base/features.cc b/chromium_src/net/base/features.cc index b6b470fd1a9..e3c922bd881 100644 --- a/chromium_src/net/base/features.cc +++ b/chromium_src/net/base/features.cc @@ -26,6 +26,8 @@ OVERRIDE_FEATURE_DEFAULT_STATES({{ // Brave ephemeral storage. For reference: // https://github.com/brave/brave-browser/issues/26165 {kSupportPartitionedBlobUrl, base::FEATURE_DISABLED_BY_DEFAULT}, + {kThirdPartyPartitionedStorageAllowedByDefault, + base::FEATURE_DISABLED_BY_DEFAULT}, }}); BASE_FEATURE(kBraveEphemeralStorage,