Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Android] Use SharedPreferencesManager instead of ChromePreferenceManager.

Browse Source 
Chromium change:

https://chromium.googlesource.com/chromium/src/+/d822cd296cb10e0f7256cc4834f438df609ae650

commit d822cd296cb10e0f7256cc4834f438df609ae650
Author: Henrique Nakashima <hnakashima@chromium.org>
Date:   Wed Nov 6 17:12:04 2019 +0000

    Remove Boolean methods from ChromePreferenceManager.

    Use SharedPreferencesManager instead.

    Bug: 1017800
This commit is contained in:
Max Karolinskiy
2020-01-29 07:43:55 -05:00
committed by mkarolin
parent 1085fda44f
commit d426a7255a
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/preferences/BravePreferenceManager.java
+2 -2
View File
@@ -27,12 +27,12 @@ public class BravePreferenceManager {
if (sharedPreferences.getBoolean(BRAVE_BOTTOM_TOOLBAR_SET_KEY, false)) {
return sharedPreferences.getBoolean(BRAVE_BOTTOM_TOOLBAR_ENABLED_KEY, true);
} else {
ChromePreferenceManager.getInstance().writeBoolean(BRAVE_BOTTOM_TOOLBAR_SET_KEY, true);
SharedPreferencesManager.getInstance().writeBoolean(BRAVE_BOTTOM_TOOLBAR_SET_KEY, true);
boolean enable = true;
if (isSmallScreen()) {
enable = false;
}
ChromePreferenceManager.getInstance().writeBoolean(
SharedPreferencesManager.getInstance().writeBoolean(
BRAVE_BOTTOM_TOOLBAR_ENABLED_KEY, enable);
return enable;
android/java/org/chromium/chrome/browser/settings/themes/BraveThemePreferences.java
+6 -6
View File
@@ -15,7 +15,7 @@ import org.chromium.chrome.R;
import org.chromium.base.BuildInfo;
import org.chromium.chrome.browser.ChromeFeatureList;
import org.chromium.chrome.browser.night_mode.GlobalNightModeStateProviderHolder;
import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
import org.chromium.chrome.browser.settings.SettingsUtils;
public class BraveThemePreferences extends ThemePreferences {
@@ -24,7 +24,7 @@ public class BraveThemePreferences extends ThemePreferences {
SettingsUtils.addPreferencesFromResource(this, R.xml.brave_theme_preferences);
getActivity().setTitle(getResources().getString(R.string.prefs_themes));
ChromePreferenceManager chromePreferenceManager = ChromePreferenceManager.getInstance();
SharedPreferencesManager sharedPreferencesManager = SharedPreferencesManager.getInstance();
BraveRadioButtonGroupThemePreference radioButtonGroupThemePreference =
(BraveRadioButtonGroupThemePreference) findPreference(PREF_UI_THEME_PREF);
@@ -35,17 +35,17 @@ public class BraveThemePreferences extends ThemePreferences {
: ThemeSetting.LIGHT;
}
radioButtonGroupThemePreference.initialize(
chromePreferenceManager.readInt(UI_THEME_SETTING_KEY, defaultThemePref),
chromePreferenceManager.readBoolean(DARKEN_WEBSITES_ENABLED_KEY, false));
sharedPreferencesManager.readInt(UI_THEME_SETTING_KEY, defaultThemePref),
sharedPreferencesManager.readBoolean(DARKEN_WEBSITES_ENABLED_KEY, false));
radioButtonGroupThemePreference.setOnPreferenceChangeListener((preference, newValue) -> {
if (ChromeFeatureList.isEnabled(
ChromeFeatureList.DARKEN_WEBSITES_CHECKBOX_IN_THEMES_SETTING)) {
chromePreferenceManager.writeBoolean(DARKEN_WEBSITES_ENABLED_KEY,
sharedPreferencesManager.writeBoolean(DARKEN_WEBSITES_ENABLED_KEY,
radioButtonGroupThemePreference.isDarkenWebsitesEnabled());
}
int theme = (int) newValue;
chromePreferenceManager.writeInt(UI_THEME_SETTING_KEY, theme);
sharedPreferencesManager.writeInt(UI_THEME_SETTING_KEY, theme);
return true;
});
}