From d4db7fcba4e2bf630dddcd86425b6637b7ea7690 Mon Sep 17 00:00:00 2001 From: AlexeyBarabash Date: Thu, 29 Jan 2026 00:44:25 +0200 Subject: [PATCH] [cr146][Android] openInAppMenuItemProvider arg at TabbedAppMenuPropertiesDelegate.ctor Chromium change: https://source.chromium.org/chromium/chromium/src/+/c66c93e16c77f0357a729ea2bd39a05ce95af5ef [Link Capturing] Create Open in App entry point classes Low-Coverage-Reason: TESTS_IN_SEPARATE_CL New code isn't yet fully implemented Bug: 450253146 Change-Id: I8eb1ebe754e3b244c2fa0b426597bdbc605aa071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7426174 --- .../tabbed_mode/BraveTabbedAppMenuPropertiesDelegate.java | 7 +++++-- .../org/chromium/chrome/browser/BytecodeTest.java | 4 +++- .../BraveTabbedAppMenuPropertiesDelegateUnitTest.java | 3 ++- test/BUILD.gn | 1 + 4 files changed, 11 insertions(+), 4 deletions(-) diff --git a/android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegate.java b/android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegate.java index 673bae3fba9..5161842c443 100644 --- a/android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegate.java +++ b/android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegate.java @@ -48,6 +48,7 @@ import org.chromium.chrome.browser.layouts.LayoutStateProvider; import org.chromium.chrome.browser.multiwindow.BraveMultiWindowUtils; import org.chromium.chrome.browser.multiwindow.MultiWindowModeStateDispatcher; import org.chromium.chrome.browser.multiwindow.MultiWindowUtils; +import org.chromium.chrome.browser.open_in_app.OpenInAppMenuItemProvider; import org.chromium.chrome.browser.preferences.ChromeSharedPreferences; import org.chromium.chrome.browser.readaloud.ReadAloudController; import org.chromium.chrome.browser.set_default_browser.BraveSetDefaultBrowserUtils; @@ -241,7 +242,8 @@ public class BraveTabbedAppMenuPropertiesDelegate extends TabbedAppMenuPropertie OneshotSupplier incognitoReauthControllerOneshotSupplier, Supplier readAloudControllerSupplier, - PageZoomManager pageZoomManager) { + PageZoomManager pageZoomManager, + @Nullable OpenInAppMenuItemProvider openInAppMenuItemProvider) { super( context, activityTabProvider, @@ -257,7 +259,8 @@ public class BraveTabbedAppMenuPropertiesDelegate extends TabbedAppMenuPropertie snackbarManager, incognitoReauthControllerOneshotSupplier, readAloudControllerSupplier, - pageZoomManager); + pageZoomManager, + openInAppMenuItemProvider); mBraveAppMenuDelegate = appMenuDelegate; mBookmarkModelSupplier = bookmarkModelSupplier; diff --git a/android/javatests/org/chromium/chrome/browser/BytecodeTest.java b/android/javatests/org/chromium/chrome/browser/BytecodeTest.java index bc9441ff4f7..4a729bb5738 100644 --- a/android/javatests/org/chromium/chrome/browser/BytecodeTest.java +++ b/android/javatests/org/chromium/chrome/browser/BytecodeTest.java @@ -115,6 +115,7 @@ import org.chromium.chrome.browser.omnibox.suggestions.OmniboxSuggestionsDropdow import org.chromium.chrome.browser.omnibox.suggestions.OmniboxSuggestionsDropdownScrollListener; import org.chromium.chrome.browser.omnibox.suggestions.SuggestionHost; import org.chromium.chrome.browser.omnibox.suggestions.basic.BasicSuggestionProcessor.BookmarkState; +import org.chromium.chrome.browser.open_in_app.OpenInAppMenuItemProvider; import org.chromium.chrome.browser.password_manager.PasswordManagerHelper; import org.chromium.chrome.browser.price_tracking.PriceDropNotificationManager; import org.chromium.chrome.browser.profiles.Profile; @@ -1405,7 +1406,8 @@ public class BytecodeTest { SnackbarManager.class, OneshotSupplier.class, Supplier.class, - PageZoomManager.class)); + PageZoomManager.class, + OpenInAppMenuItemProvider.class)); Assert.assertTrue( constructorsMatch( "org/chromium/chrome/browser/tabmodel/ChromeTabCreator", diff --git a/android/junit/src/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegateUnitTest.java b/android/junit/src/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegateUnitTest.java index ff308b1c7be..52d9494528a 100644 --- a/android/junit/src/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegateUnitTest.java +++ b/android/junit/src/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegateUnitTest.java @@ -266,7 +266,8 @@ public class BraveTabbedAppMenuPropertiesDelegateUnitTest { mSnackbarManager, mIncognitoReauthControllerSupplier, mReadAloudControllerSupplier, - mPageZoomManagerMock); + mPageZoomManagerMock, + /* openInAppMenuItemProvider= */ null); delegate.setIsJunitTesting(true); BaseRobolectricTestRule.runAllBackgroundAndUi(); mTabbedAppMenuPropertiesDelegate = Mockito.spy(delegate); diff --git a/test/BUILD.gn b/test/BUILD.gn index 3c75dceb98a..5a99ad1080b 100644 --- a/test/BUILD.gn +++ b/test/BUILD.gn @@ -1456,6 +1456,7 @@ if (is_android) { "//chrome/browser/hub:java", "//chrome/browser/keyboard_accessory/android/java", "//chrome/browser/language/android:java", + "//chrome/browser/open_in_app/android:java", "//chrome/browser/password_manager/android:java", "//chrome/browser/prefetch/android:java", "//chrome/browser/profiles/android:java",