From d62ef06daee4be11312f68a3176056bda478cbfe Mon Sep 17 00:00:00 2001 From: samartnik Date: Mon, 13 Jun 2022 09:57:57 -0400 Subject: [PATCH] [Android] onFirstRunCheckDone was removed Chromium change: https://github.com/chromium/chromium/commit/2e294c447ae4a0c153226a2372118f937b978b93 [android] Stop blocking sign-in if FRE isn't done This requirement was introduced in crbug.com/303953 as a way to prevent a background sign-in in a use case for EDU accounts (the background sign-in would break some assumptions and cause a crash). This use case should not be possible anymore, so the CL just deletes the code. If the issue somehow resurfaces, we can further patch isSigninAllowed() and isSyncOptInAllowed() to check that the FRE is complete, instead of relying on callers signaling onFirstRunCheckDone() themselves. Fixed: 1316369 --- .../org/chromium/chrome/browser/signin/BraveSigninManager.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/android/java/org/chromium/chrome/browser/signin/BraveSigninManager.java b/android/java/org/chromium/chrome/browser/signin/BraveSigninManager.java index 531dafba7b5..48ebe171d5b 100644 --- a/android/java/org/chromium/chrome/browser/signin/BraveSigninManager.java +++ b/android/java/org/chromium/chrome/browser/signin/BraveSigninManager.java @@ -80,9 +80,6 @@ public class BraveSigninManager implements SigninManager { return false; } - @Override - public void onFirstRunCheckDone() {} - @Override public IdentityManager getIdentityManager() { return mIdentityManager;