Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add user preference for debounce (#15905)

Browse Source
This commit is contained in:
Shivan Kaul Sahib
2022-12-09 12:12:51 -08:00
committed by GitHub
parent 3770b9ac23
commit d74fa0a19f
23 changed files with 157 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/base/BraveFeatureList.java
+1
View File
@@ -19,4 +19,5 @@ public abstract class BraveFeatureList {
public static final String BRAVE_ANDROID_SAFE_BROWSING = "BraveAndroidSafeBrowsing";
public static final String BRAVE_VPN_LINK_SUBSCRIPTION_ANDROID_UI =
"BraveVPNLinkSubscriptionAndroidUI";
public static final String DEBOUNCE = "BraveDebounce";
}
android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java
+18 -2
View File
@@ -72,6 +72,7 @@ public class BravePrivacySettings extends PrivacySettings implements ConnectionE
private static final String PREF_HTTPSE = "httpse";
private static final String PREF_DE_AMP = "de_amp";
private static final String PREF_DEBOUNCE = "debounce";
private static final String PREF_IPFS_GATEWAY = "ipfs_gateway";
private static final String PREF_BLOCK_COOKIE_CONSENT_NOTICES = "block_cookie_consent_notices";
private static final String PREF_AD_BLOCK = "ad_block";
@@ -103,7 +104,7 @@ public class BravePrivacySettings extends PrivacySettings implements ConnectionE
private static final String[] NEW_PRIVACY_PREFERENCE_ORDER = {
PREF_BRAVE_SHIELDS_GLOBALS_SECTION, // shields globals section
PREF_SHIELDS_SUMMARY, PREF_BLOCK_TRACKERS_ADS, PREF_DE_AMP, PREF_HTTPSE,
PREF_SHIELDS_SUMMARY, PREF_BLOCK_TRACKERS_ADS, PREF_DE_AMP, PREF_DEBOUNCE, PREF_HTTPSE,
PREF_HTTPS_FIRST_MODE, PREF_BLOCK_SCRIPTS, PREF_BLOCK_CROSS_SITE_COOKIES,
PREF_FINGERPRINTING_PROTECTION, PREF_FINGERPRINT_LANGUAGE,
PREF_CLEAR_DATA_SECTION, // clear data automatically section
@@ -137,6 +138,7 @@ public class BravePrivacySettings extends PrivacySettings implements ConnectionE
private ChromeSwitchPreference mAutocompleteTopSites;
private ChromeSwitchPreference mHttpsePref;
private ChromeSwitchPreference mDeAmpPref;
private ChromeSwitchPreference mDebouncePref;
private ChromeSwitchPreference mHttpsFirstModePref;
private BraveDialogPreference mFingerprintingProtectionPref;
private ChromeSwitchPreference mBlockScriptsPref;
@@ -199,6 +201,13 @@ public class BravePrivacySettings extends PrivacySettings implements ConnectionE
mDeAmpPref = (ChromeSwitchPreference) findPreference(PREF_DE_AMP);
mDeAmpPref.setOnPreferenceChangeListener(this);
if (ChromeFeatureList.isEnabled(BraveFeatureList.DEBOUNCE)) {
mDebouncePref = (ChromeSwitchPreference) findPreference(PREF_DEBOUNCE);
mDebouncePref.setOnPreferenceChangeListener(this);
} else {
removePreferenceIfPresent(PREF_DEBOUNCE);
}
mHttpsFirstModePref = (ChromeSwitchPreference) findPreference(PREF_HTTPS_FIRST_MODE);
mHttpsFirstModePref.setVisible(mHttpsePref.isChecked());
@@ -353,7 +362,9 @@ public class BravePrivacySettings extends PrivacySettings implements ConnectionE
}
} else if (PREF_DE_AMP.equals(key)) {
BravePrefServiceBridge.getInstance().setDeAmpEnabled((boolean) newValue);
} else if (PREF_DEBOUNCE.equals(key)) {
UserPrefs.get(Profile.getLastUsedRegularProfile())
.setBoolean(BravePref.DEBOUNCE_ENABLED, (boolean) newValue);
} else if (PREF_IPFS_GATEWAY.equals(key)) {
BravePrefServiceBridge.getInstance().setIpfsGatewayEnabled((boolean) newValue);
} else if (PREF_BLOCK_COOKIE_CONSENT_NOTICES.equals(key)) {
@@ -583,6 +594,11 @@ public class BravePrivacySettings extends PrivacySettings implements ConnectionE
mCookieListOptInPageAndroidHandler.isFilterListEnabled(
isEnabled -> { mBlockCookieConsentNoticesPref.setChecked(isEnabled); });
}
// Debounce
if (mDebouncePref != null) {
mDebouncePref.setChecked(UserPrefs.get(Profile.getLastUsedRegularProfile())
.getBoolean(BravePref.DEBOUNCE_ENABLED));
}
}
private void removePreferenceIfPresent(String key) {
android/java/res/xml/brave_privacy_preferences.xml
+4 -1
View File
@@ -56,7 +56,10 @@
android:title="@string/de_amp_switch"
android:summary="@string/de_amp_summary"
android:defaultValue="true" />
<org.chromium.components.browser_ui.settings.ChromeSwitchPreference
android:key="debounce"
android:title="@string/debounce_switch"
android:summary="@string/debounce_summary" />
<PreferenceCategory
android:key="clear_data_section"
android:title="@string/prefs_section_clear_data"/>