diff --git a/components/brave_wallet/renderer/js_ethereum_provider.cc b/components/brave_wallet/renderer/js_ethereum_provider.cc index 6bc12de9822..f57dad62e79 100644 --- a/components/brave_wallet/renderer/js_ethereum_provider.cc +++ b/components/brave_wallet/renderer/js_ethereum_provider.cc @@ -186,7 +186,7 @@ void JSEthereumProvider::CreateEthereumObject( gin::StringToSymbol(isolate, kIsBraveWallet), v8::True(isolate), v8::ReadOnly) .Check(); - // isMetaMask shuld be writable because of + // isMetaMask should be writable because of // https://github.com/brave/brave-browser/issues/22213 ethereum_obj ->DefineOwnProperty(context, gin::StringToSymbol(isolate, "isMetaMask"), @@ -198,8 +198,10 @@ void JSEthereumProvider::CreateEthereumObject( .Check(); BindFunctionsToObject(isolate, context, ethereum_obj, metamask_obj); UpdateAndBindJSProperties(isolate, context, ethereum_obj); + // send should be writable because of + // https://github.com/brave/brave-browser/issues/25078 for (const std::string& method : - {"request", "isConnected", "enable", "sendAsync", "send"}) { + {"request", "isConnected", "enable", "sendAsync"}) { SetOwnPropertyNonWritable(context, ethereum_obj, gin::StringToV8(isolate, method)); } diff --git a/renderer/test/js_ethereum_provider_browsertest.cc b/renderer/test/js_ethereum_provider_browsertest.cc index c0fa6d1d430..85351a1c50d 100644 --- a/renderer/test/js_ethereum_provider_browsertest.cc +++ b/renderer/test/js_ethereum_provider_browsertest.cc @@ -184,9 +184,11 @@ IN_PROC_BROWSER_TEST_F(JSEthereumProviderBrowserTest, NonWritable) { EXPECT_EQ(base::Value(true), result.value) << result.error; } // window.ethereum.* (methods) + // send should be writable because of + // https://github.com/brave/brave-browser/issues/25078 for (const std::string& method : {"on", "emit", "removeListener", "removeAllListeners", "request", - "isConnected", "enable", "sendAsync", "send"}) { + "isConnected", "enable", "sendAsync"}) { SCOPED_TRACE(method); auto result = EvalJs(web_contents(), NonWriteableScriptMethod("ethereum", method),