diff --git a/browser/ui/views/tabs/brave_tab_hover_browsertest.cc b/browser/ui/views/tabs/brave_tab_hover_browsertest.cc index 312eb13776b..490d9cac6e7 100644 --- a/browser/ui/views/tabs/brave_tab_hover_browsertest.cc +++ b/browser/ui/views/tabs/brave_tab_hover_browsertest.cc @@ -92,11 +92,12 @@ IN_PROC_BROWSER_TEST_F(BraveTabHoverTest, ThumbnailHelperIsAlwaysAttached) { tabs::TabData data; data.visible_url = GURL("https://card.com"); data.title = u"Hello World"; - data_list.push_back({.index = 0, .handle = tabs::TabHandle(0), .data = data}); + data_list.push_back( + {.index = 0, .handle = tabs::TabHandle(0), .is_pinned = false}); horizontal_tab_strip_for_testing()->AddTabsAt(data_list); horizontal_tab_strip_for_testing()->tab_at(0)->SetDataForTesting(data); EXPECT_EQ(0, browser()->tab_strip_model()->active_index()); - EXPECT_EQ(data_list[0].data.visible_url, active_tab()->data().visible_url); + EXPECT_EQ(data.visible_url, active_tab()->data().visible_url); EXPECT_NE(nullptr, content::WebContentsUserData::FromWebContents( contents())); @@ -106,11 +107,12 @@ IN_PROC_BROWSER_TEST_F(BraveTabHoverTest, ThumbnailHelperIsAlwaysAttached) { data_list = {}; data.visible_url = GURL("https://card-with-preview.com"); data.title = u"Foo Bar"; - data_list.push_back({.index = 0, .handle = tabs::TabHandle(1), .data = data}); + data_list.push_back( + {.index = 0, .handle = tabs::TabHandle(1), .is_pinned = false}); horizontal_tab_strip_for_testing()->AddTabsAt(data_list); horizontal_tab_strip_for_testing()->tab_at(0)->SetDataForTesting(data); EXPECT_EQ(0, browser()->tab_strip_model()->active_index()); - EXPECT_EQ(data_list[0].data.visible_url, active_tab()->data().visible_url); + EXPECT_EQ(data.visible_url, active_tab()->data().visible_url); EXPECT_NE(nullptr, content::WebContentsUserData::FromWebContents( contents())); @@ -121,11 +123,12 @@ IN_PROC_BROWSER_TEST_F(BraveTabHoverTest, ThumbnailHelperIsAlwaysAttached) { data_list = {}; data.visible_url = GURL("https://tooltip.com"); data.title = u"Baf Baz"; - data_list.push_back({.index = 0, .handle = tabs::TabHandle(2), .data = data}); + data_list.push_back( + {.index = 0, .handle = tabs::TabHandle(2), .is_pinned = false}); horizontal_tab_strip_for_testing()->AddTabsAt(data_list); horizontal_tab_strip_for_testing()->tab_at(0)->SetDataForTesting(data); EXPECT_EQ(0, horizontal_tab_strip_for_testing()->GetActiveIndex()); - EXPECT_EQ(data_list[0].data.visible_url, active_tab()->data().visible_url); + EXPECT_EQ(data.visible_url, active_tab()->data().visible_url); EXPECT_NE(nullptr, content::WebContentsUserData::FromWebContents( contents())); diff --git a/chromium_src/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc b/chromium_src/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc index 65fb37db6ae..1cfc72ae529 100644 --- a/chromium_src/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc +++ b/chromium_src/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc @@ -41,16 +41,16 @@ class TabHoverCardBubbleViewBrowserTest : public DialogBrowserTest, // DialogBrowserTest: void ShowUi(const std::string& name) override { std::vector data_list; - tabs::TabData data; - data.title = kTabTitle; - data.last_committed_url = GURL(kTabUrl); data_list.push_back( - {.index = 0, .handle = tabs::TabHandle(0), .data = data}); + {.index = 0, .handle = tabs::TabHandle(0), .is_pinned = false}); GetTabStrip(browser())->AddTabsAt(data_list); // As tabs::TabHandle::Get() would return nullptr, the tab data would not be // set. So we need to set the tab data manually here for testing. - GetTabStrip(browser())->tab_at(0)->SetDataForTesting(data); + tabs::TabData tab_data; + tab_data.title = kTabTitle; + tab_data.last_committed_url = GURL(kTabUrl); + GetTabStrip(browser())->tab_at(0)->SetDataForTesting(tab_data); SimulateHoverTab(browser(), 0); }