From eb8b247c12f1a71ac527f560ffd1b604afe3da65 Mon Sep 17 00:00:00 2001 From: "Brian R. Bondy" Date: Tue, 24 Feb 2026 20:17:55 -0500 Subject: [PATCH] Move brave_sync crypto unit test to brave_components_unittests (#34132) --- components/BUILD.gn | 1 + components/brave_sync/BUILD.gn | 5 +++++ test/BUILD.gn | 3 --- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/components/BUILD.gn b/components/BUILD.gn index 67455a1ca60..8fb2cad22ea 100644 --- a/components/BUILD.gn +++ b/components/BUILD.gn @@ -32,6 +32,7 @@ test("brave_components_unittests") { "//brave/components/brave_policy/ad_block_only_mode:unit_tests", "//brave/components/brave_shields/core/browser:unit_tests", "//brave/components/brave_shields/core/common:unit_tests", + "//brave/components/brave_sync:unit_tests", "//brave/components/component_updater:unit_tests", "//brave/components/email_aliases:unit_tests", "//brave/components/json:unit_tests", diff --git a/components/brave_sync/BUILD.gn b/components/brave_sync/BUILD.gn index a025d354f26..9ac373b3e0b 100644 --- a/components/brave_sync/BUILD.gn +++ b/components/brave_sync/BUILD.gn @@ -135,15 +135,18 @@ group("constants") { source_set("unit_tests") { testonly = true + sources = [ "//brave/components/brave_sync/brave_sync_p3a_unittest.cc", "//brave/components/brave_sync/brave_sync_prefs_unittest.cc", + "//brave/components/brave_sync/crypto/crypto_unittest.cc", "//brave/components/brave_sync/qr_code_data_unittest.cc", "//brave/components/brave_sync/qr_code_validator_unittest.cc", "//brave/components/brave_sync/time_limited_words_unittest.cc", ] deps = [ + ":crypto", ":p3a", ":prefs", ":time_limited_codes", @@ -152,5 +155,7 @@ source_set("unit_tests") { "//components/prefs:test_support", "//components/sync/base", "//components/sync/service", + "//crypto", + "//testing/gtest", ] } diff --git a/test/BUILD.gn b/test/BUILD.gn index 30b484bb7d1..f40d751184d 100644 --- a/test/BUILD.gn +++ b/test/BUILD.gn @@ -128,7 +128,6 @@ test("brave_unit_tests") { "//brave/components/brave_private_cdn/private_cdn_helper_unittest.cc", "//brave/components/brave_search/browser/brave_search_default_host_unittest.cc", "//brave/components/brave_search/browser/brave_search_fallback_host_unittest.cc", - "//brave/components/brave_sync/crypto/crypto_unittest.cc", "//brave/components/content_settings/core/browser/brave_content_settings_pref_provider_unittest.cc", "//brave/components/content_settings/core/browser/brave_content_settings_utils_unittest.cc", "//brave/components/ntp_background_images/browser/ntp_sponsored_image_source_unittest.cc", @@ -221,9 +220,7 @@ test("brave_unit_tests") { "//brave/components/brave_shields/core/common", "//brave/components/brave_shields/core/common:mojom", "//brave/components/brave_shields/core/test:unit_tests", - "//brave/components/brave_sync:crypto", "//brave/components/brave_sync:network_time_helper", - "//brave/components/brave_sync:unit_tests", "//brave/components/brave_user_agent/browser:unit_tests", "//brave/components/challenge_bypass_ristretto:unit_tests", "//brave/components/child_process_monitor:unittests",