[Android] Do not use Dagger for EphemeralTabCoordinator
Chromium change: https://source.chromium.org/chromium/chromium/src/+/3f2127c8345e1a34106b4f64bfa7836508af360d [Android] Do not use Dagger for EphemeralTabCoordinator EphemeralTabCoordinator relied on Dagger to get itself injected to CustomTabDelegate{Factory} which owns the object. This CL moves it out to BaseCustomTabRootUiCoordinator, and strip all the injection annotations off it. This move makes it easy to modularize EphemeralTab for upcoming changes. Low-Coverage-Reason: HARD_TO_TEST Warning from BaseCustomTabRootUiCoordinator whose coverage is low before the CL. Bug: 355482871
This commit is contained in:
@@ -99,7 +99,6 @@ public class BraveLeoActivity extends CustomTabActivity {
|
||||
() -> mToolbarCoordinator,
|
||||
() -> mNavigationController,
|
||||
() -> mIntentDataProvider,
|
||||
() -> mDelegateFactory.getEphemeralTabCoordinator(),
|
||||
mBackPressManager,
|
||||
() -> mTabController,
|
||||
() -> mMinimizationManagerHolder.getMinimizationManager(),
|
||||
|
||||
-3
@@ -21,7 +21,6 @@ import org.chromium.chrome.browser.bookmarks.BookmarkModel;
|
||||
import org.chromium.chrome.browser.bookmarks.TabBookmarker;
|
||||
import org.chromium.chrome.browser.browserservices.intents.BrowserServicesIntentDataProvider;
|
||||
import org.chromium.chrome.browser.compositor.CompositorViewHolder;
|
||||
import org.chromium.chrome.browser.compositor.bottombar.ephemeraltab.EphemeralTabCoordinator;
|
||||
import org.chromium.chrome.browser.compositor.layouts.LayoutManagerImpl;
|
||||
import org.chromium.chrome.browser.customtabs.BaseCustomTabRootUiCoordinator;
|
||||
import org.chromium.chrome.browser.customtabs.CustomTabFeatureOverridesManager;
|
||||
@@ -85,7 +84,6 @@ public class BraveLeoCustomTabRootUiCoordinator extends BaseCustomTabRootUiCoord
|
||||
@NonNull Supplier<CustomTabToolbarCoordinator> customTabToolbarCoordinator,
|
||||
@NonNull Supplier<CustomTabActivityNavigationController> customTabNavigationController,
|
||||
@NonNull Supplier<BrowserServicesIntentDataProvider> intentDataProvider,
|
||||
@NonNull Supplier<EphemeralTabCoordinator> ephemeralTabCoordinatorSupplier,
|
||||
@NonNull BackPressManager backPressManager,
|
||||
@NonNull Supplier<CustomTabActivityTabController> tabController,
|
||||
@NonNull Supplier<CustomTabMinimizeDelegate> minimizeDelegateSupplier,
|
||||
@@ -124,7 +122,6 @@ public class BraveLeoCustomTabRootUiCoordinator extends BaseCustomTabRootUiCoord
|
||||
customTabToolbarCoordinator,
|
||||
customTabNavigationController,
|
||||
intentDataProvider,
|
||||
ephemeralTabCoordinatorSupplier,
|
||||
backPressManager,
|
||||
tabController,
|
||||
minimizeDelegateSupplier,
|
||||
|
||||
+2
-2
@@ -16,6 +16,7 @@ import org.chromium.base.Callback;
|
||||
import org.chromium.base.supplier.ObservableSupplier;
|
||||
import org.chromium.base.supplier.ObservableSupplierImpl;
|
||||
import org.chromium.base.supplier.OneshotSupplier;
|
||||
import org.chromium.base.supplier.OneshotSupplierImpl;
|
||||
import org.chromium.base.supplier.Supplier;
|
||||
import org.chromium.chrome.R;
|
||||
import org.chromium.chrome.browser.ActivityTabProvider;
|
||||
@@ -95,8 +96,7 @@ public class BraveTabbedRootUiCoordinator extends TabbedRootUiCoordinator {
|
||||
@NonNull Supplier<Boolean> isInOverviewModeSupplier,
|
||||
@NonNull AppMenuDelegate appMenuDelegate,
|
||||
@NonNull StatusBarColorProvider statusBarColorProvider,
|
||||
@NonNull
|
||||
ObservableSupplierImpl<EphemeralTabCoordinator> ephemeralTabCoordinatorSupplier,
|
||||
@NonNull OneshotSupplierImpl<EphemeralTabCoordinator> ephemeralTabCoordinatorSupplier,
|
||||
@NonNull IntentRequestTracker intentRequestTracker,
|
||||
@NonNull InsetObserver insetObserver,
|
||||
@NonNull Function<Tab, Boolean> backButtonShouldCloseTabFn,
|
||||
|
||||
Reference in New Issue
Block a user