From f0452612a57f1af68ce88ac7b8ec5b400e5fcfd2 Mon Sep 17 00:00:00 2001 From: Max Karolinskiy Date: Sat, 10 May 2025 15:35:25 -0400 Subject: [PATCH] [cr137] Disables upstream kDevToolsNewPermissionDialog feature. Per security/privacy. --- app/feature_defaults_unittest.cc | 4 ++++ chromium_src/chrome/browser/devtools/features.cc | 1 + 2 files changed, 5 insertions(+) diff --git a/app/feature_defaults_unittest.cc b/app/feature_defaults_unittest.cc index ff7081053a7..50b19c3a7cd 100644 --- a/app/feature_defaults_unittest.cc +++ b/app/feature_defaults_unittest.cc @@ -54,6 +54,7 @@ #include "components/webui/chrome_urls/features.h" #include "content/common/features.h" #include "content/public/common/btm_utils.h" +#include "content/public/common/buildflags.h" #include "content/public/common/content_features.h" #include "gpu/config/gpu_finch_features.h" #include "media/base/media_switches.h" @@ -138,6 +139,9 @@ TEST(FeatureDefaultsTest, DisabledFeatures) { #if !BUILDFLAG(IS_ANDROID) &features::kDevToolsConsoleInsights, #endif // !BUILDFLAG(IS_ANDROID) +#if BUILDFLAG(ENABLE_DEVTOOLS_FRONTEND) + &features::kDevToolsNewPermissionDialog, +#endif // BUILDFLAG(ENABLE_DEVTOOLS_FRONTEND) &features::kDevToolsPrivacyUI, &features::kDigitalGoodsApi, &features::kFedCm, diff --git a/chromium_src/chrome/browser/devtools/features.cc b/chromium_src/chrome/browser/devtools/features.cc index 20147feb52a..f07c3f9d249 100644 --- a/chromium_src/chrome/browser/devtools/features.cc +++ b/chromium_src/chrome/browser/devtools/features.cc @@ -12,6 +12,7 @@ OVERRIDE_FEATURE_DEFAULT_STATES({{ #if !BUILDFLAG(IS_ANDROID) {kDevToolsConsoleInsights, base::FEATURE_DISABLED_BY_DEFAULT}, #endif // !BUILDFLAG(IS_ANDROID) + {kDevToolsNewPermissionDialog, base::FEATURE_DISABLED_BY_DEFAULT}, }}); } // namespace features