Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Android] Changes for WebContentsDarkModeController

Browse Source 
Chromium change:
https://github.com/chromium/chromium/commit/1443d5c5c991380789b3681d017e06245b098e35

[AutoDark] Clean up WebContentsDarkModeController
Remove the shared preference for auto dark usage in Android, since force
dark settings is now provided in TabWebContentsDelegateAndroid.

For this reason, we can refactor the class by:
* Remove ApplicationStatusListener
* Remove NightModeStateProvider.Observer

Bug: 1249345
This commit is contained in:
samartnik
2022-01-24 15:38:46 -05:00
committed by mkarolin
parent b9a839a80b
commit f3525c622a
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/night_mode/settings/BraveThemePreferences.java
+3 -3
View File
@@ -18,7 +18,6 @@ import org.chromium.chrome.browser.flags.ChromeFeatureList;
import org.chromium.chrome.browser.night_mode.GlobalNightModeStateProviderHolder;
import org.chromium.chrome.browser.night_mode.ThemeType;
import org.chromium.chrome.browser.night_mode.WebContentsDarkModeController;
import org.chromium.chrome.browser.night_mode.WebContentsDarkModeController.AutoDarkSettingsChangeSource;
import org.chromium.chrome.browser.ntp_background_images.NTPBackgroundImagesBridge;
import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
import org.chromium.chrome.browser.profiles.Profile;
@@ -58,7 +57,8 @@ public class BraveThemePreferences extends ThemeSettingsFragment {
: ThemeType.LIGHT;
}
mWebContentsDarkModeEnabled = WebContentsDarkModeController.isGlobalUserSettingsEnabled();
mWebContentsDarkModeEnabled = WebContentsDarkModeController.isGlobalUserSettingsEnabled(
Profile.getLastUsedRegularProfile());
radioButtonGroupThemePreference.initialize(
sharedPreferencesManager.readInt(UI_THEME_SETTING, defaultThemePref),
mWebContentsDarkModeEnabled);
@@ -71,7 +71,7 @@ public class BraveThemePreferences extends ThemeSettingsFragment {
mWebContentsDarkModeEnabled =
radioButtonGroupThemePreference.isDarkenWebsitesEnabled();
WebContentsDarkModeController.setGlobalUserSettings(
mWebContentsDarkModeEnabled);
Profile.getLastUsedRegularProfile(), mWebContentsDarkModeEnabled);
}
}
int theme = (int) newValue;