From fd7a9de85afe40502ed88c29ff6b7fced1b10860 Mon Sep 17 00:00:00 2001 From: Kyle Hickinson Date: Mon, 21 Jul 2025 09:25:16 -0400 Subject: [PATCH] [iOS] Use correct suspension value for invalid language metrics answer (#30136) This change ensures we use `Int32.max` instead of `Int.max` so that we match with desktop which uses `INT_MAX` to suspend the language metric --- ios/brave-ios/Sources/Growth/LanguageMetrics.swift | 2 +- ios/brave-ios/Tests/GrowthTests/LangaugeMetricsTests.swift | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ios/brave-ios/Sources/Growth/LanguageMetrics.swift b/ios/brave-ios/Sources/Growth/LanguageMetrics.swift index 127c9f45155..ecb1222e7d2 100644 --- a/ios/brave-ios/Sources/Growth/LanguageMetrics.swift +++ b/ios/brave-ios/Sources/Growth/LanguageMetrics.swift @@ -206,7 +206,7 @@ public class LanguageMetrics { ] static func answerForLangaugeCode(_ languageCode: String?) -> Int { - let suspendedMetricValue = Int.max - 1 + let suspendedMetricValue = Int(Int32.max - 1) guard let languageCode = languageCode, case let primaryLanguage = languageSynonyms[languageCode, default: languageCode], let answer = acceptedLanguages.firstIndex(of: primaryLanguage) diff --git a/ios/brave-ios/Tests/GrowthTests/LangaugeMetricsTests.swift b/ios/brave-ios/Tests/GrowthTests/LangaugeMetricsTests.swift index 58826f9b8b0..6013efe7de6 100644 --- a/ios/brave-ios/Tests/GrowthTests/LangaugeMetricsTests.swift +++ b/ios/brave-ios/Tests/GrowthTests/LangaugeMetricsTests.swift @@ -10,7 +10,7 @@ import XCTest class LanguageMetricsTests: XCTestCase { func testInvalidLanguageCodes() { - let expectedValue = Int.max - 1 + let expectedValue = Int(Int32.max - 1) XCTAssertEqual(LanguageMetrics.answerForLangaugeCode(nil), expectedValue) XCTAssertEqual(LanguageMetrics.answerForLangaugeCode("notalangugage"), expectedValue) }