5 Commits
Author SHA1 Message Date
Claudio DeSouza b9b1ce9657 [cr149] browser_navigator now in its own directory
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/815c5cff075fb58c5ec93d967479af57312a5894

commit 815c5cff075fb58c5ec93d967479af57312a5894
Author: Foromo Daniel Soromou <koretadaniel@chromium.org>
Date:   Thu Apr 30 18:38:51 2026 -0700

    Move browser_navigator files to a subdirectory

    Move the `browser_navigator*` files from `chrome/browser/ui/` to a new
    `chrome/browser/ui/navigator/` subdirectory to better organize the
    codebase. Update all corresponding include paths across the repository
    to reflect the new file locations.

    Bypass-Check-License: This is a file rename only.
    Bug: none
    Change-Id: I512c4119e212966e84001924ab2eb2e501a490d7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7801797
    Reviewed-by: Darryl James <dljames@chromium.org>
    Reviewed-by: Dana Fried <dfried@chromium.org>
    Commit-Queue: Foromo Daniel Soromou <koretadaniel@chromium.org>
    Reviewed-by: Ashley Prasad <ashleydp@google.com>
    Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
    SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>
    Cr-Commit-Position: refs/heads/main@{#1623653}
2026-05-22 16:57:32 -04:00
Claudio DeSouza c40fa41402 [cr149] //chrome/browser/ui/navigator componentised
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/a7ea861d95f70515cbddad5ea07b29ba144f5659

commit a7ea861d95f70515cbddad5ea07b29ba144f5659
Author: Foromo Daniel Soromou <koretadaniel@chromium.org>
Date:   Thu Apr 30 08:15:42 2026 -0700

    Extract browser navigator into a separate build target

    NOTE: This change is trivial and do not change any behavior.

    Extract the browser navigator code and its associated parameters from
    the monolithic `chrome/browser/ui` build target into a dedicated
    `chrome/browser/ui/navigator` directory and build configuration.

    This refactoring establishes a new standalone build file containing
    dedicated source sets for the navigator component. Consequently, the
    `browser_navigator_params_headers` source set and related source files
    are removed from `chrome/browser/ui/BUILD.gn`.

    Numerous build files across the `chrome/browser` directory are updated
    to replace the old dependency with the new
    `//chrome/browser/ui/navigator` target. This modularization decouples UI
    components, streamlines dependency management, and improves overall
    build structure.

    A follow up CL will move the files under c/b/ui/navigator and rename the
    include places.

    Bug: none
    Change-Id: I65c10afadfb1dc3857a3714cdbce6d06201633ab
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7803848
    Reviewed-by: Dana Fried <dfried@chromium.org>
    Reviewed-by: Kaan Alsan <alsan@chromium.org>
    Commit-Queue: Foromo Daniel Soromou <koretadaniel@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1623210}
2026-05-22 16:57:31 -04:00
Claudio DeSouza f3ed73cef1 [cr148] kSideBySide feature flag deleted
Since upstream deleted the related user education badges, we no longer need to
suppress those.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/13f2ce9b0bb3e2dc58238a7ac69a2f009b5b6a18

commit 13f2ce9b0bb3e2dc58238a7ac69a2f009b5b6a18
Author: Alison Gale <agale@chromium.org>
Date:   Thu Mar 12 09:08:54 2026 -0700

    [SxS] Clean up split view flags

    The bulk of the cleanup was done previously. This just removes the new
    badge.

    Bug: 473848046
    Change-Id: I83c89e1ce5184b371f518003438235a95a4030ea
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7658827
    Commit-Queue: Alison Gale <agale@chromium.org>
    Reviewed-by: David Pennington <dpenning@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1598469}
2026-04-27 12:00:45 +01:00
Claudio DeSouza ca5752f9c0 [cr146] //components/tabs:split_tabs deleted
All sources are now under `//components/split_tabs`.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/5ae8298594a5635150a832aa09184c44fa6c8c3c

commit 5ae8298594a5635150a832aa09184c44fa6c8c3c
Author: Alison Gale <agale@chromium.org>
Date:   Tue Jan 27 14:22:55 2026 -0800

    Remove the old locataion of split tab id/visual data

    Bug: 443780638
    Change-Id: I5e2592b40aa401d1b9e81a9a1bedab09f59cbd4e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7520512
    Reviewed-by: David Pennington <dpenning@chromium.org>
    Commit-Queue: Alison Gale <agale@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1575512}
2026-02-26 13:47:49 +00:00
Simon Hong db999057c0 Support link/unlink in split view behind the SplitViewLink feature (#32608)
Resolves brave/brave-browser#51094

Security review: brave/reviews#2114

When clicking link on left side split view, that link's url is loaded on right side split view.
NavigationThrottle cancels from left side split view's navigation and loads that url on the right side.
BraveBrowser::AddNewContents() handles window.open() with blank target links.
It adds split tab id tag to new contents to make NavigationThrottle know whether it's from left pane's.
For linked state, SplitTabData::linked_ is introduced.
This link feature is behind thekSplitViewLink feature is disabled by default.

TEST=SplitViewLinkTest.*
2025-12-13 13:10:56 +09:00