* Changes check_chromium_src warning into an error.
Changes the warning that catches use of defined symbols in the override,
but not in the original file into an error. All uses of such symbols
should be marked with // CHROMIUM_SRC_INTERNAL_USE comment.
* Removes symbol exclusions section of the config file.
All symbols that don't conform to check_chromium_src rules should be marked with // CHROMIUM_SRC_NOLINT comment.
[chromium_src] Allow overrides to reference original files with #include <...>
This change updates the include path handling for brave/chromium_src overrides:
- Adds support for referencing original Chromium files using #include <...> in
overrides.
- Enables this by replacing -I../../brave/chromium_src with
-iquote../../brave/chromium_src, so the path is only used for #include "..."
directives.
With this, other files in the build tree can reference brave/chromium_src
overrides using #include "...", while the overrides themselves can reference
original Chromium files using #include <...>. Since Chromium uses #include "..."
for all in-tree files, we can leverage this convention and eventually drop
support for #include "src/" by removing -I../../.. and making rbe_exec_root
modification obsolete.
* Alias settings_client internals to see in a memory dump.
* Prevent few optimizations to keep the object on stack.
* Keep ExecutionContext type in the dump.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/ed2126e6436a0f6bccca4f3cca9edb9f9a6587b2
commit ed2126e6436a0f6bccca4f3cca9edb9f9a6587b2
Author: Hans Wennborg <hans@chromium.org>
Date: Tue Aug 2 14:44:58 2022 +0000
Disable the -Wmax-tokens experiment
It appears to be doing more harm than good at this point, and in the
meantime we've gained better tools to analyze and track the include
graph. Let's see how things develop with this turned off.
Bug: 1348349, 1049569
The version of clang included with Xcode (as high as XCode 11.4.1)
doesn't recognize #pragma clang max_tokens_here.
The pragma was added to clang here:
https://reviews.llvm.org/rG739b410f1ff51d507830774320c2db3a80d8610d
The Chromium change that started using it:
https://chromium.googlesource.com/chromium/src/+/b3e433a31194beb54e70acceba9401f47c74fc7d
commit b3e433a31194beb54e70acceba9401f47c74fc7d
Author: Hans Wennborg <hans@chromium.org>
Date: Tue Apr 21 11:21:40 2020 +0000
[base] Reduce the size of base/debug/alias.h significantly.
This is a very widely included header, with
ca 11,000 transitive includes for the 'chrome' target
in Linux debug builds.
Despite providing very basic functionality, its size
was a whopping 480,000 tokens after pre-processing.
This change brings the size down to 130 tokens on
Linux.
Bug: 242216
Max Karolinskiy