This override was removed in upstream, to rely on whatever was being
used in the base class, however this functionality is still undesired in
brave, so this change readjusts the override for this class, to bring it
back.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/dfed004fc1e2cfd633b644b841abe6b2780b9e39
commit dfed004fc1e2cfd633b644b841abe6b2780b9e39
Author: Nicholas Roscino <nroscino@google.com>
Date: Wed Oct 22 02:53:56 2025 -0700
Avoid making request for OTR profiles
DevToolsHttpServiceHandler.Request now contains a check to make sure
not to make any request in case of no profile or OTR profiles.
Fixed: 445832340
Change-Id: I5675c1d288cd9efb4923b5c0f95b36951eeb6104
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7046201
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Nicholas Roscino <nroscino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1533498}
Per security/privacy teams.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/2ef1f7013a02decc3a67723397b389054def51d7
commit 2ef1f7013a02decc3a67723397b389054def51d7
Author: Ergün Erdoğmuş <ergunsh@chromium.org>
Date: Wed Aug 27 01:45:37 2025 -0700
[DevToolsUIBindings] Add GDP service handler http requests to GDP service
Design doc is here: go/chrome-devtools:gdp-in-devtools-design
Change-Id: I6764f19addb149b294ea91f97be73caba5c86928
Fixed: 441036948
This commit migrates the SplitView implementation from using individual
views for secondary content management to utilizing the centralized
BraveContentsContainerView. This change eliminates code duplication and
improves maintainability by leveraging existing infrastructure.
**Key Changes:**
** SplitView Architecture Refactoring:**
- Replace direct management of secondary_contents_web_view_,
secondary_devtools_web_view_, secondary_reader_mode_toolbar_,
secondary_lens_overlay_view_, and secondary_contents_scrim_view_
- Migrate to using a single BraveContentsContainerView instance that
encapsulates all secondary content management
** View Hierarchy Simplification:**
- secondary_contents_container_ (raw View) → secondary_contents_container_view_
(BraveContentsContainerView)
- All secondary view access now goes through the container view's accessors
- Unified layout management through BraveContentsContainerView
**Benefits:**
- Reduces code duplication between primary and secondary content management
- Leverages existing ContentsContainerView infrastructure for DevTools,
scrim views, lens overlay, and reader mode toolbar
- Simplifies view hierarchy and improves maintainability
- Better separation of concerns with centralized content management
This change updates how brave/chromium_src overrides can reference original files: it adds ability to use #include <...> along with #include "src/...". This is enabled by replacing -I../../brave/chromium_src with -iquote../../brave_chromium_src, which adds an include search path only for #include "..." directives.
With this approach, other files in the build tree can reference brave/chromium_src overrides using #include "...", while the overrides themselves can reference original Chromium files using #include <...>. Since Chromium uses #include "..." for all in-tree files, we can leverage this convention and configure our overrides so that we can drop support for #include "src/" later by removing -I../../.. and making rbe_exec_root modification obsolete (the main goal).
This is a simple header inclusion/shadow file fix.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/d004977e47c6aff2833c145caa7c183993f56524
commit d004977e47c6aff2833c145caa7c183993f56524
Author: Alex Rudenko <alexrudenko@chromium.org>
Date: Tue Oct 8 14:19:19 2024 +0000
[DevTools] move feature flags to the devtools directory
As instructed by the comment in chrome/browser/browser_features.h
that indicates that new feature flags should not be added to
chrome/browser/browser_features.h
Fixed: 370684557
Use `constexpr` strings
This PR changes moves away from uses of `const char` with two
approaches. For `.cc` files, these types are turned into constexpr ones,
which gives the compiler more leeway for optimisations.
For the constants on header files, we are converting these instances to
`inline constexpr`, in order to also reduce string duplication across
the binary.
This change was generated with a tool.
This is a simple path inclusion change, with no other effects.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/f1c60eeddc36e95ac67dc0fb4b741355c79f9d0c
commit f1c60eeddc36e95ac67dc0fb4b741355c79f9d0c
Author: dpapad <dpapad@chromium.org>
Date: Wed Oct 11 20:39:53 2023 +0000
Cleanup: Move c/b/ui/webui/devtools_ui* files to their own folder.
This is part of an effort to clean up chrome/browser/ui/webui folder,
such that most (if not all) files are under a subfolder dedicated to
to the WebUI page that uses them, along with appropriate OWNERS files.
Bug: None
* Add presubmit check for IWYU export in chromium_src headers.
* Add // IWYU pragma: export to "src/" and "../gen/" includes.
* Export brave grit headers.
* Allow multiple includes for net_log_event_type_list.h.
* Std is not used in search_engines_handler.h.
* Fix recently added headers.
Similarly to what we've done earlier in the year for other tests [1],
this patch disables entire *_browsertest.cc files by making them empty
via chromium_src overrides, as well as all the JS tests via a patch to
include_js_tests.gni, so that we avoid running any test that we know
are going to fail because of the many ways in which Brave is different
than Chromium upstream.
[1] https://github.com/brave/brave-core/pull/7953
This patch disables entire *_browsertest.cc files by making them empty
via chromium_src overrides, as well as all the JS tests via a patch to
include_js_tests.gni, so that we avoid running any test that we know
are going to fail because of the many ways in which Brave is different
than Chromium upstream.
Note that it's possible that this way of excluding tests is a bit too
agressive (i.e. it's likely that some browser tests inside the excluded
files would pass), but for now it's a good enough initial approach as
it enables us to considerably increase test coverage without having
to maintain patches in a too intrusive way.
As a reference, a this time of this patch's writing (on top of Brave
1.23.30 / Chromium 89.0.4389.86), this are the stats when running
upstream's unit tests on a Linux/Debug build, without this patch:
* Total run: 13355 tests
* Passed: 10427 tests
* Not passed: 2928 tests
- Failed: 870 tests
- Crashed: 1593 tests
- Timed out: 465 tests
With this patch applied, the numbers look like this:
* Total run: 2957 tests
* Passed: 2957 tests
* Not passed: 0 tests
That is, what we have with this patch applied looks as follows:
* 2957/13355 -> 22.14% of ALL the original tests being run
* 2957/10427 -> 28.36% of the PASSING TESTS still being run
In other words, we're increasing test coverage in 2957 browser tests
in a relatively clean way (i.e. no complex patching) while losing
71.64% of the browser tests that would run and pass if we were not
excluding them in such an agressive way. Not as good results as for
the case of unit tests, but still an improvement for test coverage.
Fix https://github.com/brave/brave-browser/issues/8297
This patch disables entire *_unittests.cc files by making them empty
via chromium_src overrides, so that we avoid running any test that
we know are going to fail because of the many ways in which Brave is
different than Chromium upstream.
Note that it's possible that this way of excluding tests is a bit too
agressive (i.e. it's likely that some unit tests inside the excluded
files would pass), but for now it's a good enough initial approach as
it enables us to considerably increase test coverage without having
to maintain patches in a too intrusive way.
As a reference, a this time of this patch's writing (on top of Brave
1.23.30 / Chromium 89.0.4389.86), this are the stats when running
upstream's unit tests on a Linux/Debug build, without this patch:
* Total run: 13504 tests
* Passed: 11585 tests
* Not passed: 1919 tests
- Failed: 182 tests
- Crashed: 1737 tests
- Timed out: 0 tests
With this patch applied, the numbers look like this:
* Total run: 10045 tests
* Passed: 10045 tests
* Not passed: 0 tests
That is, what we have with this patch applied looks as follows:
* 10045/13504 -> 74.39% of ALL the original tests being run
* 10045/11585 -> 86.71% of the PASSING TESTS still being run
In other words, we're increasing test coverage in 10045 unit tests
in a relatively clean way (i.e. no complex patching) while "only"
losing 13.29% of the unit tests that would run and pass if we were
not excluding them in such an agressive way.
Fix https://github.com/brave/brave-browser/issues/8376
Max Karolinskiy