This change updates how brave/chromium_src overrides can reference original files: it adds ability to use #include <...> along with #include "src/...". This is enabled by replacing -I../../brave/chromium_src with -iquote../../brave_chromium_src, which adds an include search path only for #include "..." directives.
With this approach, other files in the build tree can reference brave/chromium_src overrides using #include "...", while the overrides themselves can reference original Chromium files using #include <...>. Since Chromium uses #include "..." for all in-tree files, we can leverage this convention and configure our overrides so that we can drop support for #include "src/" later by removing -I../../.. and making rbe_exec_root modification obsolete (the main goal).
In cr127, features::kWinrtGeolocationImplementation (and a related Mac feature
flag) were replaced with kLocationProviderManager. Enable that flag and set it
to kPlatformOnly so that we use the platform's geolocation provider.
Chromiuum change:
https://source.chromium.org/chromium/chromium/src/+/cc04eb8474feb1d62287c0866af29351aa762186
commit cc04eb8474feb1d62287c0866af29351aa762186
Author: alvinji <alvinji@chromium.org>
Date: Wed May 15 23:06:21 2024 +0000
geolocation: Add kLocationProviderManager feature flag
This CL adds `kLocationProviderManager` feature flag and associated
parameters to enable flexible mode configuration of the
LocationProviderManager (implementation to follow). The configuration
will determine which location provider is used as the source for
Geolocation API.
Change-Id: I98a2a25f7b05002fb6a1244fde5091a96bad2756
Bug: 333294295
This feature flag is being removed. Confirmed that the current default behavior
as implemented via kLocationProviderManager is acceptable.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/cc04eb8474feb1d62287c0866af29351aa762186
commit cc04eb8474feb1d62287c0866af29351aa762186
Author: alvinji <alvinji@chromium.org>
Date: Wed May 15 23:06:21 2024 +0000
geolocation: Add kLocationProviderManager feature flag
This CL adds `kLocationProviderManager` feature flag and associated
parameters to enable flexible mode configuration of the
LocationProviderManager (implementation to follow). The configuration
will determine which location provider is used as the source for
Geolocation API.
Change-Id: I98a2a25f7b05002fb6a1244fde5091a96bad2756
Bug: 333294295
* Add support for default feature state override.
* Convert runtime feature overrides to static overrides.
* Support overrides set via a single macro instantiation.
* Remove unused include.
Aleksei Khoroshilov