5 Commits
Author SHA1 Message Date
cdesouza-chromium 3998467be9 [IWYU] Fixing logging inclusions //components (#29511)
This change is one of many fixing inclusion for the following files:

    - `base/notimplemented.h`
    - `base/notreached.h`
    - `base/check.h`
    - `base/dcheck_is_on.h`
    - `base/check_deref.h`
    - `base/check_op.h`
    - `base/logging/log_severity.h`
    - `base/logging.h`

This change is a mechanical change done with the following script:
https://github.com/brave/brave-browser/issues/46707#issuecomment-2960116515

Resolves https://github.com/brave/brave-browser/issues/46707
2025-06-11 16:03:11 +01:00
Pavel Beloborodov 33e16ff315 New speedreader tune dialog (#19715)
* New speedreader tune dialog
2023-08-29 20:57:06 +07:00
Kevin Kuehler c5677c6be5 speedreader tab helper and test fixes
* Use NavigationEntryCommitted() instead of DidNavigationFinish(). We
    have no guarantees about the next DidNavigationStart() being called
    first.
  * Fix throttle unit test
  * Make several review requests to SpeedreaderBrowserTest
2021-09-03 10:20:13 -07:00
Kevin Kuehler 47f68c7677 Update entry cache in DidFinishNavigation()
Previously we were persisting the SpeedreaderExtendedInfoHandler data to
the NavigationEntry in OnDistillComplete(). Since OnDistillComplete() is
called by the throttle, the navigation entry might not be persisted yet,
so the behavior is not defined. On backward navigations we would
sometimes persist to the previous navigation entry, causing bugs where
pages would incorrectly show up as readable. Since we wait for
DidFinishNavigation, we can safely get the last committed navgiation
entry.
2021-09-02 11:37:27 -07:00
Kevin Kuehler 5e3d893bed Refactor for review
* Use the DistillState enum in
    SpeedreaderExtendedInfoHandler to de-duplicate logic.
  * Move DistillState to speedreader component
  * Move SpeedreaderExtendedInfoHandler to speedreader component
  * Pass wc_getter to SpeedreaderThrottle instead of creating the
    lifetime helper
2021-09-02 11:37:26 -07:00