60 Commits
Author SHA1 Message Date
Aleksei Seren a92c7a0fd1 Remove Brave News inline content ads dead code on Desktop (#36360)
The display ad pipeline on desktop was already disabled. This PR removes the
remaining frontend code and portions of the mojom code that no longer had any
effect. The remaining mojom code is still required for Android builds and will be
removed in a follow-up when the dead code for Brave News inline content ads
on Android is cleaned up.
2026-05-12 15:56:10 -05:00
Kevin Smith beee7d891d [Rewards] Remove Gemini wallet provider (#35380) 2026-04-14 22:11:29 -04:00
Jay Harris 7069730e49 [AI Rewriter]: Remove feature as it is unused and not maintained (#34635) 2026-03-12 03:09:51 +00:00
Kevin Smith a6bce82a33 [Rewards] Reland: Move content and engine targets behind build flag (#33932)
This change moves the Brave Rewards code in "content" and "engine"
behind the ENABLE_BRAVE_REWARDS buildflag. In order to simplify
dependencies, it also moves the buildflags defined in "engine" to
"core/buildflags".
2026-02-17 20:41:53 -05:00
Mihai PLESA 58b2c2932c Revert "[Rewards] Move content and engine targets behind build flag" (#33929)
Revert "[Rewards] Move content and engine targets behind build flag (#33898)"

This reverts commit fe5425a9af.
2026-02-13 10:03:37 +00:00
Kevin Smith fe5425a9af [Rewards] Move content and engine targets behind build flag (#33898) 2026-02-12 13:42:45 -05:00
cdesouza-chromium 9579407238 [CodeHealth][cr146] base::Contains dissallowed when .contains suffices (#33631)
[CodeHealth][cr146] `base::Contains` dissallowed when `.contains` suffices it

This is being enforced by the compiler through a concept, and it only
applies for cases where `base::Contains` is used without a projection.
This change also carries out IWYU for `base::Contains`.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/4a17af8403373b7f7e7546ef61f30dfbe883d617

```
commit 4a17af8403373b7f7e7546ef61f30dfbe883d617
Author: Victor Hugo Vianna Silva <victorvianna@google.com>
Date:   Tue Jan 13 07:30:34 2026 -0800

    Disallow base::Contains() when contains() or find() methods available

    This is a temporary step towards deleting base::Contains().
    Trying to call base::Contains(foo, bar) will now cause a static
    assertion failure if foo has contains() or find() methods. This
    effectively makes base::Contains() an alias to std::ranges::contains().
    The result is we can replace instances of 'base::Contains' with
    'std::ranges::contains' in upcoming CLs while being sure to not
    regress performance.

    Bug: 470391351
    Change-Id: I8778f435ff8f5b52fb3bf336724f2dfef388907a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7415207
    Commit-Queue: Francois Pierre Doray <fdoray@chromium.org>
    Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1568392}
```

Bug: https://github.com/brave/brave-browser/issues/42557
2026-02-04 13:22:50 -03:00
vadims 475a963e50 New issue category for Webcompat Reporter: Browser not supported (#31617)
Added new reason category: `Browser not supported` for webcompat report
dropdown menu.

Resolves: https://github.com/brave/brave-browser/issues/49865
---------

Signed-off-by: Vadym Struts <vstruts@brave.com>
2025-10-04 19:25:22 +02:00
cdesouza-chromium 5eb666f034 [CodeHealth] Run gn format on all files (#30448)
This PR is the run of `gn format` on all `gn` files. This is a
mechanical change done with:

```sh
git ls-files -- "*.gn" | xargs gn format
git ls-files -- "*.gni" | xargs gn format
```

This change has been motivated primarily by an improvement to the
formatters privided by `gn` correcting cases of redundant target naming,
i.e cases where `//foo:foo` is used, and should just be `//foo`.

For this particular `gn` change, see:
https://chromium.googlesource.com/chromium/src/+/c822490a82cdb6ad479159683a92858f7c6f0a58

Resolves https://github.com/brave/brave-browser/issues/48161
2025-08-05 18:08:10 +01:00
Brandon-T 57b7d93b7d [iOS] - Refactor WebUI iOS code datasources to match Chromium structure (#29904)
* Move //brave/ios/browser/ui/webui data-sources to //brave/ios/web/webui as it is in Chromium
2025-07-16 22:43:29 +02:00
Anton Lazarev b1ae69a045 Merge pull request #29909 from brave/webcompat-reporter-categories
Add categories to webcompat reporter
2025-07-09 19:21:08 -07:00
Anton Lazarev f8406592bb add category field to webcompat reporter UI and reports 2025-07-09 14:46:19 -07:00
Kevin Smith af32f81ed8 [Rewards] Only report ads viewed that have a non-zero value (#29955) 2025-07-09 08:20:02 -04:00
Jay Harris 266cb4db0e [Brave News]: Use the new strings system for Brave News (#29847)
* [Brave News]: Migrate to new strings system

* [i18n]: Make it possible to combine const enums
2025-07-02 08:18:23 +12:00
cdesouza-chromium 34c2028c47 [IWYU] Fix includes for utf conversion functions (#29709)
This PR does IWYU for the following files:

 - base/strings/utf_string_conversions.h
 - base/i18n/number_formatting.h

This is a mechanical change, and for more details, check the issue
description.

Resolves https://github.com/brave/brave-browser/issues/47060
2025-06-23 22:44:37 +01:00
Anton Paymyshev a9cbf75ae4 Fix implicit deps on components/grit (#29611) 2025-06-18 14:07:01 +07:00
Brian Johnson c75d1de3d3 [CodeHealth] remove brave_l10n::GetLocalizedResourceUTF16String (#28889)
remove brave_l10n::GetLocalizedResourceUTF16String and replace with ui/base/l10n
2025-05-01 04:22:24 -07:00
aseren 1ff768b451 [ads] Add New Tab Takeover Learn More link in settings (#28597) 2025-04-24 16:22:21 -05:00
Kevin Smith e7c7055605 [Rewards] Refresh Rewards internals (#28168) 2025-03-18 11:23:55 -04:00
vadims cefa148556 [Webcompat report dialog] Contact info still appears in the form after deleting (#27155)
[Webcompat report dialog] Contact info still appears in the form after deleting
(https://github.com/brave/brave-browser/issues/43166)
---------

Signed-off-by: Vadym Struts <vstruts@brave.com>
2025-01-14 23:15:15 +01:00
Brian Johnson afd4e0239d fix overly permissive DEPS (#27193)
Fix overly permissive deps
2025-01-12 21:43:04 -07:00
Simon Hong e731f412e5 Added recover link to vpn card widget
fix https://github.com/brave/brave-browser/issues/42615
2024-12-04 15:22:30 +09:00
Simon Hong 18077fc17a Done card widget localization 2024-11-09 17:25:50 +09:00
Simon Hong 400777957d fixup! WIP: Polish widget UI 2024-11-09 17:25:49 +09:00
Simon Hong 96c6377529 WIP: Show vpn widget card 2024-11-09 17:25:47 +09:00
Jocelyn Liu efcb1df7c6 Remove enable_ai_chat buildflag 2024-10-31 20:15:18 -07:00
Claudio DeSouza ef8636fe99 std::vector<const T> is undefined
The standard disallows the use of `std::allocator<T>`, and a warning has
been enabled recently up in the toochain to detect such violations.

https://clang.llvm.org/extra/clang-tidy/checks/portability/std-allocator-const.html
2024-08-07 21:31:24 -04:00
zenparsing 19f98336b3 [Rewards 3.0] Add connect account UI 2024-07-22 17:15:30 -04:00
vadimsandNuo Xu 43735ef5b2 Deprecate local node support and ipfs scheme (#23808)
deprecated IPFS local node support and IPFS scheme
https://github.com/brave/brave-browser/issues/37735
---------

Signed-off-by: Vadym Struts <vstruts@brave.com>
Co-authored-by: Nuo Xu <nuoxu.nx@gmail.com>
2024-07-09 12:34:31 +02:00
zenparsing bf99f322e8 Update footer icons on the NTP 2024-07-01 09:31:41 -04:00
Jay Harris 8b177a02cc [NTP Search]: Add prompt for enabling suggestions (#24338) 2024-06-26 09:20:43 +12:00
Jay Harris 62f20b1df0 [NTP Search]: More UX tweaks (#24023) 2024-06-07 19:40:20 +12:00
Jay Harris c5afd90fc6 [NTP Search]: Various UX tweaks (#23861) 2024-05-29 10:03:25 +12:00
Jay Harris 0bcd5f81aa [AI Rewriter]: Introduce placeholder UI behind a flag (#23688) 2024-05-28 10:28:55 +12:00
zenparsing 3c09382e71 Add Search Ads controls to Rewards page 2024-05-17 11:18:29 -04:00
Jay Harris 3d87829503 [NTP Search]: Add translations (#23629) 2024-05-14 06:13:51 +01:00
Claudio DeSouza 8472d263ec string_view/std::array now with iterator type
Updates to the toolchain have landed an llvm change where
`std::array<std::string_view>` has an iterator type, rether than just
using a pointer. This change corrects our instantiations of such
iterators.

llvm change:
https://github.com/llvm/llvm-project/commit/5174b3802575425dcbc58680ccce10961fdb8b67
2024-05-03 16:54:02 -04:00
Jay Harris 23a869fa0b [Brave News]: Add missing translations (#21330) 2024-03-26 03:42:41 +01:00
zenparsing 23b3b2b18a Remove vBAT promotions support 2024-03-19 16:53:39 -04:00
Jay Harris fea03df89c [NTP Search]: Add settings for customizing which engines to show (#22585) 2024-03-15 12:51:40 +13:00
Darnell Andries 332feb2248 Add webcompat reporter screenshot preview 2024-03-11 11:26:27 -07:00
Darnell Andries 090e85d223 Webcompat reporter changes as per feedback 2024-03-11 10:42:25 -07:00
Darnell Andries 08dc0326c8 Disallow webcompat reports for error pages 2024-03-11 10:42:24 -07:00
Darnell Andries 1ae90a3f55 Webcompat reporter adjustments as per feedback 2024-03-11 10:42:24 -07:00
Darnell Andries 2ee6813262 Disable webcompat reporting for internal web pages, update webcompat disclaimer and include link to relevant webcompat wiki page 2024-03-11 10:42:24 -07:00
Darnell Andries 6e43ca324e Add screenshot support for webcompat reports 2024-03-11 10:42:20 -07:00
zenparsing d26b5ec3b2 Remove special-case UI for no avalidable custodians 2024-03-11 10:14:56 -04:00
zenparsing e3edd942d1 Add Rewards terms of service update notifications 2024-03-06 10:47:01 -05:00
mkarolin dade82f68b Do not show Rewards NTP Widget in unsupported regions. 2024-02-26 13:24:20 -05:00
zenparsing 25bd1c13dd Fix display of external wallet info in rewards-internals 2024-02-05 15:56:06 -05:00