Brian R. Bondy
dbab29c929
Fix intermittent failure JsSkusBrowserTest.AttachSkus ( #30791 )
...
Fix for the render frame observer which is created on the stack in the
test file, but its `OnDestruct` calls `delete this;`
https://github.com/brave/brave-core/commit/9d896aaa5d0b0873434bee37a92f89e78e8661fe#diff-9b6f35d6bb55585416f5c5b7f[…]531e094f6039534e46870f267e84R68
Added the `delete this;`
And then a later commit added the test which created it on the stack:
https://github.com/brave/brave-core/commit/0a03ac5defcc619296085cdd8e4654521efe6ec5#diff-10e48a4b1e39427a1c98f8882[…]4d712ff32b2affd45df70ee319e2R35
i
2025-08-25 14:14:52 -04:00
cdesouza-chromium
c3899b612c
[CodeHealth] Avoid inefficient std::string(other_string.c_str()) ( #29386 )
...
This PR fixes a few places where the use of `c_str()` is not required,
and in fact leads to an extra `strlen`-like call.
Resolves https://github.com/brave/brave-browser/issues/46570
2025-06-04 19:53:44 +01:00
Max Karolinskiy
4408e257f6
[cr137] Adjust skus browser test.
...
Removed Reload from the test because it no longer works correctly after
the below upstream change. Chromium team might fix the Reload
functionality at a later time. See
https://chromium-review.googlesource.com/c/chromium/src/+/6406554/comments/4e04615d_9a21db9d
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/ae845bfbaace3a356b66de078d6d70c84192c7f7
commit ae845bfbaace3a356b66de078d6d70c84192c7f7
Author: Diana Qu <xiaqu@microsoft.com >
Date: Thu Apr 3 13:12:37 2025 -0700
Remove "UseBrowserCalculatedOrigin" feature flag.
Remove released feature flag. Always set commit origin.
Bug: 402272788
2025-05-13 15:53:11 -04:00
Brian Clifton
0a03ac5def
Gin cleanup for SKUs
...
Following best practices from BraveWalletRenderFrameObserver / JSSolanaProvider
2022-08-29 09:57:04 -07:00
Claudio DeSouza
bf2f8912ec
chrome/common_lib has visibility contraints
...
Chromium change:
https://chromium.googlesource.com/chromium/src/+/fc7150eac99a921b0a0ef6b6284fadb57f0702ea
commit fc7150eac99a921b0a0ef6b6284fadb57f0702ea
Author: Henrique Ferreiro <hferreiro@igalia.com >
Date: Fri May 13 22:40:38 2022 +0000
Restrict the visibility of //chrome/common:common_lib
//chrome/common and //chrome/common:common_lib split is an internal
detail to allow the existance of ":delay_load_support" as a source_set
and not part of the common static library. Restrict the visibility of
":common_lib", since //chrome/common remains the main target to depend
on.
2022-07-22 13:33:55 +01:00
Sergey P
f1dd849dcf
Enable skus feature for tests
2022-06-18 13:02:22 +03:00
cepera
32a806c32b
Native implementation non-writable property
2022-06-18 13:02:22 +03:00
Brian R. Bondy