TypeScript compilation failed. Used tsconfig gen/third_party/devtools-frontend/src/front_end/panels/network/network-tsconfig.json
third_party/devtools-frontend/src/front_end/panels/network/RequestAdblockView.ts(6,1): error TS6133: 'i18n' is declared but its value is never read.
Chromium change:
https://source.chromium.org/chromium/_/chromium/devtools/devtools-frontend/+/328b3a7c2d447b988e7e26e87af1d6ba30848894
[cleanup] Expose `RenderCoordinator` methods as functions.
This is step one to making the `RenderCoordinator` more ergonomic to use
(and our codebase slightly more readable): Instead of going via the
singleton all the time, just expose the `RenderCoordinator` methods as
functions on the `RenderCoordinator` module. That makes code shorter and
easier on the eyes, and also doesn't leave the engineer wondering why on
earth the `RenderCoordinator` is a class.
The second step will be to replace the implementation of the render
coordinator with just functions instead of the singleton.
Bug: 387186170
Chromium change:
https://source.chromium.org/chromium/_/chromium/devtools/devtools-frontend/+/8d94a72e2fad3764dd347ff6c755b5613caae03d
commit 8d94a72e2fad3764dd347ff6c755b5613caae03d (origin/chromium/6934)
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Thu Jan 2 14:00:42 2025 +0100
[cleanup] Remove our custom implementation of `lit/static-html`.
When we were using `litTagName` heavily, we rolled our own custom
implementation of `lit/static-html`, which was optimized for the
common case in our codebase. With the removal of `litTagName` we
are left with only one place in the codebase where we use, and in
this particular code path our optimization is useless (and even
costs us more), since the `litTagName` changes in every loop
iteration.
Use the upstream `lit/static-html` module instead and remove our
custom logic. This makes all regular calls to `html` faster in
DevTools, since we no longer preprocess the template string
looking for potential static parts.
Drive-by-fix: Fix the build for `front_end/third_party/lit`.
Bug: 370734442
Claudio DeSouza