Chromium changes:
https://chromium.googlesource.com/chromium/src/+/11320f06e117d93f40f0443cd67c55ad65c5943f
commit 11320f06e117d93f40f0443cd67c55ad65c5943f
Author: Pâris MEULEMAN <pmeuleman@chromium.org>
Date: Fri Jul 26 17:11:09 2019 +0000
Merge SigninManagerDelegate back into SigninManager
This merges back SigninManagerDelegate.java into SigninManager.java and
likewise for c++ code. This is in the scope of a change of strategy
regarding the identityManager implementation on Android, using a
layering strategy similar to what was done on iOS.
The change consist in:
* copy chrome_signin_manager_delegate.* methods to
signin_manager_android.*
* rename occurrences of ChromeSigninManagerDelegate to
SigninManagerAndroid, in Java including JNI invocations and C++.
* Directly invoke methods instead of calling mDelegate (java)
* Update constructors to include the delegate dependencies.
* A significant change that is not an obvious code move is the rollback of
SigninManagerAndroid's constructor using
SigninClient/PrefService(local_state) to Profile. This makes the
remainder of the change much simpler, but does cascade to the factory.
The above changes are described in their files in PS3:
crrev.com/c/1700210/3
Chromium change:
https://chromium.googlesource.com/chromium/src/+/e3f6e640902edcaa2d2cb431ae9d15b419303c1c
commit e3f6e640902edcaa2d2cb431ae9d15b419303c1c
Author: Natalie Chouinard <chouinard@chromium.org>
Date: Fri Jul 26 20:42:38 2019 +0000
Remove Compat suffix from Preferences
Now that the preferences Support Library migration is complete, and
duplicates have been removed (crrev.com/c/1709880), we can remove the
Compat suffix from all methods and classes.
Bug: 967022
Chromium change:
https://chromium.googlesource.com/chromium/src/+/d6b8adac674244c5c104cbd70bb7da0d4b6d4cab
commit d6b8adac674244c5c104cbd70bb7da0d4b6d4cab
Author: Eric Stevenson <estevenson@chromium.org>
Date: Fri Jul 26 21:26:06 2019 +0000
jni_generator: Fix jcaller usage.
This CL changes static methods to not pass a jcaller object to
the native side. This isn't necessary because there is no Java object
instance for static methods and it was actually just passing a jclass
as a jobject which was always unused.
The @JCaller annotation is also removed. It isn't strictly necessary
anymore and is often used incorrectly (i.e. using @JCaller and adding
an unused param on the native side).
All Java and native definitions and uses are also updated to reflect
the changed logic.
Tbr: agrieve@chromium.org # Large mechanical refactor.
Bug: 986930
Makes SiteSettingsPreferences inherits BraveSiteSettingsPreferencesBase.
With this, we don't need to modify multiple preferences xml files.
Only need to change one SiteSettingsPreferences.java file.
Global desktop mode setting is applied to webcontents only when tab
is created. We can know this by whether checking last committed
entry is null or not.
With this, we don't need to modify Tab.java.
DesktopModeTabHelper overrides when new WebContents is created.
DesktopMode changing will affect to newly created Tab.
So, existing tab will not be changed desktop mode.
If user choose desktop view option explicitly, we respect it during the
life time of the Tab.
To initialize initial prefs for dual DSE, it needs default TemplateUrl.
It can be fetched after TemplateUrlService loading is done.
So, initialization is done after loading is finished.
Brave uses different DSE for standard and private but chromium uses
single DSE for both.
To achieve our goal, we set proper DSE whenever standard/private context is
changed.
Run updateBravePreferences() after fininshing MainPreferences::updatePreferences().
Otherwise, some prefs could be added after finishing updateBravePreferences().
Shields button should be clickable always.
This bug is regression from controlling enable/disable shields button.
To fix this, shields button should be always enabled.
The purpose of disabling shields button was preventing shields button
click when tab is not ready.
So, instead of disabling shields button, just return when current tab is
null during the handling of click.
And enable/disableShieldsButton methods are integrated into
updateBraveShieldsButtonState().
Also, shields popup will be displayed only for http/https protocols.
Jocelyn Liu