Commit Graph
3449 Commits
Author SHA1 Message Date
Max Karolinskiy 1af18b4eee [Android] integerListToIntArray -> integerCollectionToIntArray.
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/9ccf06ad6b9d9dbf887274f60665bba8af145e4c

commit 9ccf06ad6b9d9dbf887274f60665bba8af145e4c
Author: vikas.mundra <vikas.mundra@samsung.com>
Date:   Tue Aug 8 14:45:01 2023 +0000

    Change integerListToIntArray to handle Collection<Integer>.

    Bug: None
2023-09-06 12:38:51 +01:00
Max Karolinskiy 45bcb78064 [Android] Suggest components moved to appropriate packages.
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/6e3695055282bde2999201b8c5a7629428831f2e

commit 6e3695055282bde2999201b8c5a7629428831f2e
Author: Tomasz Wiszkowski <ender@google.com>
Date:   Fri Aug 4 17:03:26 2023 +0000

    Move suggest components to appropriate packages.

    The change moves
    - SuggestionSpanable to styles package (away from `base`),
    - HistoryClustersProcessor to history_clusters package (ditto).

    The change bumps test coverage for both relocated classes to 100%.
2023-09-06 12:38:51 +01:00
Max Karolinskiy 1007ebbc26 [Android] Presubmit: fixes naming conventions warnings. 2023-09-06 12:38:51 +01:00
Max Karolinskiy b1239a0d2c [Android] Presubmit: fixes if/for without {}. 2023-09-06 12:38:51 +01:00
Max Karolinskiy 693757862b [Android] Presumit: remove unused imports. 2023-09-06 12:38:51 +01:00
Artem Samoilenko a0ad3c094b [Android] [Empty States] Add tablet illustration to recent tab
Chromium change:
https://github.com/brave/chromium/commit/6c891621562a604a4081d2279ab182297d68e4f1

[Empty States] Add tablet illustration to recent tab
Tablet: https://screenshot.googleplex.com/3irSZPrQihe4Aes
Phone: https://screenshot.googleplex.com/5uYdnTStBGA6Xre

Bug: 1468426
2023-09-06 12:38:50 +01:00
Artem Samoilenko 8f48dbdea7 [Android] Explicitly added action for Brave intents
Otherwise there is lint issue:
Warning: This intent has no action set and is not explicit by component.You should either make this intent explicit by component or set an action matching the targeted intent filter. [IntentWithNullActionLaunch]
2023-09-06 12:38:50 +01:00
Artem Samoilenko 4d7af65e5c [Android] New dialogs for empty states
There are new dialogs that are shown when there are no items to show
(eg. no tabs to show, no history, no downdoaded items etc.). Design team
provided new icons for those dialogs.

Chromium changes:
https://github.com/brave/chromium/commit/29065911522b05a09c397504c8ca4f932c6a77af

Reland "[Empty States] Add empty state illustrations to tab switcher UI"
This is a reland of commit e108b3c

- Previously we rely solely on mModel to determine whether tab switcher is in empty state, however, mModel gets reset to null every time in a postHidingCleanup and thus caused the empty view to show up unexpectedly after ~30s of closing tab switcher. To address this issue, we used a     boolean mIsTabSwitcherShowing in TabListEmptyCoordinator. We set the boolean to true from TabListCoordinator.prepareTabSwitcherView() and set it to false from TabListCoordinator.postHiding. That way, we would know whether the mModel signal is from the actual tab switcher usage or from a cleanup.

Phone demo: https://drive.google.com/file/d/15tmY9gKVocYcUSzC40CCOkuiLX3KoCra/view?usp=sharing

Tablet demo:
https://drive.google.com/file/d/15vT6d-lRE8b2p3XJIhZawb7mmTKTeq9J/view?usp=sharing

Bug: 1431589, 1431588

Original change's description:
> [Empty States] Add empty state illustrations to tab switcher UI
>
> - Add TabListEmptyCoordinator class to initialize empty state resources and use ListObserver to observe mModel to decide when to add /remove empty view.
>     - Add empty view when user close a tab and tab count drops to 0.
>     - Remove empty state view when user add tab
>
> - Apply phone_tab_switcher_empty_state_illustration.xml to icon image view when form factor is phone.
> - Apply tablet_tab_switcher_empty_state_illustration.xml to icon image view when form factor is tablet.
>
> Phone demo: https://drive.google.com/file/d/17deVSRomQUQ1wj5Ml04FTM3tJ0ZXXKZo/view?usp=sharing
> Tablet demo: https://drive.google.com/file/d/1012QQcwxmBoqx7TUjOun7BlO6z2sP4o6/view?usp=sharing
>
> Change-Id: I43b89866ae612a05912b0256790cd538b38417f5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4531843
> Reviewed-by: Theresa Sullivan <twellington@chromium.org>
> Commit-Queue: Theresa Sullivan <twellington@chromium.org>
> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1147331}

Change-Id: I0126b9a34bca7f0194b2f08c39495c19020cb618

https://github.com/brave/chromium/commit/8128eb6222ea1d237fc2ac0393e40c8ac2de4f1c

[Empty States] Add empty state illustration to Download page
- Add empty state vector drawable and layout.
  - Added downloads_empty_state_illustration.xml
  - Added downloads_empty_state_view.xml (switch to this new layout when FF is enabled)

- Use GM3 Material colors for empty state icon.
  - Since we currently can only use GM3 tokens to get Material dynamic colors in v31 or above, we have to define some not pre-existing GM3 baseline colors with values in color_palette.xml for pre-v31.
  - GM3 Material dynamic colors defined in (need google3 MaterialComponent dependency):  components/browser_ui/styles/android/java/res/values-v31/colors.xml
  - GM3 Material baseline colors defined in: ui/android/java/res/values/color_palette.xml

- Add Download empty state text strings
  - IDS_DOWNLOAD_MANAGER_NO_DOWNLOADS_EMPTY_STATE
  - IDS_DOWNLOAD_MANAGER_NO_DOWNLOADS_VIEW_OFFLINE_OR_SHARE

Tablet demo:
https://drive.google.com/file/d/1MAtvIlV5sw5U9-zSBmhvfZerqt8jpXfr/view?usp=sharing
Phone demo:
https://drive.google.com/file/d/11TchlrDojWS1XKr6pHtw5ihH_cKdXnT8/view?usp=sharing

Spec: https://www.figma.com/file/wuV3Cx7zhj5O9Hydi7Qxaz/clank-empty-states?node-id=0-1&t=XSFbBmuUjClfkrkH-0

Bug: 1431575

https://github.com/brave/chromium/commit/35223bcab6b70ebf9d01a92715fa3d63965d98d5

[Empty States] Add empty state illustration to History page
- Add empty state vector drawable and layout.
  - Added history_empty_state_illustration.xml
  - Added history_empty_state_view.xml

- In HistoryManager.java, call #mSelectableListLayout.initializeEmptyStateView when Empty State FF is enabled.

- Use ViewStub as Empty State view holder in SelectableListLayout.xml and inflate layout in SelectableListLayout.java when Empty State FF is enabled.

- Add History empty state text strings
  - IDS_HISTORY_MANAGER_EMPTY_STATE
  - IDS_HISTORY_MANAGER_EMPTY_STATE_VIEW_OR_CLEAR_PAGE_VISITED

Phone Demo: https://drive.google.com/file/d/13FUM_x9ooStyZfo6gi4ZtniQdf2Sv4oD/view?usp=sharing
Tablet Demo: https://drive.google.com/file/d/1M8kyncAFdbkY-uCXeoQZlphIOd11zf8a/view?usp=sharing

Bug: 1431575

https://github.com/brave/chromium/commit/f45eef2ccb48048ce510318e17804c9f3155a9e4

[Empty States] Add empty state illustration to Bookmark & Reading lis…
…t pages

- Add bookmark_empty_state_illustration.xml & reading_list_empty_state_illustration.xml
- Initialize Empty State view in BookmarkManagerCoordinator
- Set string and image resources in BookmarkManagerMediator depending  on if we are in bookmark or reading list folder

Phone demo: https://drive.google.com/file/d/11CBTJz4g9mI-X27C8chmdKFJg6WMgwMQ/view?usp=sharing
Tablet demo: https://drive.google.com/file/d/12-8oYox0g806mB3TFJqpzps4u1mMNLl7/view?usp=sharing

Bug: 1431572, 1431580
2023-09-06 12:38:48 +01:00
Artem Samoilenko 145681c02a [Android] Remove tab groups auto creation
Chromium change:
https://github.com/brave/chromium/commit/aa78b431380e08988cccde7e6e2a167568da64a9

[Tab Groups] Remove auto creation and menu order params
Remove tab group auto creation and menu order params as these are
launched in their current and final states.

Tab Group Auto Creation is disabled.
New Tab In Group is first in the context menu.

Bug: 1188370
2023-09-06 12:38:48 +01:00
Artem Samoilenko dedafca97d [Android] Fix for conflicting string error 2023-09-06 12:38:46 +01:00
Artem Samoilenko b56fd68709 [Android] Sync settings adjustments
Chromium change:
https://github.com/brave/chromium/commit/89afc5b2f860fbdb1f4dadf277ac9f4270494a68

[ManagedSyncSettings] Refactor PAYMENTS to unify more with other toggles
Starting with https://crrev.com/c/4660713, PAYMENTS is also listed as
syncer::UserSelectableType. To unify code, this patch adds the
corresponding entry to ManagedSyncSettings.mSyncTypePreferencesMap,
making it unnecessary to have a separate member variable (before this
patch, mSyncPaymentsIntegration).

Some special-casing is still needed because there is still coupling
between the PAYMENTS and AUTOFILL toggles, planned to be removed in
the future as tracked in https://crbug.com/1435431.

Bug: 1459963
2023-09-06 12:38:46 +01:00
Artem Samoilenko 8a89c61ed3 [Android] Delete JNI Generator annotation processor
Chromium change:
https://chromium.googlesource.com/chromium/src/+/cdc544c1dba1553d9a2ad8c57e41cd3c39a0efdb

Delete JNI Generator annotation processor

This completes the migration to srcjars.

Bug: 1410871
2023-09-06 12:38:46 +01:00
Artem Samoilenko 97d8e8404b [Android] Minor code adjustments to the C117 upstream changes 2023-09-06 12:38:46 +01:00
Artem Samoilenko 6a19d850b4 [Android] Reduce usage of getLastUsedRegularProfile in FirstRun
Chromium change:
https://chromium.googlesource.com/chromium/src/+/94a370d6630a480850c4d9680efd3f42ef2bc73b

Reduce usage of getLastUsedRegularProfile in FirstRun.

BUG=1410601

Change-Id: Ib9a8500a59aad3ad8469580293342ef8294a62a7
2023-09-06 12:38:46 +01:00
Artem Samoilenko eb0580e5a3 [Android] Rename baseline neutral colors
Chromium change:
https://chromium.googlesource.com/chromium/src/+/5c79b41d11275a26499f6969fbb21dd9f4c19de9

[GMNext] Rename baseline neutral colors

This CL updates the baseline neutral colors to align with the new GM3
tonal palette names, i.e. 0 to 1000 with 1000 being black to 0 to 100
with 100 being white.

Bug: 1441952
2023-09-06 12:38:45 +01:00
Darnell Andries c71fc69519 Merge pull request #19977 from brave/news-p3a-usage-android-fix
Fix News daily and monthly usage metrics for Android
2023-09-05 13:27:03 -07:00
deeppandya c524ba2d6c Resolve presubmit issue 2023-09-05 09:59:16 -04:00
deeppandya 72e7ac2ebe Add image resources
Update existing changes
2023-09-05 09:54:00 -04:00
deeppandya 605647d888 Update payout logic with UI
Add string resources for payout status
2023-09-05 09:53:58 -04:00
deeppandya 178298ca2d Add background resources for payout banner
Update UI in existing rewards panel
2023-09-05 09:53:55 -04:00
deeppandya 4f2af824a2 Update native fucnytion for payout status 2023-09-05 09:53:53 -04:00
Deep Pandya c7736b0e60 Merge pull request #19942 from brave/update_rewards_balance_format
Add locale specific number format for rewards balance
2023-09-05 09:39:41 -04:00
Darnell Andries 7c843b6630 Fix News daily and monthly usage metrics for Android 2023-09-01 23:10:26 -07:00
Pavneet Singh a870f8c6ac Allow multiple network selection (#19959)
* Implement multi network selector and resolve conflicts

* Remove selected network

* Rename type to mode

* Fetch assets of selected networks

* Formatting

* Show selected networks and add close option

* Update network selector button

* Implement empty asset state

* Fix NFT empty and loading state

* Update colors

* Add divider

* Fix ups

* Add strings and clean up

* Minor review changes
2023-09-01 09:44:52 -04:00
Darnell Andries 3144beb14f Add NFT gallery P3A metrics 2023-08-30 13:44:43 -07:00
deeppandya 93d28ced51 Remove debug values 2023-08-30 11:20:21 -04:00
deeppandya 7c7061dbf5 Add locale specific number format 2023-08-30 11:11:13 -04:00
Simone Arpe 26b5bbe666 Fix ANR when calling lifecycle observers (#19835) 2023-08-30 16:30:31 +02:00
Simone Arpe 17c9a12407 Fix crash in fetchPrices method (#19914) 2023-08-30 11:26:42 +02:00
Tapan Modh 906135bc25 Merge pull request #19791 from brave/redirect_custom_filter_settings_android
[Android] redirect users to new custom filter settings
2023-08-30 11:32:51 +05:30
Deep Pandya 4e721fb2fa Merge pull request #19930 from brave/app_links_settings_update
enable app links for all users
2023-08-29 23:10:26 -04:00
deeppandya c938282775 enable app links for all users 2023-08-29 19:59:54 -04:00
Pavel Beloborodov 33e16ff315 New speedreader tune dialog (#19715)
* New speedreader tune dialog
2023-08-29 20:57:06 +07:00
Deep Pandya a5a01d5995 Merge pull request #19884 from brave/request_otr_behinf_flag_android
Request otr behind flag android
2023-08-29 01:05:53 -04:00
Serg 71709a7ede Overrides show on DialogFragment to prevent a crash when Activity isn't there anymore 2023-08-28 13:08:05 -04:00
AlexeyBarabash 47701fe2a6 Revert "Enable split ABIs for bundle (#19592)" (#19891)
This reverts commit fdc9ad6bd5.
2023-08-26 15:47:45 +03:00
deeppandya 1f30237ac5 Keep request OTR feature behind the flag for android 2023-08-25 11:43:32 -04:00
deeppandya 66d39d788b Enable external app link by default 2023-08-25 01:41:18 -04:00
AlexeyBarabash fdc9ad6bd5 Enable split ABIs for bundle (#19592)
Enable split ABIs for bundle
Fixes brave/brave-browser#32468
2023-08-24 22:58:24 +03:00
Simone Arpe b060996654 Redesign Wallet navigation and merge assets and NFTs into single section (#19811) 2023-08-24 15:34:13 +02:00
Anton Paymyshev 103c1f3aa5 AccountId for transactions frontend (#19586) 2023-08-24 16:19:39 +07:00
Deep Pandya 4b85ad298e Merge pull request #19777 from brave/remove_griffin_dep_cookie_consent
Remove griffin dep cookie consent
2023-08-23 17:13:36 -04:00
deeppandya 25a0352bf8 Update brave privacy test
Resolve presubmit issue

Resolve privacy test
2023-08-23 15:49:48 -04:00
deeppandya c8d3ad32ef Update check to count site load for cookie consent dialog 2023-08-23 15:49:41 -04:00
deeppandya 759aa33129 Do not show seetings until filter list available 2023-08-23 15:49:38 -04:00
deeppandya 31555442f4 Remove griffin flag dependency 2023-08-23 15:49:35 -04:00
deeppandya 1da35d62da Add zebpay icons
Update copy to make with brand name
2023-08-22 23:09:24 -04:00
deeppandya 2fe188561e Add changes for zebpay in rewards 2023-08-22 23:09:17 -04:00
deeppandya aa9a65884f Add redirection for zebpay 2023-08-22 23:09:14 -04:00
Deep Pandya 686b50d1d3 Merge pull request #19774 from brave/resolve_otr_issue
Resolve otr issue
2023-08-21 15:56:57 -04:00