Commit Graph
10129 Commits
Author SHA1 Message Date
Jay Harris 27aa0ba0a0 Shortcuts Generation Followup (#17632) 2023-03-28 04:49:39 +02:00
Sangwoo Ko 1264837374 Address visual QA for vertical tabs (#17732)
### Group
- [x] Group name font should be bold and 13px

### Header
- [x] Update icons in header view(toggle button and search button)
- [x] toggle button in collapsed state is not aligned center
- [x] toggle button color should be match with icons on toolbar in dark mode -> white

### Tabs
- [x] Spacing around tabs is a little bit bigger (8px → 4px)
- [x] Tab's width should be 36px / when in group, 32px
- [x] Pinned tabs border radius should be 8px, while unpinned tabs has 4px radius.
- [x] Pinned tabs' borderline looks too thin
- [x] Pinned tabs' drop shadow looks clipped
- [x] Active tab's BG color is too strong when it's dark mode
- [x] Divider color in dark mode is not accurate

### New tab button
- [x] Spacing and color of new tab button should be matched to those of tabs (icon padding, title etc.)
- [x] NewTabButton's hover effect should have padding just like tabs
2023-03-28 06:35:26 +09:00
Nick von Pentz 916969fb49 Merge pull request #17778 from brave/nft-discovery-erc1155
Add ERC1155 support to NFT discovery
2023-03-27 13:24:33 -07:00
Simone Arpe 81a3f4cece Add NFT grid (#17738)
Implements new NFT tab in the Wallet section.
The layout will use an auto-resizing grid that adapts the number of columns depending on the width of the device screen.
The logic that handles the calculation of the span count is implemented in AutoFitVerticalGridLayoutManager.

The new layout follows the Figma design provided and will default to "All networks" when multichain support will be merged.
2023-03-27 19:27:29 +02:00
nvonpentz 4fb75c92de Add ERC1155 support to NFT discovery 2023-03-27 12:42:00 -04:00
Nick von Pentz f80728811f Merge pull request #17332 from brave/nft-discovery
NFT discovery using SimpleHash
2023-03-27 09:39:33 -07:00
Aleksey Khoroshilov 72c84f7942 Simplify service worker interaction and fix occasional failures. (#17724) 2023-03-27 09:37:54 -04:00
Aleksey Khoroshilov 389ca0b3e6 Merge pull request #17749 from brave/issues/29278
Ensure rewards service is active in ScriptInjectionWithPrecondition test.
2023-03-27 14:38:07 +07:00
deeppandya ca9a4d4269 Resolve presumit error
Resolve unit test around PlaylistChangeParams::Type

Remove unnecessary null check

Update year in license section
2023-03-26 15:25:30 +05:30
deeppandya 88356f755d Remove logs
Remove logs

Remove logs

Resolve presubmit checks

Address PR comments with refactoring

Remove notify events

Refactor code based on feedback
2023-03-26 15:25:12 +05:30
deeppandya a67363cf49 Remove room deps to avoid error
Update strings based on feedback

Ignore android manifest from kotlin module
2023-03-26 15:25:02 +05:30
deeppandya 8c5c604608 Add new strings for playlist
Update existing string for playlist
2023-03-26 15:24:59 +05:30
deeppandya ec3093959a Refactor prefernces
Update lint suppression patch

Update default playlist code
2023-03-26 15:24:38 +05:30
deeppandya 51062bf1c8 Add strings from kotlin module
Add patch for suppresing string warnings

Update default playlist code

Intial work for light mode UI
2023-03-26 15:24:35 +05:30
deeppandya d2aa9531f7 Update cache settings options 2023-03-26 15:24:25 +05:30
deeppandya be8c512789 Add playlist settings page 2023-03-26 15:24:05 +05:30
deeppandya 8a53da63e6 Add warning dialog
Update playlist item menu
2023-03-26 15:23:54 +05:30
deeppandya 1ee1bb3199 Update data for the flow from the brave activity page
Update playlist button behaviour
2023-03-26 15:23:37 +05:30
deeppandya a3bf836413 Add playlist menu 2023-03-26 15:23:35 +05:30
Cepera c1ea55bc33 Disable copy-clean-link-by-default for osx (#17752) 2023-03-25 13:26:05 +01:00
Cepera 97cb0dc137 Remove .app for default check on some OSes (#17743) 2023-03-25 01:37:04 +01:00
nvonpentz 4415b9a544 Support NFT discovery using SimpleHash
https://github.com/brave/brave-browser/wiki/NFT-Discovery
2023-03-24 15:13:06 -04:00
Aleksey Khoroshilov 74452b7977 Ensure rewards service is active in ScriptInjectionWithPrecondition test. 2023-03-24 22:29:33 +07:00
Sangwoo Ko 11d748264e Reduce redundant layout in VerticalTabStripRegionView (#17708)
VerticalTabStripRegionView::Layout() could be called multiple times.
Even when there's a damaged rect, the method could be called. This could
cause unnecessary layout and make hover card shaking. In order to prevent
that, check the last size and keep the dirty bit for layout.
2023-03-24 10:58:35 +09:00
Sangwoo Ko aa7f4c7d01 Set size of dragged browser properly (#17705)
Set size of dragged browser properly

As passed widget is vertical tab strip's widget, we should set size
with browser's widget.
2023-03-24 09:50:57 +09:00
Aleksey Khoroshilov 3d1567432a Fix test flakiness. 2023-03-23 15:06:26 +07:00
Nick von Pentz f3cf08cff3 Auto detect token standard when adding NFT assets (#17207)
* Add GetNftStandard to JsonRpcService

* Use JsonRpcService::GetNftStandard in BraveWalletService::AddUserAsset

* Complete support for ERC1155 tokens (add is_erc1155 property, etc)
2023-03-23 00:40:32 +01:00
Darnell Andries 07c054c1ea Merge pull request #17650 from brave/stats-p3a-process-reorder
Fix accidental reorder of service creation in browser process
2023-03-22 12:16:50 -07:00
cdesouza-chromium 49b964a9a7 Get rid of WebUIDataSource::Create() and WebUIDataSource::Add() (#17711)
This PR removes the uses of  `WebUIDataSource::Create/Add`, which are
set to get removed in `cr113`, and replaces it with the unique call
`CreateAndAdd()`.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/95ce39d5ebb5d59c4b96ac242652c6e5a08bd2f6

commit 95ce39d5ebb5d59c4b96ac242652c6e5a08bd2f6
Author: Lei Zhang <thestig@chromium.org>
Date:   Sat Mar 18 06:04:22 2023 +0000

    Get rid of WebUIDataSource::Create() and WebUIDataSource::Add()

    - Create() has been replaced by CreateAndAdd().
    - Replace the last Create() caller in WebUIDataSourceTest with a direct
      WebUIDataSourceImpl allocation.
    - Fold the 1 line Add() implementation into CreateAndAdd().
    - Implement TestWebUIDataSource::AddDataSourceForBrowserContext().
    - Update the last Add() caller, which is in a unit test, to use
      TestWebUIDataSource::AddDataSourceForBrowserContext().

    Bug: 1206140
2023-03-22 18:13:23 +00:00
Pavel Beloborodov 1fb3361fa5 brave.exe -> chrome.exe mimic. (#17671)
* brave.exe -> chrome.exe spoofing in sandboxed processes.
* Added 'ModuleFileNamePatch' (disabled by default) feature to brave://flags
2023-03-22 18:22:17 +01:00
Sangwoo Ko ef06b13d5a Split our implementation for TabDragController into separate file (#17704)
There's a lot of our implementation, so it'd better to split them into
separate file
2023-03-22 23:11:22 +09:00
Pavel Beloborodov bed3863b44 Race condition removed. (#17689) 2023-03-22 13:46:14 +01:00
Anirudha Bose f6cc8d7e94 Merge pull request #17667 from brave/f/wallet/infura-chains
Update preloaded networks and optimise network logos
2023-03-22 17:27:42 +05:30
Pavneet Singh f2dca61dee Feat show network name and icon (#17692)
* fix(wallet): update network icons

* feat: show network name and overlapping icon

* show overlapping network icon, name, and use list

* update token id for history

* add contract address check for ERC NFTs

* adjust overlapping network icon size
2023-03-22 10:06:17 +01:00
Sangwoo Ko 53f4048cdc Fix off-by-one-pixel in vertical tab strip (#17688)
* Fix off-by-one-pixel in vertical tab strip

* Don't set inset when it's fullscreen
* Don't make host view wider than it's desired
* Fix not to set 1px inset when it's not vertical tab or when it's fullscreen
* Fix browser test - As the container's width already contains the inset, we shouldn't add
1 in test.
2023-03-22 16:32:31 +09:00
Anirudha Bose 7d5f3fe056 chore(wallet): remove Celo from preloaded networks 2023-03-22 09:01:53 +05:30
Sangwoo Ko 506620da2a Expand BraveCompoundTabContainer to fill scroll view (#17690)
In order to make dragging tabs downward to reorder easier, expand the
compound container's height.
2023-03-22 02:52:56 +01:00
Sangwoo Ko 1233048592 Change tab context menu string for vertical tabs (#17687)
As vertical tabs are laid out vertically, "Below" is better than "Right"
2023-03-22 02:52:02 +01:00
Aleksey Khoroshilov 708de7a3b1 Merge pull request #16470 from brave/forget-by-default
Add support for first party storage removal on website close.
2023-03-21 21:52:34 +07:00
Anton Paymyshev c9adcc927b UnstoppableDomainsResolveDns to mojo (#17651) 2023-03-21 15:49:28 +07:00
Sangwoo Ko 6a10a780e0 Adjust icon's left position in floating mode (#17668)
In floating mode, we should adjust icon's left position so that favicons
doesn't move
2023-03-21 16:14:31 +09:00
Cepera 002f825555 Wrap clean link to a feature flag (#17673) 2023-03-21 08:06:45 +03:00
Mark Pilgrim 08f85c40c3 Don't overwrite Accept-Language header that was explicitly set by script (#17549)
* Don't overwrite Accept-Language header that was explicitly set by script

* add test
2023-03-20 23:54:58 +01:00
Sangwoo Ko b48329d190 Don't show close button in "minimal mode" when "float mode" is enabled (#17666)
When floating mode enabled, we don't show close button as the tab strip
will be expanded as soon as mouse hovers onto the tab.
2023-03-21 07:26:47 +09:00
Emerick Rogul a5630835ea Merge pull request #17617 from brave/emerick-rewards-remove-allow-contributions-for-videos
Remove setting to allow contributions for videos
2023-03-20 17:47:39 -04:00
Sangwoo Ko c636801630 Make more tests for vertical tabs (#17579)
We've been missing some tests for regressions, that could easily happen
2023-03-20 15:17:44 +01:00
Aleksey Khoroshilov 48aadd6f75 Add few comments, rename pref to better reflect the actual content. 2023-03-20 13:32:42 +07:00
Aleksey Khoroshilov cdc9b5b7d7 Add tests, fix few issues. 2023-03-20 13:32:42 +07:00
Aleksey Khoroshilov ab7cf43262 Add support for first party storage removal on website close. 2023-03-20 13:32:42 +07:00
Jocelyn Liu 67ce133626 Fix connecting Brave Wallet to snapshot.org (#17658)
Make window.ethereum a proxy object

It uses a handler that would call things directly on the actual
JSEthereumProvider object so dApps which creates and uses their own proxy of
window.ethereum to access our provider won't throw a "Illegal invocation:
Function must be called on an object of type JSEthereumProvider" error.
2023-03-19 20:26:40 -04:00