github autogenerated a file that was invalid because of our branch-matching regex. this manually fixes it.
also skips the run for c++/java because codeql doesn't know how to build
those
fix https://github.com/brave/brave-browser/issues/13431
Resolves https://github.com/brave/brave-browser/issues/12691
The idea is to clean up the checklist and leave only relevant
and important entries. Also populate the reviewers section with
frequently overlooked issues.
As referrals service uses new prefs(kReferralInitialization) for
checking its initialization, NTP services should check this status
together with old prefs(kReferralCheckedForPromoCodeFile).
To detect the referrals service changes in the future, added me to
OWNERS file.
These mandatory reviews are no longer necessary since the LICENSE
file is now automatically generated and missing licensing info
will cause a build failure.
NTPSponsoredImagesService registers proper components based on
locale and will notify to its observers whenever components is updated.
NTPSponsoredImageSource serves branded images.
With this, we can fix brave theme related bugs with multi profile
because all profiles use browser-wide prefs.
So far, system theme could be changed whenever new profile is used
because brave theme was profile prefs but system theme is browser
wide setting. And did cleanup and refactoring.
Refactoring point is separation of theme managing and dark mode managing.
So far, theme service has all dark mode handling logic.
But I think theme service handles browser theme with underrlying dark mode.
So, all dark mode logic is in dark_mode namespace.
fix https://github.com/brave/brave-browser/issues/5373
fix https://github.com/brave/brave-browser/issues/5557
Install prompt is displayed if widevine is opt opted in by user and user
doesn't choose don't ask option of it.
Widevine cdm lib is loaded into cdm utility process after it installed.
And it is browser widely used not just for specific profile.
However, Brave has prompted widevine permission prompt when user loads
contents site(ex, netflix) in newly created profile.
If Widevine cdm lib is already installed by any profile, Brave should not
display it again because cdm lib is already used.
To fix this, two kWidevineOptedIn/kWidevineInstalledVersion are migrated
from profile prefs to local state.
When migration is needed, firstly active profile is used to get existing
pref values.
There is one more Widevine related pref. It's kAskWidevineInstall.
It would be good to migrate to local prefs also. but left as-is in profile
prefs also seems fine. After Widevine is installed that prefs doesn't have
much meaning and if not just click once to dont ask is sufficient. Also, it
is convinient to implement settings option with profile prefs.
Anthony Tseng