Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/00bfce0c7635650f36baa1b335aa17c72cde1e70
Fix a bug Chrome is showing 2 rows of most visited tiles when query tiles are enabled
On small screen device, only 1 row of most visited tile should show when
query tiles are enabled.
However, TileSection hard coded the number of rows to 2. So even though
Chrome reduced most visited tiles to 4, it could still end up showing in
2 rows if the screen can only accommodate 3 tiles in a row.
BUG=1166388
(cherry picked from commit e97d0ce51b15cdb72da9a0ae67d9ceac1d08f646)
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/2336b6557478c544a81650258aab4b0e7af49c78
commit 2336b6557478c544a81650258aab4b0e7af49c78
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Mon Jan 11 01:13:17 2021 +0000
Toolbar: Move BottomControls to modularized target
This CL moves the classes for BottomControls MVC component plus
its layout xml to chrome/browser/ui/android/toolbar/.
Following dependencies on chrome_java were removed:
- ShareDelegate - was not in use.
- TabGroupUi - split to BottomControlsContentDelegate and extend
from it.
Bug: 1127732
Chromium change:
https://chromium.googlesource.com/chromium/src/+/88757c64b874d89657ba1e2a4c53120d17fc84ff
Toolbar: HomeButton without HomepageManager dependency
Made HomeButton work without dependency on chrome.browser.homepage
classes. All the deps are now deferred to ToolbarManager.
The dependencies are injected not through ctor but init method
introduced in this CL since the home button and the enclosing view
(ToolbarLayout) are instantiated from xml.
Menu handling logic was moved to HomepageManager to make it test-
friendly.
Also removed a bunch of dead code in HomeButton. Several public setters
(ActivityTabObserver, ThemeColorProvider, StartSurfaceSupplier) were
used by BrowsingModeBottomToolbarCoordinator only (see
https://crrev.com/c/1981099). There's no callsite left any more as
the class was already gone.
Bug: 1127732
Chromium change:
https://chromium.googlesource.com/chromium/src/+/88757c64b874d89657ba1e2a4c53120d17fc84ff
Toolbar: HomeButton without HomepageManager dependency
Made HomeButton work without dependency on chrome.browser.homepage
classes. All the deps are now deferred to ToolbarManager.
The dependencies are injected not through ctor but init method
introduced in this CL since the home button and the enclosing view
(ToolbarLayout) are instantiated from xml.
Menu handling logic was moved to HomepageManager to make it test-
friendly.
Also removed a bunch of dead code in HomeButton. Several public setters
(ActivityTabObserver, ThemeColorProvider, StartSurfaceSupplier) were
used by BrowsingModeBottomToolbarCoordinator only (see
https://crrev.com/c/1981099). There's no callsite left any more as
the class was already gone.
Bug: 1127732
Chromium change:
https://chromium.googlesource.com/chromium/src/+/8098bca24a5d3610403552256d0e8bc4c9610429
Remove HelpAndFeedback.
The plan for this two-sided patch is:
1) Add the new class under feedback/ and AppHooks method upstream with
no reference.
2) Extend the new class downstream and add the new AppHooks method.
3) Update upstream references to point to the new AppHooks method.
4) Cleanup in downstream repository.
5) Cleanup in upstream repository.
1) was done in https://crrev.com/c/2364581.
2) was done in https://crrev.com/i/3227761.
3) was done in https://crrev.com/c/2414779.
4) was done in https://crrev.com/i/3274398.
5) is done in this CL.
Note that the change in SigninUtils was a miss from step 3). Ideally
all references to HelpAndFeedback should be removed in 3), but there is
one left in SigninUtils. The consequence is that after step 4) is landed,
this reference can only be pointed to the upstream implementation.
Bug: 1117343
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/e274ab4bfbb68201b4c2cf36e8b7c0cf29981c17
commit e274ab4bfbb68201b4c2cf36e8b7c0cf29981c17
Author: Dan Harrington <harringtond@chromium.org>
Date: Wed Sep 30 19:06:12 2020 +0000
Add enable_feed_v1 compile flag
And restructure feed code so that we can use it.
This flag pulls Feed v1 out of the build.
It's a bit different that enable_feed_v2. enable_feed_v2
retains most of the v2 code in chromium -- only the internal
code is actually removed when enable_feed_v2 is off.
If both flags are ON (the default), we use the InterestFeedV2
feature to select which version to use. To facilitate this,
only feed_feature_list.cc and FeedFeatures.java should inspect
the state of this feature directly.
If both build flags are OFF, we use the V2 UI classes as
essentially a pass-through to a recycler view, but will
not request any Feed content.
The compile flag enable_feed_in_chrome was removed.
Other changes:
* I've moved some files around to make it more clear what code
is for v1 only.
* I've added FeedV1 and FeedV2 java classes to wrap access to
version specific things, so that FeedV1 can be removed using
the compile flag.
Bug: 1129187
Chromium change:
https://chromium.googlesource.com/chromium/src/+/7561e2f936dbd8563840ee776a7dcb036515373c
Create a basic TileView MVC component.
This change introduces a set of classes and properties enabling the
TileView to become a MVC component.
The change collapses the TileView and TileWithTextView classes into
one to avoid awkward naming. The TileView base class is never used as
a stand-alone component and MVC allows the class to control the
visibility of the TextView with ease.
The MVC component features all UI specific features used by TileView,
TileWithTextView, SuggestionsTileView and TopSitesTileView.
Bug: 1106109
Alex C