Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/afd16b5973b054f53733695ce33708ef430a0b83
Toolbar: Remove deps on TrackerFactory
Removes deps on TrackerFactory in ToolbarTabControllerImpl and
move it to the modularized toolbar/. There are a few more classes
that can also be moved:
ToolbarTabControllerImplTest.java
ToolbarTabControllerImpl.java
top/IncognitoSwitchCoordinator.java
top/IncognitoSwitchProperties.java
top/IncognitoSwitchViewBinder.java
top/TabSwitcherActionMenuCoordinator.java
top/TabSwitcherActionMenuRenderTest.java
Bug: 1127732
Fixes this lint error:
../../chrome/android/java/res/layout/brave_sync_done.xml:85: Error: Must use app:tint instead of android:tint [UseAppTint]
android:tint="@android:color/black" />
Fixes these java warnings:
../../brave/android/java/org/chromium/chrome/browser/custom_layout/popup_window_tooltip/PopupWindowTooltip.java:66: warning: [NoRedundantFieldInit] Do not explicitly initialize a non-final field with a default value
private boolean dismissed = false;
^
(see https://issuetracker.google.com/issues/37124982)
Did you mean 'private boolean dismissed;'?
../../brave/android/java/org/chromium/chrome/browser/custom_layout/popup_window_tooltip/PopupWindowTooltip.java:302: warning: [MultiVariableDeclaration] Variable declarations should declare only one variable
float x, y;
^
(see https://google.github.io/styleguide/javaguide.html#s4.8.2.1-variables-per-declaration)
Did you mean 'float x;float y;'?
../../brave/android/java/org/chromium/chrome/browser/custom_layout/popup_window_tooltip/PopupWindowTooltip.java:370: warning: [NoRedundantFieldInit] Do not explicitly initialize a non-final field with a default value
private boolean modal = false;
^
(see https://issuetracker.google.com/issues/37124982)
Did you mean 'private boolean modal;'?
../../brave/android/java/org/chromium/chrome/browser/custom_layout/popup_window_tooltip/ArrowColorDrawable.java:21: warning: [MultiVariableDeclaration] Variable declarations should declare only one variable
public static final int LEFT = 0, TOP = 1, RIGHT = 2, BOTTOM = 3, AUTO = 4;
^
(see https://google.github.io/styleguide/javaguide.html#s4.8.2.1-variables-per-declaration)
Did you mean 'public static final int LEFT = 0;public static final int TOP = 1;public static final int RIGHT = 2;public static final int BOTTOM = 3;public static final int AUTO = 4;'?
../../brave/android/java/org/chromium/chrome/browser/custom_layout/popup_window_tooltip/ArrowColorDrawable.java:85: warning: [MissingOverride] setColor overrides method in ColorDrawable; expected @Override
public void setColor(@ColorInt int color) {
^
(see https://errorprone.info/bugpattern/MissingOverride)
Did you mean '@Override public void setColor(@ColorInt int color) {'?
samartnik