Commit Graph
6 Commits
Author SHA1 Message Date
mkarolin 781b95bb3a Lint fixes. 2021-02-04 23:52:43 -05:00
mkarolin ba721f1c35 DevToolsUIBindings DispatchCallback -> OnceCallback.
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/bd25816fff5e8c0f27a2f84667fa0b2eb42f02c4

commit bd25816fff5e8c0f27a2f84667fa0b2eb42f02c4
Author: Leonard Grey <lgrey@chromium.org>
Date:   Fri Jan 8 19:10:32 2021 +0000

    [Code health] Convert DispatchCallback to OnceCallback

    Bug: 1152274
2021-02-04 23:52:26 -05:00
mkarolin 35e73f73f7 [Browser Tests] IWYU browser_test.h.
Chromium change:

https://chromium.googlesource.com/chromium/src/+/919ce657e4e37dfa13758f1eb8fe0e9ef7ab1b20

commit 919ce657e4e37dfa13758f1eb8fe0e9ef7ab1b20
Author: Peter Kasting <pkasting@chromium.org>
Date:   Thu May 7 10:22:36 2020 +0000

    Add missing #includes of browser_test.h.

    This is a step towards doing full IWYU of browser_test.h, which will
    have other benefits.

    Completely mechanical and already R+ed as part of r765923.

    Bug: none
2020-07-01 18:12:03 -04:00
Simon Hong 24cf9d8f0c Migrate brave theme prefs from profile to local state
With this, we can fix brave theme related bugs with multi profile
because all profiles use browser-wide prefs.
So far, system theme could be changed whenever new profile is used
because brave theme was profile prefs but system theme is browser
wide setting. And did cleanup and refactoring.

Refactoring point is separation of theme managing and dark mode managing.
So far, theme service has all dark mode handling logic.
But I think theme service handles browser theme with underrlying dark mode.
So, all dark mode logic is in dark_mode namespace.

fix https://github.com/brave/brave-browser/issues/5373
fix https://github.com/brave/brave-browser/issues/5557
2019-12-19 07:47:27 +09:00
Simon Hong 7a2b64d873 Fix brave_devtools_ui_bindings.obj link error on Windows Release
When devtools_ui_bindings target is built, BraveDevToolsUIBindings
added more dependencies that are not included in chrome_child.dll.
To fix this, //brave/browser/devtools target is separated from
//chrome/browser/devtools and it is added in the deps list of
//brave/browser/ui targets because it is only used from it.
2018-11-24 00:07:36 +09:00
Simon Hong f0bd657140 Consider brave theme type to devtools' theme
When devtool ui is loaded, kDevToolsPreferences pref values are fetched.
In that dictionary prefs, uiTheme represents theme type(light/dark) of devtool.
To apply brave theme type to devtools, uiTheme value is replaced with brave
native theme type. If user sets devtools' theme type explicitely, that value
is used instead of brave theme type. Otherwise, brave theme type is applied.
2018-11-12 23:42:41 +09:00