Chromium change:
https://source.chromium.org/chromium/chromium/src/+/20a41c8b03a9ab035619e225520dfec484fb3e69
commit 20a41c8b03a9ab035619e225520dfec484fb3e69
Author: Glen Robertson <glenrob@chromium.org>
Date: Tue Jan 19 08:20:35 2021 +0000
Separate profile.{cc,h} (& observer) to its own GN target.
This allows other code to depend on profile.h (very common as it is a
keyed service key) without depending on all of //c/b:browser. This
improves modularization of the codebase and will help to break
dependency cycles in GN.
Bug: 1149277
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/db01f8a5783095aee1de20925fb8cc4d67f6c485
commit db01f8a5783095aee1de20925fb8cc4d67f6c485
Author: Anthony Cui <cuianthony@google.com>
Date: Thu Feb 18 21:45:18 2021 +0000
Refactor unknown source language option and add support to Android
This change
- Refactors the implementation of the Unknown source language option,
adding it at the TranslateUIDelegate level and treating it like other
language options
- Renames the "Unknown" option to "Detected Language" for a more
functional description
- Adds support for use of the new "Detected Language" source language
option on Android
- Adds both the string change and the Android support changes behind a
new feature flag
Bug: 1127094
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/1b46c0a5122001153c56824f024a68ba56e5d1f9
commit 1b46c0a5122001153c56824f024a68ba56e5d1f9
Author: Keishi Hattori <keishi@chromium.org>
Date: Mon Feb 22 22:02:34 2021 +0000
Fix BrowserNavigatorTest.SwitchToTabIncognitoLeak for BackupRefPtr
BrowserNavigatorTest.SwitchToTabIncognitoLeak fails when BackupRefPtr is used because it reads NavigateParams:: rowser after it has been moved.
Unlike raw pointer, BackupRefPtr will be cleared when moved.
This CL changes ShowSingletonTabOverwritingNTP() to take a pointer so Navigate() doesn't have to move NavigateP rams.
Adapt Brave-specific code and overrides to use this equivalent struct.
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/a696151783d69bc6e8884246418d771d06cd9f53
commit a696151783d69bc6e8884246418d771d06cd9f53
Author: dpapad <dpapad@chromium.org>
Date: Tue Feb 16 12:34:08 2021 +0000
WebuI: Delete GritResourceMap struct in favor of webui::ResourcePath.
- Move webui::ResourcePath definition to its own file in
ui/base/webui/.
- Modify Grit to use webui::ResourcePath, and delete the identical
GritResourceMap struct.
- Remove the AddResourcePathsBulk() override that used GritResourceMap.
This is in preparation of moving AddResourcePathsBulk to WebUIDataSource
itself.
Bug: 1176299
This method has been removed from upstream as it was not used and there
does not seem to be an equivalent one available, so let's bring it back.
Fixup! Mario says: on a second thought I think this is probably not
needed so reverting this change (and simply dropping the
CloseGuestProfileWindows() call from
BraveProfileMenuView::OnExitProfileButtonClicked().
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/53d0699ee2609b7195a93d92d2433500a0affd55
commit 53d0699ee2609b7195a93d92d2433500a0affd55
Author: Monica Basta <msalama@chromium.org>
Date: Wed Feb 10 11:57:07 2021 +0000
[Profiles]: Avoid opening the profile picker on close 'x' windows
Currently on click on 'Close x windows' from the profile menu, the
profile is closed and the user manager/profile picker is opened. This
behavior is no longer desired. Clicking on the button should only close
the profile. This CL also removes 'CloseGuestProfileWindows' function
that is not used.
Bug: 1176599
ProfileAttributesStorage::GetProfileAttributesWithPath() now returns
a ProfileAttributesEntry value (or nullptr), instead of accepting an
out parameter.
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/32c25e13fbddcc93012edf83e7a340e66608f372
commit 32c25e13fbddcc93012edf83e7a340e66608f372
Author: Alex Ilin <alexilin@chromium.org>
Date: Wed Feb 3 16:24:37 2021 +0000
[profiles] Refactor GetProfileAttributesWithPath method
ProfileAttributesStorage::GetProfileAttributesWithPath() used an output
parameter + boolean return value for returning ProfileAttributesEntry*.
This CL replaces this API with simply returning ProfileAttributesEntry*
from the method. In case of failure, the method returns a nullptr.
Return values are preferred over output parameters: they improve
readability, and ofter provide the same or better performance [1].
[1] https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs
Change-Id: I6aa6c01af8660ac0b013407237360c8ed7f9a176
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/afd16b5973b054f53733695ce33708ef430a0b83
Toolbar: Remove deps on TrackerFactory
Removes deps on TrackerFactory in ToolbarTabControllerImpl and
move it to the modularized toolbar/. There are a few more classes
that can also be moved:
ToolbarTabControllerImplTest.java
ToolbarTabControllerImpl.java
top/IncognitoSwitchCoordinator.java
top/IncognitoSwitchProperties.java
top/IncognitoSwitchViewBinder.java
top/TabSwitcherActionMenuCoordinator.java
top/TabSwitcherActionMenuRenderTest.java
Bug: 1127732
zenparsing