If the BrowserGuestModeEnabled policy is set to false, do not include
a menu item for the guest mode window.
Tests by Jocelyn Liu <yrliou@gmail.com>.
Fixesbrave/brave-browser#12524
be null when --disable-sync specified
Also remove redundant `--disable-brave-sync` switch because brave sync relies
on chromium sync, it won't work properly with chromium sync disabled.
Insert & reorder brave menus based on corresponding commands enable status.
If we want to add/remove from app menu, adjust enable commands status
instead of adjusting it in app menu model directly.
App menu model will add/delete based on commands status.
Fix https://github.com/brave/brave-browser/issues/5552
Browsr commands will be updated after changing tor option.
If user turns it off, tor component will be removed at the next
launching. If there is already opened tor window, it can be used.
But, user can't create new tor window anymore.
* Fix trivial var naming and refactoring
* Delete un-related header including
* Add BraveTorClientUpdater::Cleanup() instead of deleting tor extension
directly from BraveExtensionManagement.
New window, New private window, New private window with Tor are shown in the
hamburger and file menu, and users could use them to open any type of new
window in Tor window.
BraveBrowserCommandController::ExecuteCommandWithDisposition.
Chromium change:
commit 6f6fc1e333f968d4caddb52f11b6ff9f3ef1c0f9
Author: Edwin Joe <ejoe@google.com>
Date: Wed Feb 27 20:00:37 2019 +0000
Added a new UMA to track tab switching latency time
Created a new TabSwitchEventLatencyRecorder class that will track
the latency between input event timestamp and the time when tab
switching begin processing, and upload the metric to a UMA.
Changed the TabStripModel::ActivateTabAt method interface to take
enough input event context from the Tab to the TabStripModel,
and changed all TabStripModel::ActivateTabAt callsites accordingly.
Bug: 921120
Sync & Rewards pages are only valid in normal window. And they are also
valid in private window because they are redirected to normal window.
However, they doesn't work properly in tor(guest) window. So, sync and
rewards items are should be visible only normal and private window's app
menu. Also, corresponding commands should be disabled in tor(guest) window.
fixed broken build in the branch
can update bookmarks in a sync cloud
intermediate commit 8
WIP, moving js lib to extension
move js lib to extension background page; BrowserToBackgroundPage calls
move js lib to extension background page; extension is packed
move js lib to extension background page; sync client class
move js lib to extension background page; modifying background.js
fixes after Chromium 69 rebase
fixed var keyword
reorganizing dirs
reorganizing file names
fixed classes naming
another forgotten class naming fix
don't copy resources inside src
auditors @AlexeyBarabash
fix brave_sync background page resource loading
move js lib to extension background page; strict calls schema; move brave sync api from browser to components
brave-sync and brave-crypto are built from DEPS hooks now
fixed chrome.braveSync api load
rebased patch for cr70
fixing issues after rebase to cr70
workaround for issue of binary type of json schema modified from vector<char> to vector<unsigned char> at cr69=>cr70
fixes sync-ui webpack for rebase
fixed after rebase
sync classes are per-profile now
WIP for sync history
fixes after rebase
fix after rebase
some history stuff
file work is in correct thread now; removed mutex
fix for threading during bookmarks creation
fixed threading for reset sync
fixed build after rebase
fixed missing break after rebase
initialization of bookmarks base order
can send bookmark order
storage of objects map is now typed for local id
fix for object map not existing local ids
fixed GetLocalIdByObjectId
fixes for bookmarks folders
fix for permanent folders order
switched passphrase encoding to bip39 from niceware
save order when bookmark is added
fix for add bookmark from sync situation
fixed assigning bookmark order after device just connected to chain
can delete bookmark by event from sync
wip update bookmark by event from sync
test for bookmark order utils
avoid double initialize request
object_map depends on profile path, not on whole profile
backend for ui set sync this device,bookmarks,history,settings
simple ui does set sync this device,bookmarks,history,settings
fix https://github.com/brave/brave-browser/issues/1387
- Main hamburger menu in non-Tor windows:
New private window with Tor
- Context menu for right-click on links:
Open link in private window with Tor
This pushes IsTorProfile() into BrowserContext where it now resides
alongside IsOffTheRecord(), since we need it in order to determine
whether the 'Open link in private window with Tor' item should be
greyed out or not. (Is this a little silly? Maybe, but it's what the
browser already does with 'Open link in incognito window' item.)
Test plan:
1. 1. Open a fresh browser instance.
2. Confirm that hamburger -> 'New private window with Tor' (NPWWT)
opens a private window with Tor.
3. In the _Tor_ window, open <https://check.torproject.org/>.
4. Confirm that you are using Tor.
5. Right-click any link on the page.
6. Confirm that items to open in a private window, with or without
Tor, are greyed out.
7. Confirm that in the _normal_ window's hamburger, NPWWT switches
to the private window with Tor it just opened.
8. Confirm that in the _Tor_ window's hamburger, 'New window' opens
a new private window with Tor.
9. Confirm that in the _Tor_ window's hamburger, there is no NPWWT.
3. 1. Open a fresh browser instance.
2. In a _normal_ window, open <https://www.example.com/>.
3. Right-click the 'More information...' link.
4. Select 'Open link in private window with Tor'.
5. Confirm that the link opens in a Tor window.
6. In the normal window, do it again.
7. Confirm that the link opens in a new tab in the existing Tor
window.
TODO: Rename IsTorProfile to make more sense for BrowserContext.
Brian R. Bondy