Function in web_ui_util.cc is no longer used to get the
text_defaults_md.css resource for shared resources. Keep our override
for the function resouce because it's still used in several places.
Additionally, copy over our text_defaults_md.css via util.js so that
it's used when chromium GRD is auto generated.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/ba11d6dc4a110c2c456eb453b445832847230b5e
commit ba11d6dc4a110c2c456eb453b445832847230b5e
Author: dpapad <dpapad@chromium.org>
Date: Wed Feb 24 18:26:57 2021 +0000
WebUI: Replace SharedResourcesDataSource with a regular WebUIDataSource.
SharedResourcesDataSource was a custom class directly subclassing
URLDataSource (and used for serving chrome://resources URLs). By doing
so it included a lot of duplicated functionality for code that is
already available in regular WebUIDataSourceImpl subclasses, for
example
- Registering resources
- Registering loadTimeData strings
- Calculating mime types based on a path's extension
- Locating and serving WebUI files from pak files
- Overriding specific CSP policies
By using a regular WebUIDataSourceImpl a lot of duplicated code is
deleted. Moreover, WebUIDataSourceImpl is a more mature class, that is
heavily used across WebUI. For example this CL helped discover a bug
where $i18n{...} string placeholders where incorrectly used in
cr_components/ (fixed at r854879) because of CHECK()s that did not
exist in SharedResourcesDataSource.
In order to support chrome://resources/css/text_defaults.css $i18n{...}
replacements, web_ui_url_loader_factory.cc has been modified to perform
$i18n{...} replacements in CSS files too (previously only done for HTML
files, and conditionally for JS files).
Bug: 1179207
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/f3add8f687acb2ddff2d0c567cfa768a0f9b3bbd
Remove Feedv1 code
Much of this code was already compiled-out. Some exceptions:
- Code branches with if (v1 enabled) { ... } were removed.
- Extracted functions from v1 library LocateUtils class into
FeedServiceBridge.
- Some code in components/feed wasn't yet removed from
the build, but wasn't referenced, and is now removed.
- Shared proto databases for v1 were added to
kObsoleteSharedProtoDbTypeClients
- Obsoleted v1 specific prefs.
Bug: 1165828
The GN target we were patching before has been split into different ones
and we now need to move this patch to components/sync/engine/BUILD.gn.
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/2275afee7febb3e7e40207d2e05b7ed1b68d9d78
commit 2275afee7febb3e7e40207d2e05b7ed1b68d9d78
Author: Victor Hugo Vianna Silva <victorvianna@google.com>
Date: Mon Feb 8 15:02:16 2021 +0000
[sync] Split rest_of_sync build target into engine, model and nigori
This CL builds on the work of crrev.com/c/{2652625,2659120} to finally
split the rest_of_sync build target into smaller per-directory ones. A
few changes worth noting:
- Clean up some duplicates/self-deps entries in DEPS files, accidentally
introduced in crrev.com/c/2659120.
- Add one TODO about moving entity_data.h out of engine/, which should
have been added in crrev.com/c/2652625.
- Avoid one model/ include in base:test_support by moving the file with
the include to the test_support_model target.
- Remove unused dependencies //sql, //third_party/crc32c and //ui/base.
- Move from private to public dependency:
* //components/signin/public/identity_manager (AccountInfo used in
SyncEngine public API).
* //services/network/public/cpp (used in HttpBridge & SyncManagerImpl
public APIs).
- Keep the precompiled_headers build config only for targets with >50
.cc files [1]. This means adding it to engine/ and removing it from
base/, driver/ and protocol/.
[1] https://source.chromium.org/chromium/chromium/src/+/3abc98c09a9174a91f82e6f2eccf0ebb6c203fdf:build/config/BUILD.gn;l=375TBR=sky@chromium.org
Bug: 947443
Added redirect-cc.exe that serves the same function as redirect-cc.cmd
(calls python with redirect-cc.py script), but doesn't suffer from the
"command line is too long" errors.
Removed patches that were trying to get around command line length by
writing MS includes into a file and then reading from it.
Removed redirect-cc.cmd and code to copy it to out directory.
Added redirect-cc.exe binary, source code (sln + vcxproj).
Replaced cc-wrapper config with path to the exe binary.
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/afd16b5973b054f53733695ce33708ef430a0b83
Toolbar: Remove deps on TrackerFactory
Removes deps on TrackerFactory in ToolbarTabControllerImpl and
move it to the modularized toolbar/. There are a few more classes
that can also be moved:
ToolbarTabControllerImplTest.java
ToolbarTabControllerImpl.java
top/IncognitoSwitchCoordinator.java
top/IncognitoSwitchProperties.java
top/IncognitoSwitchViewBinder.java
top/TabSwitcherActionMenuCoordinator.java
top/TabSwitcherActionMenuRenderTest.java
Bug: 1127732
Because brave_strings.grd and settings_brave_strings.grdp are special
cases in terms of naming, the rebase script wasn't adding the GRDP
override to the GRD override.
Addresses brave/brave-browser#14750
Doesn't fix the actual translations, but we should get them the next
time we order.
It will assumed from now on that all of Brave's own code plus patches
to upstream Chromium will always be built and run as part of a Brave
build, so we can drop these guards and reduce the patching surface.
Note that github.com/brave/brave-browser/wiki/Patching-Chromium should
also be updated to reflect the change implemented in this patch.
Fix https://github.com/brave/brave-browser/issues/12740
Emerick Rogul