Commit Graph
146 Commits
Author SHA1 Message Date
Alex C a96db76e69 [Android] Fixes unresponsive close button from Site Settings options 2021-03-26 18:16:22 -04:00
samartnik 01a39dba3e [Android] Fixes Tab Groups controls behaviour on tab closing 2021-03-19 17:18:11 -04:00
samartnik 45fedd4e16 [Android] Reconciles Tab Group feature with bottom toolbar 2021-03-11 16:26:33 -05:00
samartnik 7ca49a75a4 [Android] Changes for disabling safe browsing extended reporting 2021-03-10 10:14:31 -05:00
Deep e719c5eec1 Address PR comments 2021-03-09 12:51:34 -05:00
Deep 9e6a7b7a78 Remove safe browsing help option 2021-03-09 01:07:48 -05:00
samartnik 0e49519585 [Android] Fixes crash on closing tabs with Tab Groups 2021-03-05 08:08:31 -05:00
AlexeyBarabash 3d87335c99 Fix asm patching for BraveCommandLineInitUtil
fixes brave/brave-browser#14288
2021-02-23 00:23:20 +02:00
samartnik 010da2f267 [Android] Fixed menu icons for overview mode 2021-02-18 21:19:57 -05:00
samartnik 49e7fce600 [Android] Removed check passwords preference 2021-02-17 10:43:13 -05:00
samartnik ade938be82 [Android] Moved patches for ToolbarPhone to bytecode 2021-02-12 18:08:28 -05:00
Deep b24f17479f Remove unused code 2021-02-08 10:09:23 -05:00
Deep 13ba7fa2d3 Update bookmark behaviour 2021-02-08 08:54:28 -05:00
samartnik ff468b64a6 [Android] getMaxRowsForMostVisitedTiles was moved
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/00bfce0c7635650f36baa1b335aa17c72cde1e70

Fix a bug Chrome is showing 2 rows of most visited tiles when query tiles are enabled

On small screen device, only 1 row of most visited tile should show when
query tiles are enabled.
However, TileSection hard coded the number of rows to 2. So even though
Chrome reduced most visited tiles to 4, it could still end up showing in
2 rows if the screen can only accommodate 3 tiles in a row.

BUG=1166388

(cherry picked from commit e97d0ce51b15cdb72da9a0ae67d9ceac1d08f646)
2021-02-04 23:52:52 -05:00
mkarolin d3f9f6b9be GN formatting fixes. 2021-02-04 23:52:46 -05:00
samartnik 3476ac29ba [Android] Fixes for java warnings II 2021-02-04 23:52:42 -05:00
samartnik ca2dccb837 [Android] BottomControls were modularized
Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/2336b6557478c544a81650258aab4b0e7af49c78

commit 2336b6557478c544a81650258aab4b0e7af49c78
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date:   Mon Jan 11 01:13:17 2021 +0000

Toolbar: Move BottomControls to modularized target

This CL moves the classes for BottomControls MVC component plus
its layout xml to chrome/browser/ui/android/toolbar/.

Following dependencies on chrome_java were removed:

- ShareDelegate - was not in use.
- TabGroupUi - split to BottomControlsContentDelegate and extend
               from it.

Bug: 1127732
2021-02-04 23:52:41 -05:00
samartnik 86cb3176e1 [Android] ThemeColorProvider replaces TabThemeColorProvider
Chromium change:
https://chromium.googlesource.com/chromium/src/+/eafd059d9f7f4656f7110349fa9ffd221dfae93c

Toolbar: TopUiThemeColorProvider

A ThemeColorProvider for top UI (TopUiThemeColorProvider)
replaces TabThemeColorProvider, and gets moved to a modularized
target chrome/browser/ui/android/theme. This is a new source of
truth for toolbar/top part of Chrome UI theme color.

Previously TabThemeColorHelper played the role, but now it was
redefined to provide the theme color coming from tab
contents only. TopUiThemeColorProvider puts together all
the signals and decides the final theme color to be used for
top UI.

Bug: 1127732
2021-02-04 23:52:23 -05:00
AlexeyBarabash 060c9ceb8b Remove override of AndroidSyncSettings.isSyncEnabled from BraveAndroidSyncSettings
fixes brave-browser#13512

Chromium change:
https://chromium.googlesource.com/chromium/src/+/12166216f9de6248ae936722a3fac423349eb1e1

Make AndroidSyncSettings.isSyncEnabled() internal to SyncController

This method was one of the big villains of AndroidSyncSettings, because
it was easy to use it instead of some ProfileSyncService API. This CL
makes it internal to SyncController, avoiding new uses. A warning is
added to isChromeSyncEnabled() to prevent developers from thinking the
method has just been renamed. Extra care is taken not to weaken the
tests in AndroidSyncSettingsTest, replacing expectations on this method
accordingly.

Bug: 1107904
2021-02-04 23:52:22 -05:00
samartnik ec86e1bc70 [Android] Modularized LayoutManager interface was applied
Chromium change:
https://chromium.googlesource.com/chromium/src/+/c9e84c85453ea4286cc07c9702ab7d01bbcfe0f7
Reland "Toolbar: Apply modularized LayoutManager interface"

Relands the CL after fixing the build error. A new junit test
should have been a part of chrome_junit_tests suite, not a
separate binary.

This reverts commit 09d519a315f43ee0f176d831e93d1698ee6e4421.

TBR=yfriedman@chromium.org,fgorski@chromium.org,pnoland@chromium.org,mdjones@chromium.org

Bug: 1127732
2021-02-04 23:52:19 -05:00
samartnik cb40cfaa3d [Android] Material design exclusions were removed
Chromium change:
https://chromium.googlesource.com/chromium/src/+/9702e4fdd42dbc7927f094a56e0c49109860dff3

Remove material design exclusions

Exclusion of these material resources prevents the HaTS Next AAR from
compiling so re-including them now. Some of these resources are already
included downstream, so the real expected binary size impact is ~32K.

Binary-Size: Size increase is unavoidable (see above).
Bug: 1151370
2021-02-04 23:52:13 -05:00
Mihai PLESA 1fbda558c2 revert typo fix 2021-01-14 14:14:35 +00:00
Mihai PLESA aed168befc switch from arm64 only to universal (#7581)
* switch from arm64 only to universal

* script path fix

* fixed dependency cycle

* fixed undefined identifiers

* fixed order

* reordered

* squashed bug finally
2021-01-14 13:35:47 +00:00
Terry Mancey 89c25f1cb1 Disable custom ad notifications in release and beta builds 2021-01-11 16:30:24 +00:00
samartnik e98b75a294 [Android] Renamings and c-tor signature changes 2021-01-05 21:27:43 -05:00
Deep 5b09d67215 Address PR comment 2021-01-04 19:53:40 -05:00
Deep 5eeb103ab1 Update design for privacy stats
Format code
2021-01-03 18:42:32 -05:00
Deep c94cc272b1 Update bookmark button behaviour 2021-01-02 13:43:51 -05:00
Brian JohnsonandMihai Plesa cfaea79cc6 Universal binary (#7475)
* cleanup signing scripts

* add option for manual copying in app to output dir

* add option for calling universalize

* fix args

* fix params

* add support for universal binary build/sign

* sign android as part of create_dist

* fix unused var

* fix incorrect sign_app path for android

* fix dmg path

* format

* add missing patch

* fixed mac build action paths

* removed duplicate mac signing action deps

* added missing :

Co-authored-by: Mihai Plesa <mplesa@brave.com>
2020-12-18 12:24:57 +00:00
samartnik 8ae5ae8fb5 [Android] Extended bytecode patching abilities
- added ability to redirect constructor
- simplified invocation of methods that are supposed to be patched
2020-12-15 16:07:33 -05:00
samartnik cccf13837f [Android] Explicitly declare mTabModelProfileSupplier
This prevents from build errors like

../../chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:627:
error: incompatible types: Object cannot be converted to Profile
                    Profile profile = mTabModelProfileSupplier.get();
2020-12-08 15:25:58 -05:00
samartnik d1f447b053 [Android] ChromeActivity reference removed from ToolbarManager class
Chromium change:
https://chromium.googlesource.com/chromium/src/+/b0a41fbddef0ae42991b0d608ad4126f32cb3580

Remove ChromeActivity reference from ToolbarManager class

Bug: 1123209
2020-12-08 15:25:57 -05:00
samartnik a477393eac [Android] OverviewModeBehavior was deprecated
Chromium change:
https://chromium.googlesource.com/chromium/src/+/eab0477e8eb9d5d838c9386140bce3182948a777

Migrate toolbar and omnibox to use LayoutStateObserver

This CL migrates the following package to use LayoutStateObserver:
  * org.chromium.chrome.browser.omnibox.*
  * org.chromium.chrome.browser.toolbar.*

Change-Id: Ica63de41ae8cae0b402da2e0d94d3c52a728f034
Bug: 1108496
2020-12-08 15:25:56 -05:00
samartnik ea96a6459b [Android] Fixed build error
Error fixed:

ERROR at //brave/build/android/BUILD.gn:45:1: Unknown function.
java_strings_grd("android_brave_strings_grd") {
^---------------
See //brave/BUILD.gn:87:11: which caused the file to be included.
  deps = ["build/$target_os:brave"]
2020-12-08 15:24:59 -05:00
samartnik 25a1249b91 [Android] Fixed changing super name for bytecode patching 2020-12-08 13:37:58 -05:00
Terry Mancey e40c547fd2 Brave Ads custom ad notifications crash on macOS 2020-12-01 00:51:15 +00:00
samartnik a52e5254f7 [Android] Added ability to prevent auto downloading and opening 2020-11-30 14:41:10 -05:00
Terry Mancey ef8f8da9c7 Implement custom Brave Ad notifications 2020-11-21 21:26:36 +00:00
AlexeyBarabash e24c42dffe Made Android support brave_p3a_enabled gn argument 2020-11-16 14:36:38 +02:00
samartnik 99fd8b0b17 [Android] Moved patches for BraveToolbarLayout and BraveTileView to asm
As per codereview suggetions:
https://github.com/brave/brave-core/pull/6554#discussion_r510308692
https://github.com/brave/brave-core/pull/6554#discussion_r510320067
2020-10-28 14:04:01 -04:00
samartnik 072bcd84a0 [Android] Fix for unit tests II
Chromium change:
https://chromium.googlesource.com/chromium/src/+/a65f80f87cc151be897131164e015d37bea1d155

[ToolbarMVC] Remove direct MenuButton interactions from Tabswitcher

This only requires giving TabSwitcherModeTTCoordinatorPhone a
MenuButtonCoordinator and setting the MenuButton view once inflation happens.
The logic removed (tinting, setting the onClick/accessibilityDelegate)
is now handled internally by MenuButtonCoordinator/MenuButton.

Bug: 1086676
2020-10-28 14:04:00 -04:00
samartnik c86d69b866 [Android] Move BottomToolbar code to brave-core (stage 3)
Pacthes to integrate BottomToolbar back to Chromium

Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/ad4cf0623574d9d7ea517d0063cb054d98766964

Duet: Clean up unused classes and resources

Delete all the classes and resources left unused by
Duet (BottomToolbar).

Bug: 1081343
2020-10-28 14:03:58 -04:00
samartnik 3965130cc8 [Android] Changes for menu on bottom toolbar
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/ad4cf0623574d9d7ea517d0063cb054d98766964

Duet: Clean up unused classes and resources

Delete all the classes and resources left unused by
Duet (BottomToolbar).

Bug: 1081343
2020-10-28 14:03:57 -04:00
samartnik f58e1205b7 [Android] Move BottomToolbar code to brave-core (stage 1)
Moved code deleted in Chromium to brave-core

Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/ad4cf0623574d9d7ea517d0063cb054d98766964

Duet: Clean up unused classes and resources

Delete all the classes and resources left unused by
Duet (BottomToolbar).

Bug: 1081343
2020-10-28 14:00:05 -04:00
samartnik 2f0d8cc0f2 [Android] Duet-related feature flags were removed (additional changes)
Chromium change:
https://chromium.googlesource.com/chromium/src/+/0ee3167aed0b3ef17a7a0905aaa27dcff3955d7d

Duet: Remove Duet-related feature flags

The feature has been sunset. Remove the related flags,
make some '..FeatureEnabled()' methods simply return false.

Cleaning up the rest of Duet-related code will follow soon.

Bug: 1081343
2020-10-28 14:00:05 -04:00
samartnik 4865e53faf [Android] Duet-related feature flags were removed
Chromium change:
https://chromium.googlesource.com/chromium/src/+/0ee3167aed0b3ef17a7a0905aaa27dcff3955d7d

Duet: Remove Duet-related feature flags

The feature has been sunset. Remove the related flags,
make some '..FeatureEnabled()' methods simply return false.

Cleaning up the rest of Duet-related code will follow soon.

Bug: 1081343
2020-10-28 14:00:05 -04:00
samartnik 0c8a08b36b [Android] Changed material design package name
Chromium change:
https://chromium.googlesource.com/chromium/src/+/3cd99aa27b47b24b44133959607b35380ed4633f

[Android] Fix material design package in resource exclusion regexes

Downstream material design targets are named slightly differently than
upstream material design. Remove the final "_material" from the regex in
order to also match downstream package names.

TBR=just bringing weblayer exclusions in line with chrome's

Bug: 1110346
2020-10-28 13:59:42 -04:00
Deep 424f37fe68 Reorder imports 2020-10-17 13:02:40 -04:00
Deep 3bcb3b158d Refactor and format code 2020-10-17 13:02:39 -04:00
Deep 9fbc7bb921 Fix import errors in native worker 2020-10-17 13:02:39 -04:00