Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/00bfce0c7635650f36baa1b335aa17c72cde1e70
Fix a bug Chrome is showing 2 rows of most visited tiles when query tiles are enabled
On small screen device, only 1 row of most visited tile should show when
query tiles are enabled.
However, TileSection hard coded the number of rows to 2. So even though
Chrome reduced most visited tiles to 4, it could still end up showing in
2 rows if the screen can only accommodate 3 tiles in a row.
BUG=1166388
(cherry picked from commit e97d0ce51b15cdb72da9a0ae67d9ceac1d08f646)
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/2336b6557478c544a81650258aab4b0e7af49c78
commit 2336b6557478c544a81650258aab4b0e7af49c78
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Mon Jan 11 01:13:17 2021 +0000
Toolbar: Move BottomControls to modularized target
This CL moves the classes for BottomControls MVC component plus
its layout xml to chrome/browser/ui/android/toolbar/.
Following dependencies on chrome_java were removed:
- ShareDelegate - was not in use.
- TabGroupUi - split to BottomControlsContentDelegate and extend
from it.
Bug: 1127732
Chromium change:
https://chromium.googlesource.com/chromium/src/+/eafd059d9f7f4656f7110349fa9ffd221dfae93c
Toolbar: TopUiThemeColorProvider
A ThemeColorProvider for top UI (TopUiThemeColorProvider)
replaces TabThemeColorProvider, and gets moved to a modularized
target chrome/browser/ui/android/theme. This is a new source of
truth for toolbar/top part of Chrome UI theme color.
Previously TabThemeColorHelper played the role, but now it was
redefined to provide the theme color coming from tab
contents only. TopUiThemeColorProvider puts together all
the signals and decides the final theme color to be used for
top UI.
Bug: 1127732
fixes brave-browser#13512
Chromium change:
https://chromium.googlesource.com/chromium/src/+/12166216f9de6248ae936722a3fac423349eb1e1
Make AndroidSyncSettings.isSyncEnabled() internal to SyncController
This method was one of the big villains of AndroidSyncSettings, because
it was easy to use it instead of some ProfileSyncService API. This CL
makes it internal to SyncController, avoiding new uses. A warning is
added to isChromeSyncEnabled() to prevent developers from thinking the
method has just been renamed. Extra care is taken not to weaken the
tests in AndroidSyncSettingsTest, replacing expectations on this method
accordingly.
Bug: 1107904
This prevents from build errors like
../../chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:627:
error: incompatible types: Object cannot be converted to Profile
Profile profile = mTabModelProfileSupplier.get();
Chromium change:
https://chromium.googlesource.com/chromium/src/+/eab0477e8eb9d5d838c9386140bce3182948a777
Migrate toolbar and omnibox to use LayoutStateObserver
This CL migrates the following package to use LayoutStateObserver:
* org.chromium.chrome.browser.omnibox.*
* org.chromium.chrome.browser.toolbar.*
Change-Id: Ica63de41ae8cae0b402da2e0d94d3c52a728f034
Bug: 1108496
Chromium change:
https://chromium.googlesource.com/chromium/src/+/a65f80f87cc151be897131164e015d37bea1d155
[ToolbarMVC] Remove direct MenuButton interactions from Tabswitcher
This only requires giving TabSwitcherModeTTCoordinatorPhone a
MenuButtonCoordinator and setting the MenuButton view once inflation happens.
The logic removed (tinting, setting the onClick/accessibilityDelegate)
is now handled internally by MenuButtonCoordinator/MenuButton.
Bug: 1086676
Otherwise there is an error:
../../brave/build/android/bytecode/java/org/brave/bytecode/BraveClassVisitor.java:24: error: symbol not found org.objectweb.asm.tree.ClassNode
import org.objectweb.asm.tree.ClassNode;
Chromium change:
https://chromium.googlesource.com/chromium/src/+/37b5b744bc83f630d3121b46868818bb4e848c2a
Don't launch external fallback URLs when not allowed to launch external URLs
Ensure that we don't launch external fallback URLs, when we've otherwise
decided that we should not launch an external navigation (even if it was
possible to). Also prevent auto subframe navigation from launching
external fallback URLs.
Bug: 1094442
Fixes crash on opening new tab after closing all
Fixes NTP image on changing phone layout
Related to chromium change:
https://chromium.googlesource.com/chromium/src/+/c0a930a52910bb56bf68925d9f233c29281c516b
commit c0a930a52910bb56bf68925d9f233c29281c516b
Author: Theresa Wellington <twellington@chromium.org>
Date: Fri May 1 20:33:45 2020 +0000
Combine FeedNewTabPage with NewTabPage, delete dead code
Fold FeedNewTabPage into NewTabPage and start cleaning-up Java code
that is no longer needed. Obviously dead code has been removed;
subsequent CLs will be needed to clean-up more Java code and C++
classes.
Bug: 1069183
Chromium change:
https://chromium.googlesource.com/chromium/src/+/c0a930a52910bb56bf68925d9f233c29281c516b
commit c0a930a52910bb56bf68925d9f233c29281c516b
Author: Theresa Wellington <twellington@chromium.org>
Date: Fri May 1 20:33:45 2020 +0000
Combine FeedNewTabPage with NewTabPage, delete dead code
Fold FeedNewTabPage into NewTabPage and start cleaning-up Java code
that is no longer needed. Obviously dead code has been removed;
subsequent CLs will be needed to clean-up more Java code and C++
classes.
Bug: 1069183
Alex C