Commit Graph
98 Commits
Author SHA1 Message Date
Mihai PLESA c2764d21ce re-add app links entitlement (#7425)
* re-add app links entitlement
2021-01-14 16:54:52 +00:00
Mihai PLESA aed168befc switch from arm64 only to universal (#7581)
* switch from arm64 only to universal

* script path fix

* fixed dependency cycle

* fixed undefined identifiers

* fixed order

* reordered

* squashed bug finally
2021-01-14 13:35:47 +00:00
mkarolin f6f6d30dc0 Formatting fixes. 2021-01-05 21:27:44 -05:00
Mihai PLESA ab3061742e follow-up fixes for universal binaries (#7479)
* follow-up fixes for universal binaries
2020-12-30 22:10:26 +00:00
Brian JohnsonandMihai Plesa cfaea79cc6 Universal binary (#7475)
* cleanup signing scripts

* add option for manual copying in app to output dir

* add option for calling universalize

* fix args

* fix params

* add support for universal binary build/sign

* sign android as part of create_dist

* fix unused var

* fix incorrect sign_app path for android

* fix dmg path

* format

* add missing patch

* fixed mac build action paths

* removed duplicate mac signing action deps

* added missing :

Co-authored-by: Mihai Plesa <mplesa@brave.com>
2020-12-18 12:24:57 +00:00
Mihai PLESA 9680773a89 renewed macos provisioning profiles (#7406)
Update Jenkinsfile
2020-12-13 10:03:56 +00:00
mkarolin 87f2f55e5a Ran format on build/mac/BUILD.gn. 2020-12-09 22:26:36 -05:00
mkarolin 7c85832b8c Output dir of signing on mac changed.
Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/09ab75a5507efc8465c6d1e467fae95b78294ed3

commit 09ab75a5507efc8465c6d1e467fae95b78294ed3
Author: Avi Drissman <avi@chromium.org>
Date:   Fri Oct 30 15:59:39 2020 +0000

    Mac packaging: make distributions that can share app bundles do so

    Bug: 1142508
2020-12-09 19:38:50 -05:00
Mihai PLESA d48a5bb3c8 various fixes for issues reported by sonar 2020-12-07 14:53:59 +00:00
Mihai PLESA d3b8931eda arm64 macos support 2020-11-21 19:48:52 +00:00
Simon Hong 62e7f6fd36 Set KSChannelID while tweaking Info.plist when signing is disabled 2020-11-11 11:44:26 +09:00
Simon Hong cbbbc825ff Made KSChannelID empty before signing
KSChannelID will be set during the signing by modification.py.
2020-11-11 09:06:36 +09:00
Mihai PLESA 247ee9187f last refactoring 2020-11-06 12:38:00 +00:00
Simon Hong 89e1c83be5 Fix wrong option name
and reorder some action's position in GN.
2020-11-06 07:44:43 +00:00
Mihai PLESA 6ba1559d17 refactoring 2020-11-06 07:44:43 +00:00
Simon Hong 33b4dcb9f8 Separate eddsa signing from delta generation 2020-11-06 07:44:43 +00:00
Simon Hong 9ca2fee77a Generate DSA signature for dmg 2020-11-06 07:44:43 +00:00
Simon Hong 5722a08c4f Generate delta file from final dmg file 2020-11-06 07:44:43 +00:00
Simon Hong b9e02cc54e Separate dmg eddsa signing from delta installer gen 2020-11-06 07:44:43 +00:00
Simon Hong e215b69140 Generate eddsa sig for dmg and store sig file as a file 2020-11-06 07:44:43 +00:00
Mihai Plesa 666993842e removed more dsa code 2020-11-06 07:44:43 +00:00
Simon Hong cea5b7a6f5 Use customized BinaryDelta for Brave instead of symlink reversing 2020-11-06 07:44:42 +00:00
Simon Hong 97b049030a Symlink reversing should be done for unsigned app bundle 2020-11-06 07:44:42 +00:00
Simon Hong fe2023f8e1 Pass private key to sign delta instead of fetching from keychain 2020-11-06 07:44:42 +00:00
Simon Hong a9d6310db0 Fix gn error 2020-11-06 07:44:42 +00:00
Simon Hong b58902ee0d Versioned symlink should created in relative path in Versions folder 2020-11-06 07:44:42 +00:00
Simon Hong 9dfaf4a12f Fix gn failure w/o skip_signing 2020-11-06 07:44:42 +00:00
Simon Hong 679a247ad4 Prepare Framework bundle for generating delta update
Due to version folder name difference, generated delta file is too big.
So, make Versions/Current as original directory and Versions/xxx.xxx.xxx
as a symlink.
2020-11-06 07:44:42 +00:00
Simon Hong d52ca9963b Support delta update on macOS
EdDSA public key should be set in .npmrc like sparkle_eddsa_key=XXXXX.
2020-11-06 07:44:42 +00:00
Anthony Tseng 321704829d Read the brave_helper location to get the location of the exe and then
call it directly
2020-10-13 12:52:49 -07:00
bridiver 2c47a166ab generate brave_helper so we run the correct brave exe on mac 2020-08-04 14:30:11 -07:00
Brian Clifton c10d7d705b Reverting change for which a security review was missed
See https://github.com/brave/security/issues/176 for more info

Unfixes https://github.com/brave/brave-browser/issues/10029
Reverts https://github.com/brave/brave-core/pull/5697

-----

Revert "Merge pull request #5697 from brave/register_brave_scheme_url_handler_on_mac"

This reverts commit e21f762c6c, reversing
changes made to 4f1cd8b2a5.
2020-06-12 23:22:53 -07:00
Simon Hong 35f744d38f Registered brave scheme url handler on macOS
brave://xxx url can be loaded from other applications.
2020-06-01 12:26:01 +09:00
mkarolin d7404b6672 cr83 followup: fixes notarization on MacOS.
Fixes brave/brave-browser#9971

- Restored provisioning profile param in GetBraveSigningConfig.
- Updated notarization script to not pass `development` param to GetBraveSigningConfig.
2020-05-27 10:53:34 -04:00
Kevin Kuehler f943f86bb2 macos: Fix postinstall for lowercase refcodes
For lowercase referral codes we normalize them to uppercase. When
stripping the referral code from the filename, that means we need to do
a case insensitive replacement. We use perl instead of sed because macOS
uses BSD sed, which doesn't support the "i" flag for regex.

Fixes https://github.com/brave/brave-browser/issues/9785
2020-05-14 12:48:14 -07:00
Kevin Kuehler 3ec602215e Revert "Revert "Promo services fixes""
This reverts commit f4883aa2d8.
2020-04-13 17:22:14 -07:00
Kevin Kuehler f4883aa2d8 Revert "Promo services fixes" 2020-04-11 13:46:27 -07:00
Kevin Kuehler 7646871e55 build/mac: Normalize referral code to uppercase
* If referral code is given in standard format ([a-zA-Z]{3}[0-9]{3}),
    convert to uppercase
  * Convert the script to #!/bin/bash because it is full of bash-isms
2020-04-08 12:50:15 -07:00
bridiver deafcd7b84 restore KSChannelID for crash reporting channel 2020-03-26 10:46:44 -07:00
bridiver 87c86f288d don't duplicate chrome_app 2020-03-26 10:46:38 -07:00
Matt Bacchi ba62ae4525 Add new nightly provisioning profile
Was altered when trying to fix https://github.com/brave/brave-browser/issues/7998
2020-01-31 17:14:08 -07:00
mkarolin 4bc50afb3d WIP: Remove keychain arg from mac signing/notarization.
Chromium change:

https://chromium.googlesource.com/chromium/src/+/ab025fb7573b0d33b9dfbcfd4f86609bd86b86d3

commit ab025fb7573b0d33b9dfbcfd4f86609bd86b86d3
Author: Avi Drissman <avi@chromium.org>
Date:   Wed Oct 23 21:43:54 2019 +0000

    Remove the keychain argument from the Mac packaging code.

    It's ignored by the Mac codesigning apparatus nowadays, anyway,
    so this simplifies things.

    Bug: 913074
2020-01-29 07:44:00 -05:00
Matt Bacchi d943a4f526 Fix notarization errors
Fixes: https://github.com/brave/brave-browser/issues/7194
2019-12-03 13:11:03 -07:00
mkarolin abb8baed21 Fixes mac notarization that C79 update broke.
Fixes brave/brave-browser#7191

When creating config use ChromiumCodeSigningConfig instead of the now
bare bones model.CodeSignConfig.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/c04be46a5d8ecbc2cf4d565a453d11212a9fd124

commit c04be46a5d8ecbc2cf4d565a453d11212a9fd124
Author: Robert Sesek <rsesek@chromium.org>
Date:   Wed Sep 18 00:57:47 2019 +0000

    macOS Signing Scripts: Split the config class and expand the hierarchy.

    The base CodeSignConfig is now in a normal Python module and it has
    unimplemented properties. The build-system-injected variables inherit
    from that for the BuildPropsCodeSignConfig. A new
    ChromiumCodeSignConfig class is created to set the signing properties
    for Chromium, to mirror the InternalCodeSignConfig for Google Chrome
    builds. Both ChromiumConfig and InternalCodeSignConfig inherit from
    the BuildPropsCodeSignConfig.

    This makes it easier to use the signing module without needing to
    process a config file.
2019-12-03 09:50:56 -05:00
Brian Clifton c62a95c126 Updated logic to multiply by major version (instead of adding 100 once) 2019-11-07 21:02:03 -07:00
Simon Hong 5a0607dd96 Override CFBundleVersion string
To make update work after moving to 1.0, CFBundleVersion should be
always higher versino than old one.
If we start to use 1.0.0, CFBundleVersion will be 0.0 and it is lower
than previous one such as 71.103 from 0.71.103. With this, update will not
work. So, we should adjust CFBundleVersion string after we move to 1.0.
In this PR, 100 is addded to brave minor version number.
With this, CFBundleVersion will be 100.0 from 1.0.0 and it's always higher
than previous one.
2019-11-07 21:02:02 -07:00
Terry Mancey 37708329f5 Fix ad notifications are not displayed on macOS Catalina 2019-11-03 07:53:48 +00:00
bridiver f0a0c6452c use chrome_mac_team_id 2019-10-31 15:24:19 -07:00
bridiver 3042279388 dev signing and notarizing support
fix https://github.com/brave/brave-browser/issues/6698
fix https://github.com/brave/brave-browser/issues/6699
2019-10-31 15:24:19 -07:00
Matt Bacchi f7a651684c Review updates
* extend and use GetBraveSigningConfig from signing_helper.py
* remove commented out section from create_config
* remove check for do_notarization
2019-10-30 17:39:24 +00:00