ChromeImporter runs in a separated service from upstream import service.
This new import service will use chrome::mojom::ProfileImportObserver and
brave::mojom::ProfileImportObserver and they are passed via
brave::mojom::ProfileImport.
brave::mojom::ProfileImportObserver and BraveImportBridge only define additional
interface.
BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.
BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.
NOTE: this commits has many cleanup changes around importing area
that uses deprecated patching style.
fix https://github.com/brave/brave-browser/issues/7974
Debug/DCHECK compilation now uses [-Werror,-Wextra-semi] which causes
semicolons after function definitions or namespaces to be treated as
errors. For example, void foo() {}; would produce an error due to the
trailing semicolon.
Chromium change:
commit a02a8f4b72fe5abad3c123a9c52c6ef78940de45
Author: Nico Weber <thakis@chromium.org>
Date: Sat Feb 23 04:13:21 2019 +0000
Reland "Enable -Wextra-semi in non-cros non-chromecast non-fuzzer linux builds that have DCHECKs enabled."
This is a reland of 5b911be859f216fe70bad5c41cc91a8684d773f6
Bug: 926235, 935033
base::JSONReader::ReadAndReturnError.
base::JSONReader changed signatue of Read to return Optional<Value>
instead of std::unique_ptr<Value>. ReadAndReturnError has been
deprecated and replaced with ReadAndReturnValueWithError that
returns a struct with error instead of having multiple out parameters.
Chromium chages:
commit 025edc25d8c8649d5a8dfd062e952855b3dfa13e
Author: Lei Zhang <thestig@chromium.org>
Date: Sat Feb 16 05:02:25 2019 +0000
Change base::JSONReader::Read()/ReadAndReturnError() to return Optional.
BUG=925165
commit 015397daa81409c43afbcd11ac41978cd7175cd0
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Feb 20 04:26:59 2019 +0000
Change base::JSONReader::ReadAndReturnError() to not use out params.
Instead of returning Optional<Value> and putting the error status in 4
out parameters, return struct ValueWithError which contains the value
and the error status.
- default search engine
- use DDG/Qwant for private tabs
- use DDG/Qwant for Tor tabs
Fixes https://github.com/brave/brave-browser/issues/2415
NOTE: if private tabs in tor is not set, TorWindowSearchEngineProviderService::GetInitialSearchEngineProvider will properly set the default
- removed un-used `clobber_wallet` param
- added validation for previously unvalidated fields
- pulled common cancel logic into common method (ProfileWriter)
- any parsing attempts are considered fatal; returns immediately
- properly handle reference to this when calling PostTaskAndReplyWithResult
- add dcheck for bridge_ptr_
- put `importer/brave_ledger.*` under !is_android block
- update CHECK to be DCHECK for ProfileWriter destructor
- use regular profile (ex: don't call GetOriginalProfile) in ProfileWriter
- remove signature from PostTaskAndReplyWithResult call
- Implements pinned logic captured in https://github.com/brave/brave-browser/issues/1910
- Tip amount in BAT is calculated based on % of monthly contribution. If < 1 BAT, pin is ignored.
- Any amounts spent towards tipping are deducted from monthly budget
- If monthly budget is below lowest value (15 BAT), auto-contribute is disabled
- Log error (and result code) when RestoreWallet is not successful
- Set contribution amount (again) after RestoreWallet, since we found this is adjusted
- Created new `kBravePaymentsPinnedItemCount` profile preference (present after import) for use with https://github.com/brave/brave-browser/issues/1910
- Remove unused wallet_seed code
bridiver