Grit is not happy with the {{}} placeholders. Why are we not just using
<ph>?
Error processing node <?xml version="1.0" encoding="UTF-8"?>
<message name="IDS_BRAVE_PRIVATE_NEW_TAB_BOX_TOR_TEXT_2">
Using Private Windows only changes what Brave does on your device — it doesn't change anyone else's behavior. Tor hides your IP address from the sites you visit, and hides the sites you visit from your ISP or your employer. Open a Private Window with Tor from the menu, or with {{ key }}.
</message>: {{ key }}.
Traceback (most recent call last):
File "../../tools/grit/grit.py", line 29, in <module>
sys.exit(grit.grit_runner.Main(sys.argv[1:]))
File "C:\bb4\brave-browser\src\tools\grit\grit\grit_runner.py", line 314, in Main
return toolobject.Run(options, args[1:])
File "C:\bb4\brave-browser\src\tools\grit\grit\tool\build.py", line 274, in Run
self.Process()
File "C:\bb4\brave-browser\src\tools\grit\grit\tool\build.py", line 409, in Process
self.ProcessNode(self.res, output, tmpfile)
File "C:\bb4\brave-browser\src\tools\grit\grit\tool\build.py", line 333, in ProcessNode
formatted = formatter(node, output_node.GetLanguage(), output_dir=base_dir)
File "C:\bb4\brave-browser\src\tools\grit\grit\format\data_pack.py", line 90, in Format
value = node.GetDataPackValue(lang, util.BINARY)
File "C:\bb4\brave-browser\src\tools\grit\grit\node\message.py", line 288, in GetDataPackValue
message = self.ws_at_start + self.Translate(lang) + self.ws_at_end
File "C:\bb4\brave-browser\src\tools\grit\grit\node\message.py", line 270, in Translate
self.ShouldFallbackToEnglish()
File "C:\bb4\brave-browser\src\tools\grit\grit\clique.py", line 406, in MessageForLanguage
return pseudolocales.PseudoRTLMessage(self.GetMessage())
File "C:\bb4\brave-browser\src\tools\grit\grit\pseudolocales.py", line 323, in PseudoRTLMessage
tree, placeholders = BuildTreeFromMessage(message)
File "C:\bb4\brave-browser\src\tools\grit\grit\pseudolocales.py", line 271, in BuildTreeFromMessage
return BuildTree(text), placeholders
File "C:\bb4\brave-browser\src\tools\grit\grit\pseudolocales.py", line 255, in BuildTree
assert not leftovers, leftovers
AssertionError: {{ key }}.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/19bd6c6cc41a4e5f41a61a8acb88e0337763e733
commit 19bd6c6cc41a4e5f41a61a8acb88e0337763e733
Author: Matt Stark <msta@google.com>
Date: Wed Feb 17 08:47:48 2021 +0000
Replace fake-bidi with the pseuduolocales en-XA and ar-XB
These pseudolocales have better translations, are not broken, and have a
consistent naming scheme with android pseudolocales.
BUG=chromium:1173812
13609: Added an Open in IPFS option for domains that have a TXT record that is prefixed with dnslink=
13611: Add a setting to automatically redirect for DNSLink
Sergey P