BlinkTestHostMsg has been converted to Mojo. We used that IPC method
for
BraveViewHostMsg_JavaScriptBlocked,
BraveViewHostMsg_FingerprintingBlocked, and
BraveFrameMsg_AllowScriptsOnce
messages.
Changed our code to use ChromeMsgStart and FrameMsgStart.
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/31755f407c3da7280224c677ce62768d8c858a50
commit 31755f407c3da7280224c677ce62768d8c858a50
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Thu Mar 12 10:27:02 2020 +0000
Convert BlinkTestHostMsg_PrintMessage to Mojo
This CL converts BlinkTestHostMsg_PrintMessage to BlinkTestClient
interface. But, BlinkTestRunner::PrintMessage needs to send a message
only when it's on the mainframe in order to sync with the existing
behavior. Like BlinkTestHostMsg_ResetDone conversion, this message
has been sent to the main frame. So, this CL moves |is_secondary_window|
from WebTestRenderFrameObserver to BlinkTestRunner.
Additionally, this CL removes blink_test_messages.h/cc files and related
things(e.g. BlinkTestMsgStart) finally.
Bug: 1039247, 1059322
As indicated in the message below, these are now only intended for
tests. A review of our code using these may be needed.
Chromium change:
commit c113169ee60372b8fe17f0f449860032bf3b859d
Author: danakj <danakj@chromium.org>
Date: Thu Mar 28 15:19:05 2019 +0000
Move Shell messages to web_test and rename to BlinkTest.
These messages are only used by web_test/blink_test_{controller,runner}.
So move them into common/web_test, to indicate they are for tests not
content shell.
Also give them their own target so that test_runner can be made to use
them, since they are only for tests. I believe this would let us move
BlinkTestRunner into test_runner, and remove WebTestDelegate interface
out of content/shell/renderer.
R=avi@chromium.org
TBR=inferno
Bug: 866140
commit b6f010b107495bd0487353edfb379c441c9969b6
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Nov 22 07:26:07 2018 +0000
IPC_STRUCT_BEGIN: Don't explicitly default copy constructors etc
The classes may not actually be copyable, copy-assignable, etc. Previously the
compiler would not complain until trying to *use* the defaulted ctor/operator,
but the new -Wdefaulted-function-deleted warning warns about this up front.
(As a concrete example, ExtensionMsg_TabConnectionInfo isn't copy-assignable
because of base::DictionaryValue member, which is a base::Value, which can't
be copied.)
To ensure these structs are still movable, remove the user-declared destructor.
This is also a simplification in that it removes all the code that was necessary
to define that destructor out-of-line.
bridiver