Chromium changes:
https://source.chromium.org/chromium/chromium/src/+/26cb15fed7a25af6721948f727bd3d6a5bca3516
commit 26cb15fed7a25af6721948f727bd3d6a5bca3516
Author: Daniel Hosseinian <dhoss@chromium.org>
Date: Sat Nov 14 01:14:36 2020 +0000
Use base::GUID in bookmarks::BookmarkNode's internals
Store the GUID as a base::GUID instead of a std::string. Change the
constructor of BookmarkNode to take a base::GUID. Modify the code
around callers to make them compatible with the new API.
BookmarkNode::guid() still returns a std::string(). It will be changed
to return a base::GUID() in a follow-up.
Bug: 1026195
https://source.chromium.org/chromium/chromium/src/+/6de24fa7a8fcdbbb522034162112174057c9bc3a
commit 6de24fa7a8fcdbbb522034162112174057c9bc3a
Author: Daniel Hosseinian <dhoss@chromium.org>
Date: Tue Nov 17 19:19:53 2020 +0000
Return a base::GUID from bookmarks::BookmarkNode::guid()
Now that bookmarks::BookmarkNode stores a base::GUID instead of a
std::string, return a base::GUID. Modify the code around callers to make
them compatible with the new API.
Bug: 1026195
Fixes sync-related build on Android and iOS.
Reflects PeopleHandler::HandleSetEncryption changes.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/c28113d0bcc14e3b6f7507ab025add20b072da32
commit c28113d0bcc14e3b6f7507ab025add20b072da32
Author: Victor Hugo Vianna Silva <victorvianna@google.com>
Date: Thu Oct 15 20:22:36 2020 +0000
Remove SyncEncryptionHandler::*EncryptEverything* methods
EnableEncryptEverything() and IsEncryptEverythingEnabled() were only
relevant for the Directory implementation of Nigori, so they can be
removed now, together with the associated plumbing.
Bug: 1033040
ios/browser/api/bookmarks/brave_bookmarks_api.h:82: Missing spaces around = [whitespace/operators] [4]
and
ios/browser/api/bookmarks/brave_bookmarks_api.h:64: Using C-style cast. Use reinterpret_cast<NSString*>(...) instead [readability/casting] [4]
???
Fixed Bookmarks importer/exporter to execute on the correct threads internally.
Added `TopLevelFolder` parameter for importing so that the iOS side can choose the name of the folder bookmarks will be imported into (this is mostly done for localization because iOS doesn't have access to IDS_BOOKMARKS_GROUP l10n resource key).
mkarolin