Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
20,645 Commits 1 Branch 0 Tags
27deb5606b003f72854ede055eeea2cbcd279fa0
Commit Graph
46 Commits
Author SHA1 Message Date
mkarolin e476b684fc Formatting fixes. 2021-02-04 23:52:44 -05:00
Max Karolinskiy 83457d8fd5 [iOS] BookmarkNode c'tor now uses base::GUID instead of a std::string. 
Chromium changes:

https://source.chromium.org/chromium/chromium/src/+/26cb15fed7a25af6721948f727bd3d6a5bca3516

commit 26cb15fed7a25af6721948f727bd3d6a5bca3516
Author: Daniel Hosseinian <dhoss@chromium.org>
Date:   Sat Nov 14 01:14:36 2020 +0000

    Use base::GUID in bookmarks::BookmarkNode's internals

    Store the GUID as a base::GUID instead of a std::string. Change the
    constructor of BookmarkNode to take a base::GUID. Modify the code
    around callers to make them compatible with the new API.

    BookmarkNode::guid() still returns a std::string(). It will be changed
    to return a base::GUID() in a follow-up.

    Bug: 1026195

https://source.chromium.org/chromium/chromium/src/+/6de24fa7a8fcdbbb522034162112174057c9bc3a

commit 6de24fa7a8fcdbbb522034162112174057c9bc3a
Author: Daniel Hosseinian <dhoss@chromium.org>
Date:   Tue Nov 17 19:19:53 2020 +0000

    Return a base::GUID from bookmarks::BookmarkNode::guid()

    Now that bookmarks::BookmarkNode stores a base::GUID instead of a
    std::string, return a base::GUID. Modify the code around callers to make
    them compatible with the new API.

    Bug: 1026195
 2021-02-04 23:52:40 -05:00
mkarolin 74cfd56e8a base/bind_helpers.h -> callback_helpers.h II. 2021-01-05 21:27:44 -05:00
Simon Hong 9acfdee04b Fix gn_check error on iOS 2020-12-04 09:56:30 +09:00
Brandon 3d5898a92a Fix Linting for Android/Linux 2020-12-02 20:19:46 -07:00
Brandon b21fda50d5 Fix signature of function callback. 
Fixes https://github.com/brave/brave-browser/issues/12997
 2020-12-02 20:19:46 -07:00
Brandon 46a8534545 Rename functions and add documentation explaining it. 
Removed duplicate code.
 2020-12-01 13:16:43 -05:00
Brandon 4f47f850bd Added folder filtering for the iOS side to prevent users from moving parent folders into child folders. 2020-12-01 11:31:11 -05:00
bridiver 5f447ac4ef clang format cleanup 2020-11-30 17:48:17 -07:00
bridiver bbdd555a80 fix lint 2020-11-30 13:54:21 -07:00
Brandon 41766d1264 Used the existing bookmark_codec to encode bookmarks instead of copy pasting and modifying. 2020-11-30 07:34:53 -05:00
Brian Clifton d1c39c73d5 Add missing gn deps 2020-11-30 07:34:52 -05:00
Brandon bb8760be69 Fixed bookmarks performance. 
Fixed BookmarkNode naming for iOS.
 2020-11-30 07:34:52 -05:00
Brandon fae6eb67a8 Fixed iOS compiling issues. C++ headers cannot be imported in an exported Objective-C header. 2020-11-30 07:34:52 -05:00
Brandon ee2eaf3a64 Fixed exporting of bookmark children and nested children for performance reasons. 2020-11-30 07:34:52 -05:00
bridiver 156b28bce7 fix weird incorrect lint errors like 
ios/browser/api/bookmarks/brave_bookmarks_api.h:82:  Missing spaces around =  [whitespace/operators] [4]
and 
ios/browser/api/bookmarks/brave_bookmarks_api.h:64:  Using C-style cast.  Use reinterpret_cast<NSString*>(...) instead  [readability/casting] [4]
???
 2020-11-30 07:34:52 -05:00
bridiver f5c57545f5 lint 2020-11-30 07:34:52 -05:00
bridiver 0bcc76e568 lint/clang format 2020-11-30 07:34:52 -05:00
bridiver b64cd13619 clang format 2020-11-30 07:34:52 -05:00
bridiver 5977b45c09 clang format 2020-11-30 07:34:52 -05:00
bridiver a695146f5f clang format 2020-11-30 07:34:52 -05:00
bridiver a21e9c40c8 clang format 2020-11-30 07:34:52 -05:00
bridiver a1e2c588ca clang format 2020-11-30 07:34:52 -05:00
Brandon e154f8db17 Added a boolean to determine if the underlying model has suddenly become null or destroyed such as when brave-ios/issues/3011 && brave-browser/issues/12530 happens.. 2020-11-30 07:34:51 -05:00
Brandon 8ef9352243 Addressing weird indentations. 2020-11-30 07:34:51 -05:00
Brandon a1c756570c Fixed a "possible" bug in fav_icon images. 2020-11-30 07:34:51 -05:00
Brandon 39a15233a5 Fixing PR feedback. 2020-11-30 07:34:51 -05:00
Brandon e4b7b63ac7 Minor changes to the interface to use properties. 
Import favIcons via iOS APIs.
Updated API interface and added FavIcon encoding.
 2020-11-30 07:34:51 -05:00
Brandon d65e26242d Fixed threading retaining with weak/strong specifies. 
Added explicit ARC assertions to the top of the files.
 2020-11-30 07:34:51 -05:00
Brandon 980e70a23c Cleanup optional interface. 
Fixed Bookmarks importer/exporter to execute on the correct threads internally.
Added `TopLevelFolder` parameter for importing so that the iOS side can choose the name of the folder bookmarks will be imported into (this is mostly done for localization because iOS doesn't have access to IDS_BOOKMARKS_GROUP l10n resource key).
 2020-11-30 07:34:51 -05:00
Brandon 3963e2c0b3 Export interface for iOS side to construct a bookmark IR model. 2020-11-30 07:34:51 -05:00
Brandon 7c4fd252ed Added Bookmark Export Utility for CoreData. 2020-11-30 07:34:51 -05:00
Brandon 3da843115a Add callbacks for Import and Export of bookmarks. 2020-11-30 07:34:50 -05:00
Brandon ca6c899317 Added importing and exporting bookmarks. 
Refactored some other sync code.
Added deleting devices by guid.
 2020-11-30 07:34:50 -05:00
Brandon 0528f44bf9 Import and Export bookmarks Interface linked. 2020-11-30 07:34:50 -05:00
Brandon adea3d2ed8 Made all observer functions optional because iOS doesn't need to use them all. 2020-11-30 07:34:50 -05:00
Brandon 0012e30d0d Minor changes to interface. 2020-11-30 07:34:50 -05:00
Brandon 09b4fe2ca3 Addressing feedback and using properties instead of functions. 2020-11-30 07:34:50 -05:00
Brandon ea0a581204 Made APIs a singleton. Exported converting Hex-Seed to Code-Words. 2020-11-30 07:34:50 -05:00
Brandon db2c217716 add dcheck to make sure we're calling things on the correct thread 2020-11-30 07:34:49 -05:00
Brandon T 243c63f113 Added Bookmarks Observer. Fixed all nullability for Swift to not make everything optional. 
Export the observer for the iOS side to observe when it can finally use and create bookmarks.
 2020-11-30 07:34:49 -05:00
Pranjal Jumde 86317a638a fix sync build for c86 2020-11-30 07:34:49 -05:00
Brandon T f225ce055d Rename function to match iOS property access - Apple style guide. 2020-11-30 07:34:49 -05:00
Pranjal Jumde e6c9742238 Update BraveRewards to link PROPERLY without forcing all symbols to be public which causes a LOT of issues with weak symbols, global variables, and linking.. 2020-11-30 07:34:49 -05:00
Brandon T d4c3df862d Bookmarks API is feature complete and can actually be used to create and remove bookmarks.. 
Updated API to match Chromium API.
Added convenience functions to the iOS BookmarkNode for updating a node's info.
 2020-11-30 07:34:49 -05:00
Brandon 8ea729d960 fix connection to brave sync service 2020-11-30 07:34:49 -05:00