Chromium change:
https://chromium.googlesource.com/chromium/src/+/d39cdd39e105f08aeebc1bad950d7b2a1b1778bc
Roll ARCore SDK to 1.18, update device implementation
Changes:
- Roll ARCore SDK to version 1.18.
- Updated device implementation to opt in to use 30FPS.
- Updated ARCore APK version to 1.18.200603086 for the test bots to use.
- Updated ARCore session recording - now that the code opts in to use
30FPS, the recordings need to be done at 30FPS as well, otherwise the
camera configuration will fail.
~3kb since it needs to consume newly introduced APIs to configure AR
session. The remaining size increase can be mostly attributed to the
dependency growing (+8kb) and overhead (~4kb) - see breakdown for
details.
Otherwise there is error
java.lang.SecurityException: no permission to read the sync settings: Neither user 10096 nor current process has android.permission.READ_SYNC_SETTINGS
Notes on non-trivial changes:
-------------------------------------------------------------------------------
Renamed:
patches/chrome-android-java-src-org-chromium-chrome-browser-preferences-MainPreferences.java.patch
-> patches/chrome-android-java-src-org-chromium-chrome-browser-settings-MainPreferences.java.patch
patches/chrome-android-java-src-org-chromium-chrome-browser-preferences-website-SiteSettingsPreferences.java.patch
-> patches/chrome-android-java-src-org-chromium-chrome-browser-settings-website-SiteSettingsPreferences.java.patch
Chromium change:
https://chromium.googlesource.com/chromium/src/+/4b1887815272e0870334035e0788bb6a3c2ec162
commit 4b1887815272e0870334035e0788bb6a3c2ec162
Author: Natalie Chouinard <chouinard@chromium.org>
Date: Wed Nov 27 20:29:55 2019 +0000
Separate preferences and settings subpackages
Move all classes under org.chromium.chrome.browser.preferences which are
related to Android settings screens (rather than the underlying
preferences persistence layers) to org.chromium.chrome.browser.settings
instead.
This disambiguation was decided in go/clank-preferences-refactor.
Dependent downstream change: https://crrev.com/i/2222930TBR=tedchoc@chromium.org
NOPRESUBMIT=true
Binary-Size: Keeping existing method name, see crrev.com/c/1935716
Bug: 1027271
-------------------------------------------------------------------------------
patches/chrome-android-java-src-org-chromium-chrome-browser-toolbar-ToolbarManager.java.patch
Chromium change:
https://chromium.googlesource.com/chromium/src/+/6de109fb7c37bc6a6a9ac64e9361acdc16d03a4c
commit 6de109fb7c37bc6a6a9ac64e9361acdc16d03a4c
Author: Kyle Milka <kmilka@chromium.org>
Date: Tue Nov 19 21:49:14 2019 +0000
Set share button onclick only when ShareDelegate is ready
As a follow-up to https://crrev.com/c/1869491 only hook up the bottom
toolbar's onclick listener once ShareDelegate is available
(bottomSheetController has been initialized).
Bug: 1869491
-------------------------------------------------------------------------------
Renamed:
patches/chrome-android-java-src-org-chromium-chrome-browser-util-FeatureUtilities.java.patch
-> patches/chrome-android-java-src-org-chromium-chrome-browser-flags-FeatureUtilities.java.patch
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/991cea18ce9b350b9875066683a1ebc87587bc2d
commit 991cea18ce9b350b9875066683a1ebc87587bc2d
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Fri Oct 25 20:11:49 2019 +0000
Move FeatureUtilities to chrome.browser.flags.
chrome.browser.utils should only contain leaf-node util classes, and is
now in a separate build target.
Bug: 995916
https://chromium.googlesource.com/chromium/src/+/404ca6f1d93718b00e18a222a53f46de736163e5
commit 404ca6f1d93718b00e18a222a53f46de736163e5
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Tue Nov 19 21:47:14 2019 +0000
Move constants back from FeatureUtilities to ChromePreferenceKeys.
All SharedPreferences keys used in Chrome should be in ChromePreferenceKeys.
Also update some outdated documentation in FeatureUtilities.
Bug: 1022108
https://chromium.googlesource.com/chromium/src/+/32bab2eff398787266e349509843909978978bfc
commit 32bab2eff398787266e349509843909978978bfc
Author: Sinan Sahin <sinansahin@google.com>
Date: Wed Nov 6 21:01:05 2019 +0000
Make the Android dark theme flag enabled by default
Bug: 1018268
-------------------------------------------------------------------------------
Moved patching:
patches/chrome-browser-resources-bookmarks-toolbar.html.patch
-> patches/chrome-browser-resources-bookmarks-toolbar.js.patch
Chromium change:
https://chromium.googlesource.com/chromium/src/+/f0aa38c224f10ef337695fedd38970f006e9095a
commit f0aa38c224f10ef337695fedd38970f006e9095a
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Nov 19 01:21:31 2019 +0000
Bookmarks Web UI: Migrate to Polymer 3
Update the bookmarks Web UI to use Polymer 3/JS modules, and remove
usage of HTML imports. Also update all bookmarks tests.
This slightly reduces the size of the bookmarks resources on
optimized builds, by around 6%:
Before:
vulcanized.html 100k
crisper.js 207k
Total: 307k
After:
vulcanized.html 1k
bookmarks.js 287k
Total: 288k
Note: Not running clang-format on
chrome/browser/resources/bookmarks or
chrome/test/data/webui/bookmarks, to make reviewing/rebasing simpler.
Both these folders will be formatted separately in a followup CL.
Bug: 1022213
-------------------------------------------------------------------------------
Moved patching:
patches/chrome-browser-resources-downloads-toolbar.html.patch
-> patches/chrome-browser-resources-downloads-toolbar.js.patch
Chromium change:
https://chromium.googlesource.com/chromium/src/+/ffb30cf5891e562ce688f5dad47f841b57da0741
commit ffb30cf5891e562ce688f5dad47f841b57da0741
Author: Demetrios Papadopoulos <dpapad@chromium.org>
Date: Tue Nov 19 02:42:18 2019 +0000
Downloads WebUI: Migrate to Polymer3
Updating chrome://downloads to use Polymer 3/JS modules and
removing usage of HTML imports
Size comparison (~5.7% reduction)
Before:
vulcanized.html 90k
crisper.js 135k
Total 225k
After:
vulcanized.html 1.1k
downloads.js 211k
Total: 212.1k
Bug: 1022215
-------------------------------------------------------------------------------
Partially moved patching:
patches/chrome-browser-resources-extensions-item_list.html.patch
-> patches/chrome-browser-resources-extensions-item_list.js.patch
Chromium change:
https://chromium.googlesource.com/chromium/src/+/fb9837799bb6388ecaee010fc80cc1438e6bb134
commit fb9837799bb6388ecaee010fc80cc1438e6bb134
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Oct 31 19:15:49 2019 +0000
Extensions Web UI: Migrate to Polymer 3/JS Modules
Measured Polymer 3 optimized UI to have similar performance to the
optimized Polymer 2 UI. The non-optimized version is ~25-30% faster
than the non-optimized Polymer 2 page.
Size:
Previous bundled page:
vulcanized.html: 194k
crisper.js: 234k
Total: 428k
Polymer 3 bundled page:
vulcanized.html: 2k
extensions.js: 406k
total: 408k (~20k smaller)
Note that the size of extensions.js is larger than necessary because
the Polymer license comments are included for every file, instead of
only once for each distinct license year, as was the case when these
comments were in HTML files processed by Polymer bundler, rather than
in JS files processed by uglify. So further improvements may be
possible in future.
Fixed: 1004967
-------------------------------------------------------------------------------
Moved patching:
patches/chrome-browser-resources-extensions-manager.html.patch
-> patches/chrome-browser-resources-extensions-manager.js.patch
patches/chrome-browser-resources-extensions-toolbar.html.patch
-> patches/chrome-browser-resources-extensions-toolbar.js.patch
Chromium change:
https://chromium.googlesource.com/chromium/src/+/fb9837799bb6388ecaee010fc80cc1438e6bb134
commit fb9837799bb6388ecaee010fc80cc1438e6bb134
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Oct 31 19:15:49 2019 +0000
Extensions Web UI: Migrate to Polymer 3/JS Modules
Measured Polymer 3 optimized UI to have similar performance to the
optimized Polymer 2 UI. The non-optimized version is ~25-30% faster
than the non-optimized Polymer 2 page.
Size:
Previous bundled page:
vulcanized.html: 194k
crisper.js: 234k
Total: 428k
Polymer 3 bundled page:
vulcanized.html: 2k
extensions.js: 406k
total: 408k (~20k smaller)
Note that the size of extensions.js is larger than necessary because
the Polymer license comments are included for every file, instead of
only once for each distinct license year, as was the case when these
comments were in HTML files processed by Polymer bundler, rather than
in JS files processed by uglify. So further improvements may be
possible in future.
Fixed: 1004967
-------------------------------------------------------------------------------
Partial patch removal:
patches/chrome-browser-ui-page_info-page_info.cc.patch
Chromium change:
https://chromium.googlesource.com/chromium/src/+/1785f13de1aede35cddacd92f1e462f7f81eff43
commit 1785f13de1aede35cddacd92f1e462f7f81eff43
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Nov 26 22:10:09 2019 +0000
Autoplay: remove muted autoplay settings UI.
A follow-up will remove the associated backend code.
Bug: 1028264
-------------------------------------------------------------------------------
Moved patching:
patches/chrome-browser-ui-views-permission_bubble-permission_prompt_impl.cc.patch
-> patches/chrome-browser-ui-views-permission_bubble-permission_prompt_bubble_view.cc.patch
Chromium change:
https://chromium.googlesource.com/chromium/src/+/be8754bf30fb9c61122c8438287f3dc543714919
commit be8754bf30fb9c61122c8438287f3dc543714919
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed Nov 27 15:39:33 2019 +0000
Move PermissionsBubbleDialogDelegateView into its own file.
This patch moves PermissionsBubbleDialogDelegateView out of
permission_prompt_impl.cc, renames it to PermissionPromptBubbleView,
changes most methods on PermissionPromptImpl to delegate to the bubble
class instead of manipulating it directly, and rewrites the bubble code
to be more idiomatic.
This patch also deletes permission_prompt_impl_views.cc and moves the
function inside it to permission_prompt_impl.cc, since the latter is
now much simpler.
Bug: 1019129
-------------------------------------------------------------------------------
Renamed:
patches/chrome-browser-ui-webui-history_ui.cc.patch
-> patches/chrome-browser-ui-webui-history-history_ui.cc.patch
Chromium change:
https://chromium.googlesource.com/chromium/src/+/be1286338ae578db98fd2f3989233e643b28e4ad
commit be1286338ae578db98fd2f3989233e643b28e4ad
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Nov 22 04:50:42 2019 +0000
History Web UI: Move handlers/UI classes to separate folder
Also changing NULL to nullptr and fixing an include error.
Bug: 1022212
-------------------------------------------------------------------------------
Patch removal:
patches/chrome-browser-upgrade_detector-upgrade_detector_impl.h.patch
Partial patch removal:
patches/chrome-browser-upgrade_detector-upgrade_detector_impl.cc.patch
Chromium change:
https://chromium.googlesource.com/chromium/src/+/4d7b41a0871c57e45e4675acf7369f5433a8dfb9
commit 4d7b41a0871c57e45e4675acf7369f5433a8dfb9
Author: Nico Weber <thakis@chromium.org>
Date: Mon Oct 28 14:58:41 2019 +0000
More GOOGLE_CHROME_BUILD -> GOOGLE_CHROME_BRANDING.
Changes some new uses, and does fairly harmless modifications
to keep GOOGLE_CHROME_BRANDING out of .h files.
Bug: 961769
-------------------------------------------------------------------------------
Renamed patch:
patches/chrome-renderer-content_settings_observer.h.patch
-> patches/chrome-renderer-content_settings_agent_impl.h.patch
Changed patch:
patches/chrome-renderer-chrome_content_renderer_client.cc.patch
Changing patch with the expectation that BraveContentSettingsObserver
will have to be changed into BraveContentSettingsAgentImpl.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/2f8d810ec34e1b8a23b5003759d7f71b4ba00588
commit 2f8d810ec34e1b8a23b5003759d7f71b4ba00588
Author: Darin Fisher <darin@chromium.org>
Date: Wed Oct 23 18:51:46 2019 +0000
Convert content settings IPC over to Mojo
This renamed ContentSettingsRenderer to ContentSettingsAgent and the corresponding
class ContentSettingsObserver to ContentSettingsAgentImpl. This class represents
the agent of the content settings system that runs in the renderer process. It is
responsible for answering some of the blink::WebContentSettingsClient methods
directly and for others it needs to delegate to the browser process. It does so
through a new interface named ContentSettingsManager. This provides async and sync
methods to check for permission to access different storage types.
A big change here is that instead of answering these questions about storage
access on the IO thread, now the code is answering those on the UI thread. The
old code was constrained by the NPAPI plug-in system that forced synchronous IPCs
from the renderer process to be handled not on the UI thread. Now we no longer
have that constraint, and it is far simpler to just handle the IPCs directly on
the UI thread. There is potential for some added delay to storage access if the
browser's UI thread happens to be busy, but this should be a minor issue compared
to the overall cost of accessing the storage systems.
-------------------------------------------------------------------------------
Removed patches:
patches/components-sync_bookmarks-bookmark_change_processor.cc.patch
patches/components-sync_bookmarks-bookmark_change_processor.h.patch
Chromium implementation changed (bookmark support in sync v2):
https://bugs.chromium.org/p/chromium/issues/detail?id=516866
Chromium change that removed the patched files:
https://chromium.googlesource.com/chromium/src/+/fdece9dd1e1f7840a643c85e2d89f356b153fe2c
commit fdece9dd1e1f7840a643c85e2d89f356b153fe2c
Author: Marc Treib <treib@chromium.org>
Date: Mon Oct 21 14:00:20 2019 +0000
Delete BookmarkModelAssociator and BookmarkChangeProcessor
These were part of the old bookmark sync implementation and not used
anymore.
With this, the ModelAssociator interface becomes unused and is removed
too.
profile_sync_service_bookmark_unittest.cc basically contained unit tests
for the two removed classes, also based on low-level directory code.
These are not relevant anymore and so are also removed.
Bug: 933756
-------------------------------------------------------------------------------
Renamed patch:
patches/third_party-blink-renderer-platform-exported-web_canonical_cookie.cc.patch
-> patches/third_party-blink-renderer-platform-cookie-canonical_cookie.cc.patch
Chromium change:
https://chromium.googlesource.com/chromium/src/+/49c6533d3819fc19ca56329b1e30d84339c4c2d6
commit 49c6533d3819fc19ca56329b1e30d84339c4c2d6
Author: Henrique Ferreiro <hferreiro@igalia.com>
Date: Tue Oct 29 10:36:59 2019 +0000
Move WebCanonicalCookie out of public/platform
blink::WebCanonicalCookie has no users outside of //third_party/blink.
Move this class to //third_party/blink/renderer/platform as
blink::CanonicalCookie.
Bug: 919392
-------------------------------------------------------------------------------
Partial patch removal:
patches/chrome-browser-importer-importer_list.cc.patch
This was a patch that implemented upstream change.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/5e3cc0612e21ce260f29cb702b0e83289f32cda2
commit 5e3cc0612e21ce260f29cb702b0e83289f32cda2
Author: Yann Dago <ydago@chromium.org>
Date: Tue Oct 22 21:15:26 2019 +0000
Fixes data import from Firefox versions 67 and newer.
Bug: 1003284
-------------------------------------------------------------------------------
Removed patch:
patches/chrome-browser-renderer_host-chrome_render_message_filter.h.patch
The original file has been removed. We'll need to rework the patch's functionality, our
override implementation browser/renderer_host/brave_render_message_filter.h and the
override's use in chromium_src/chrome/browser/chrome_content_browser_client.cc.
Most likely chrome/browser/content_settings/content_settings_manager_impl.cc/h
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/2f8d810ec34e1b8a23b5003759d7f71b4ba00588
commit 2f8d810ec34e1b8a23b5003759d7f71b4ba00588
Author: Darin Fisher <darin@chromium.org>
Date: Wed Oct 23 18:51:46 2019 +0000
Convert content settings IPC over to Mojo
This renamed ContentSettingsRenderer to ContentSettingsAgent and the corresponding
class ContentSettingsObserver to ContentSettingsAgentImpl. This class represents
the agent of the content settings system that runs in the renderer process. It is
responsible for answering some of the blink::WebContentSettingsClient methods
directly and for others it needs to delegate to the browser process. It does so
through a new interface named ContentSettingsManager. This provides async and sync
methods to check for permission to access different storage types.
A big change here is that instead of answering these questions about storage
access on the IO thread, now the code is answering those on the UI thread. The
old code was constrained by the NPAPI plug-in system that forced synchronous IPCs
from the renderer process to be handled not on the UI thread. Now we no longer
have that constraint, and it is far simpler to just handle the IPCs directly on
the UI thread. There is potential for some added delay to storage access if the
browser's UI thread happens to be busy, but this should be a minor issue compared
to the overall cost of accessing the storage systems.
https://chromium.googlesource.com/chromium/src/+/e9115d25fa859307d7d362b83b6500a700d707a4
commit e9115d25fa859307d7d362b83b6500a700d707a4
Author: Darin Fisher <darin@chromium.org>
Date: Mon Dec 2 06:03:45 2019 +0000
Replace ChromeViewHostMsg_IsCrashReportingEnabled w/ Mojo IPC.
Bug: 967834
-------------------------------------------------------------------------------
mkarolin