Not sure this can be fixes as is due to the Chromium change below.
Need to come up with a different way of testing that the origin trial
would not work.
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/529f43bc5bed70eda143373a588611acce3bc89e
commit 529f43bc5bed70eda143373a588611acce3bc89e
Author: Hayato Ito <hayato@chromium.org>
Date: Mon Dec 7 14:25:45 2020 +0000
Support WebBundle Subresource loading via Network Service
This is a follow-up to https://crrev.com/c/2560526.
This CL changes the implementation of WebBundle subresource loading
from "renderer oriented" to "network service oriented".
Before this CL, a renderer parses a WebBundle and serves a subresource
from there directly.
After this CL, they are done in the Network Service, instead of a renderer.
The motivation we're changing our design is "we should honor CORB
[1]". A renderer shouldn't have cross-origin data in their memory.
See the design doc [2] for details.
Note this CL removes
blink/renderer/platform/loader/fetch/url_loader/web_bundle_subresource_loader_test.cc,
which was already moved to
services/network/web_bundle_url_loader_factory_unittest.cc in a previous CL.
- [1]: https://source.chromium.org/chromium/chromium/src/+/master:services/network/cross_origin_read_blocking_explainer md
- [2]: https://docs.google.com/document/d/1_AqUBS4Gr45MPPtXGTUl7Q0DMIEw2zUeWO0zo6Sj0z4/edit
Bug: 1082020
Also, NativeFileSystem origin trial was removed.
Chromium changes:
https://source.chromium.org/chromium/chromium/src/+/07ecb97fd6498002303f162d9e6cc5f248599eff
commit 07ecb97fd6498002303f162d9e6cc5f248599eff
Author: Austin Sullivan <asully@chromium.org>
Date: Fri Jan 8 15:16:17 2021 +0000
Rename native_file_system -> file_system_access part 3/x.
This finishes renaming in blink, with the exception of web platform
tests.
Renames "NativeFileSystem" to FileSystemAccess or FileSystem.
Generally, NativeFileSystem is renamed to FileSystemAccess.
In cases where IDL exposes something as "FileSystem", NativeFileSystem
is renamed to "FileSystem".
Bug: 1110509
https://source.chromium.org/chromium/chromium/src/+/9926254ea8d51ce3845d468262eb5cfa5020754f
commit 9926254ea8d51ce3845d468262eb5cfa5020754f
Author: Austin Sullivan <asully@chromium.org>
Date: Fri Jan 8 16:48:02 2021 +0000
[FSA] Remove NativeFileSystem2 origin trial
The origin trial is no longer needed, since the feature has already
shipped.
This change was originally proposed in this refactor [1], but was split
into another CL.
[1] https://crrev.com/c/2601576
Bug: 1110509
Fixesbrave/brave-browser#11133Fixesbrave/brave-browser#11407Fixesbrave/brave-browser#11546Fixesbrave/brave-browser#11547
- Disables features via Chromium features:
* Direct Sockets
* Lang Client Hint Header
* Signed Exchange Prefetch Cache For Navigations
* Subresource Web Bundles
- Disabled the following blink features in
BraveContentRendererClient::SetRuntimeFeaturesDefaultsBeforeBlinkInitialization
since they don't have Chromium features:
* Digital Goods
* Native File System (File System Access)
- Added browser tests for these features
- Modified redirect-cc.py to allow overriding files under out/XXX/gen
- Added an override for blink::origin_trials::IsTrialValid and overrides
for blink::OriginTrialContext methods AddFeature and AddForceEnabledTrials
for trials:
* NativeFileSystem2
* SignedExchangeSubresourcePrefetch
* SubresourceWebBundles
- Added browser tests for trials disablement.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/af3597cb7e26db8909a4883bd528efb84c6d7ce2
commit af3597cb7e26db8909a4883bd528efb84c6d7ce2
Author: Clark DuVall <cduvall@chromium.org>
Date: Wed Apr 15 19:20:24 2020 +0000
Move ContentSettingsAgentImpl to //components/content_settings
This splits chrome-specific logic into
ChromeContentSettingsAgentDelegate, and moves common logic into
//components/content_settings. This will allow sharing the content
settings agent with WebLayer.
The unit test for WhitelistedSchemes was moved into the browser tests,
which means we no longer need a static version of
IsWhitelistedForContentSettings() just for testing.
Bug: 1065537
CONTENT_SETTING_DEFAULT means deleting the current content setting.
With DEFAULT, it always use global FP setting.
But we want DEFAULT as a standard FP blocking instead of fallback to
global settings. Use secondary pattern for marking setting as balanced mode.
Previously we used to spoof referrers for iframe and subresource
fetches and this has been causing some webcompat problems.
This PR removes this machinery, makes
'strict-origin-when-cross-origin' the default policy, prevents
this policy from downgrading and keeps referrer removal for
top-level navigations.
Serg