Chromium change:
https://source.chromium.org/chromium/chromium/src/+/c01e115c2633e007d23be7ecc69c092b1cc7a933
commit c01e115c2633e007d23be7ecc69c092b1cc7a933
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Thu Dec 10 15:51:48 2020 +0000
[Passwords] Replace Blacklist with Blocklist in PasswordStore and others
This change replaces usages of Blacklist with Blocklist in the
PasswordStore, LoginDatabase and fixes comments that were missed in
other places. Note that this change does not yet rename the actual SQL
columns in the Login Data database.
Bug: 1147799
Chromium changes:
https://chromium.googlesource.com/chromium/src.git/+/3bbb69a821f89abf22beab20b1eabc015a71d8ab
commit 3bbb69a821f89abf22beab20b1eabc015a71d8ab
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Tue Nov 3 06:59:57 2020 +0000
[Passwords] Remove autofill::PasswordForm from //chrome/*/importer
This change replaces most usage of autofill::PasswordForm in the
importer code and uses a new importer::ImportedPasswordForm struct
instead.
This is necessary, because PasswordForm is being moved to the //browser
component, and thus is no longer accessible from other components like
//common or //utility.
Bug: 1067347
https://chromium.googlesource.com/chromium/src.git/+/9c84018d43d95b8c7ca850653af9452b4edc895b
commit 9c84018d43d95b8c7ca850653af9452b4edc895b
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Tue Nov 3 09:57:10 2020 +0000
[Passwords] Move password_form.h to //components/password_manager
This change moves password_form.h and password_form.cc from
/autofill/core/common to /password_manager/core/browser and fixes
remaining compilation issues.
Bug: 1067347
Without this, will get build error like:
In file included from
/brave/src/brave/chromium_src/chrome/utility/services.cc:32:
../../brave/components/services/bat_ads/bat_ads_service_impl.h:13:10:
fatal error: 'bat/ads/ads.h' file not found
This means renaming uses of ServiceBinding to ServiceReceiver, as
well as removing any use of the old InterfaceRequest<T> type (e.g.
used by the ServiceRequest alias) and use PendinReceiver<T> instead.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/bb551f12072ebf7a9af6df26a51d125f90078453
commit bb551f12072ebf7a9af6df26a51d125f90078453
Author: Gyuyoung Kim <gyuyoung@igalia.com>
Date: Thu Jul 2 00:12:00 2020 +0000
Convert mojom::ServiceRequest to PendingReceiver<mojom::Service>
There are many uses of mojom::ServiceRequest. This CL migrates
them to PendingReceiver<mojom::Service>.
Besides that, ServiceBinding is renamed to ServiceReceiver and
the variable name is also changed from |binding_| to |receiver_|
or |service_binding_| to |service_receiver_|.
Bug: 955171
ChromeImporter runs in a separated service from upstream import service.
This new import service will use chrome::mojom::ProfileImportObserver and
brave::mojom::ProfileImportObserver and they are passed via
brave::mojom::ProfileImport.
brave::mojom::ProfileImportObserver and BraveImportBridge only define additional
interface.
With this warning dialog, user will close chrome windows.
After that user clicks continue button, browser will not check lock again aind
will try to import chrome's settings.
Even if chrome is still running, importing will be done because
importing is done with temporarily copied db files.
BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.
BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.
NOTE: this commits has many cleanup changes around importing area
that uses deprecated patching style.
fix https://github.com/brave/brave-browser/issues/7974
Chromium change:
https://chromium.googlesource.com/chromium/src/+/f070ffde7ce159aa8687e850b95c2a54f8caf5d3
commit f070ffde7ce159aa8687e850b95c2a54f8caf5d3
Author: Joshua Bell <jsbell@chromium.org>
Date: Tue Dec 10 19:44:51 2019 +0000
SQL: Disallow implicit integer downconversion on BindInt
Calling sql::Statement::BindInt() with an int64_t argument silently
downconverted, potentially saving incorrect data to a database.
sql::Statement::BindInt64(int64_t) should be used instead.
Introduce an uncallable sql::Statement::BindInt(int64_t) overload to
fail the compile. This also catches calling BindInt with uint32_t. Fix
up various callers that were silently downconverting.
Bug: 908690
Since the V11 cookies db schema, firstpartyonly column is renamed to samesite.
Also, BraveImporter and ChromeImporter should have different cookies query
string because muon uses old schema.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/0b653a39fe832ec8366948cc343f2b5a97ab57fa
commit 0b653a39fe832ec8366948cc343f2b5a97ab57fa
Author: Marc Treib <treib@chromium.org>
Date: Tue Sep 3 11:00:37 2019 +0000
Clear the account-scoped PasswordStore on signout
This adds an "is_account_store" flag to LoginDatabase, which specifies
whether this DB stores profile-scoped or Gaia-account-scoped data.
Sync uses this flag to clear the account-scoped data on signout.
In the future, the flag will also be used by the DB itself to "tag"
credentials it returns as coming from the account or from the profile.
Bug: 998455
https://chromium.googlesource.com/chromium/src/+/00380bfbde67971670a4e4afcaa513622905d8a5
commit 00380bfbde67971670a4e4afcaa513622905d8a5
Author: Marc Treib <treib@chromium.org>
Date: Wed Sep 4 08:04:37 2019 +0000
LoginDatabase: Use a strong alias for is_account_store param
With this change, callers have to write
new LoginDatabase(path, IsAccountStore(true))
instead of
new LoginDatabase(path, /*is_account_store=*/true)
which is clearer (no way to forget the comment), especially if any
other (boolean) parameters are added at any later point.
Bug: 998455
Passwords are no longer stored using native backend. Switch to importing
from LoginDatabase like on other platforms.
Chromium change:
commit 6811de35a39128fb354f238bce350f9a4a643e9d
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Thu Jul 25 22:26:26 2019 +0000
[PasswordManager] Stop Using Native Backends on Linux systems
Recent migrations moved all users who have been using the keying to the
LoginDatabase. This CL forces all users to using LoginDatabase
instead of native backends on Linux.
TBR=pcc@chromium.org
Change-Id: Ibac11e68d8f354ecf7f3c9828d95777ea5b3df60
Bug: 950269, 950267
- Packaged services have been removed and are now called builtin services.
Our services are no longer added via an overlay, but instead in the
GetExtraServiceManifests callback.
- The builtin services are marked as out-of-process, added the same
designation to our services in their manifests via the
ExecutionMode::kOutOfProcessBuiltin option.
-Removed service registration as it's no longer used.
Chromium changes:
commit 06fd283a53441cff85ce452e0de258a2a96d94aa
Author: Ken Rockot <rockot@google.com>
Date: Fri May 24 17:24:44 2019 +0000
Remove content_packaged_services
This removes content_packaged_services entirely, switching instead to a
direct delegate interface on Service Manager, allowing the Content
layer to directly field service process launching requests.
Follow-up CLs will further simplify in- and out-of-process service
configuration, and this is ultimately a step towards migrating process
launch out of Content and into Service Manager and removing other things
like content::ServiceManagerConnection.
Bug: 781334,895615
commit fa5d57115b51a77be5d8e5757a3758e0db51cf05
Author: Ken Rockot <rockot@google.com>
Date: Wed May 29 20:57:14 2019 +0000
Simplify out-of-process service registration
This eliminates the need to register out-of-process services at the
Content layer, separate from their manifests. Display names for service
processes are taken directly from the manifest now, including support
for string resource IDs resolved to localized strings by the Service
Manager at runtime.
Bug: 915806, 895615
base::JSONReader::ReadAndReturnError.
base::JSONReader changed signatue of Read to return Optional<Value>
instead of std::unique_ptr<Value>. ReadAndReturnError has been
deprecated and replaced with ReadAndReturnValueWithError that
returns a struct with error instead of having multiple out parameters.
Chromium chages:
commit 025edc25d8c8649d5a8dfd062e952855b3dfa13e
Author: Lei Zhang <thestig@chromium.org>
Date: Sat Feb 16 05:02:25 2019 +0000
Change base::JSONReader::Read()/ReadAndReturnError() to return Optional.
BUG=925165
commit 015397daa81409c43afbcd11ac41978cd7175cd0
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Feb 20 04:26:59 2019 +0000
Change base::JSONReader::ReadAndReturnError() to not use out params.
Instead of returning Optional<Value> and putting the error status in 4
out parameters, return struct ValueWithError which contains the value
and the error status.
Chromium's Service Manager no longer supports JSON manifests.
All JSON manifests and overlays need to be converted to C++.
See: https://bugs.chromium.org/p/chromium/issues/detail?id=895616
This change affects the following services:
- bat_ads
- bat_ledger
- tor_launcher
bridiver