- Moved address bar to bottom on NTP
- Moved menu and updated menu icons and texts
- Added request for relaunch when bottom navigation controls are enabled
- UI and visual improvements
Chromium change:
https://chromium.googlesource.com/chromium/src/+/088816e5c47905f8b4e16dd867cddaf24fb4f55f
[bookmarks] Modularize bookmarks browser code
Moved production bookmarks browser code to chrome/browser/bookmarks
directory. Made some small changes along the way to simplify the
process.
* Moved all production bookmarks browser code to module.
* Added a separate target for files that can be modularized now.
* Added a separate gni list for files that can't be modularized now
which is included in chrome_java directly. Over time I will refactor
those files so that they are moved into the main modularized target.
* Merged ReadingListUtils and BookmarkUtils. In the long run, browser
reading list code shouldn't really exist since the concepts are
merged at the native level.
* Moved one method from BookmarkUtils to BookmarkModel to allow for
more files to be modularized.
Eventually some files, particularly implementations of interfaces
defined in chrome/browser/bookmarks, will live in the unmodularized
directory.
Bug: 395908100
* Open settings to set default browser app from main menu
* Add conditions for app open count & dialog
* Remove notifications for set as default
* Add conditions for days timer
* Add changes to support < android 10 devices
* Add comments and refactor functions
* Add rewards 3.0 feature flag
* Add a function to check for rewards 3.0 flag
Update entry points for rewards with rewards 3.0 flag
* Add RewardsPageActivity/RewardsCustomTabRootUiCoordinator to show rewards 3.0 changes in custom tab
* Address rewards reset for rewards 3.0
* Add activity transition for rewards page
* Remove onBackPressed override
* Add close button to close the rewards panel as we have disabled back press
Update close button position on the page
* Add creator changes for rewards 3.0
Remove logs
Add null check
Remove changes for backpress
* Add changes for handling creators
Encode Url for creators
* Add open url native fucntion
* Add bubble in query params
* Add bytecode changes for BaseCustomTabActivity
Add native function to open url into rewards_page_ui
* Update copyright header year
* Update close icon for rewards page
Remove comments and refactor changes
* Address naming related changes
* Add test for bytecode changes
Resolve rebase error
* Update changes to use TabUtils open tab
* Remove close button
* Add FullScreenCustomTabActivity
Chromium now doesn't contain `Basic`/`Advanced`.
Class ClearBrowsingDataFragment now represents what used to be ClearBrowsingDataFragmentAdvanced.
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/a49153686134a72ff189024392df6aad09e71fb0
[Quick Delete] Clean up kQuickDeleteAndroidFollowup flag
Clean up Quick Delete phase 2 feature checks now that the experiment is
fully launched. This includes removing the obsolete tabbed layout and
basic tab from CBD on Android.
OBSOLETE_HISTOGRAM[History.ClearBrowsingData.UserDeletedFromTab]=No longer logged
Bug: 40255099
Change-Id: I340afa9692f17ad3b472f501522a9e6ff8fb061c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6162502
Related Chromium change
https://source.chromium.org/chromium/chromium/src/+/d223f2e8f4900df442947eb2303b356468625d6f
[Tab Model] Remove onTabModelSelected
Replace onTabModelSelected with observing getCurrentTabModelSupplier.
A previous CL removed most usages, but a few were leftover. This CL
completes the migration.
This change in observation style is beneficial as it avoids adding
TabModelSelectorObservers that get notified of various spammy onChange
updates and subsequently no-op all observer events except for tab model
selected which is the only action most observers cared about in the
first place.
Change-Id: I9a657404c65b8e6b182924656e264945b7ddb35e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165827
* Adds a settings to show SafeBrowsing errors under Developer options on Android
* Update browser/ui/android/strings/android_brave_strings.grd
Co-authored-by: Francois Marier <francois@brave.com>
* Fixes a header
---------
Co-authored-by: Francois Marier <francois@brave.com>
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/78b03df18d4625181de54bf6a7efa805c20b367d
Move base.cached_flags to components.cached_flags
We will need to depend on components/variations to support
fieldtrial_testing_config.json.
Since base can't use cached flags, and many clients of base won't
either, it makes more sense to put it in components.
Bug: 370797986
Upstream's logic in `AppLocaleUtils` for `getApplicationLocales` and `setApplicationLocales` is the same as it was in our patch, so we don't need it anymore.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/826aadf32e2ebec6a4086d97937f345ea5f3f912
Android: Adopt ServiceLoaderUtil for LanguageProfileDelegate
And upstreams & inlines the logic from LocaleManagerDelegate, which
existed only to work around Android T SDK not yet being available.
Also adds some @JniType annotations to LanguageBridge to simplify
changes there.
Bug: 40901855
fixes https://github.com/brave/brave-browser/issues/41402
Crash happened at app menu => Settings => Brave Shields & privacy => Content Filtering.
Tombstone
```
java.lang.ClassCastException: org.chromium.chrome.browser.settings.SettingsActivity cannot be cast to org.chromium.chrome.browser.settings.BraveSettingsActivity
at org.chromium.chrome.browser.shields.ContentFilteringFragment.onAttach(ContentFilteringFragment.java:86)
```
Upstream had added a new place to create Intent for Settings activity.
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d4af6a2c4ccc6427aa7df0f2beacf61793459e66
[Settings] Introduce a central place to construct intents
SettingsIntentUtil becomes the central place to construct intents
launching the settings activity.
Bug: b/356743945
Change-Id: Id6988af4a182fe6603bb02c9dae8b2ac48f80fed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5832868
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/52962da478ed750038f966c386c4ee0ff2d73837
Always apply luminance calculation to navigation bar icons
Currently, the navigation bar icons only respond to the color of the navigation bar during animations. Since animations are being disabled for the navbar coloring experiment, it's important that the luminance calculation to properly color the navigation bar icons is applied all the time, not just during animations.
Bug: 364228106, 40925025
It is not static now and have a new tracker arg.
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/828eb6d14543d75671991083fd162b3308bcadbe
[DefaultBrowser] Add helper for the role manager restriction
This CL adds a helper DefaultBrowserPromoUtils#shouldShowOtherPromo to
decide if other default browser promos can be shown.
The conditions mean to ensure that we only show other promo when the
role manager promo can't be shown either because of reaching the max
count or role manager not available in the current system.
It also adds the a feature engagement event to ensure the new promo
can only be shown if the role manager promo not shown in the 7 days
window.
Bug: 364906215
Change-Id: If5684ee24ff87d193939dd9b8c6ae6d2a8af783c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5839024
This code has been made `android` only in chromium upstream. This change
includes these headers to brave main line build, so it can be used by
brave news.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/2e9d2aeb39e1523215a156a26319e5c6a8316def
commit 2e9d2aeb39e1523215a156a26319e5c6a8316def
Author: Erik Chen <erikchen@chromium.org>
Date: Wed Jul 31 20:36:53 2024 +0000
Remove enable_feed_v2 gn arg.
This gn arg is always true on android and always false on desktop. Its
presence complicates gn files without adding value.
Change-Id: I3072ca781d18b75979a361f0eeedcea532184bac
Bug: 353628440
AlexeyBarabash