It was a name overlapping with the one from
`obj/third_party/androidx/androidx_credentials_credentials_java/res/drawable/ic_password.xml`
Chromium change probably:
https://source.chromium.org/chromium/chromium/src/+/dc70a40afac9726a01aa7c5330e0c51c2dc58a4b
[DC] Move the DigitalCredentialsCreationDelegateImpl to the public code
The androidx library has been released to the public and hence no need
to keep it in the internal code.
This CL is introducing minor behavioral changes limited to Null checks.
The diff between the version in the internal code and this one is in
http://go/webdiff#key=iVg4KJsYe0Gu
Follow-up CLs will remove the internal pieces.
Bug: 415967212
Change-Id: Ief2df4b1654d9d2ea54506d9c846ea02dbbe0597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6523383
* Tweak background video playback description in flag page
* Remove redundant call to allow Javascript injection
The method `content::RenderFrameHost::AllowInjectingJavaScript()` is already called in
`background_video_playback_tab_helper` for those domains that correctly have a match so
it's not needed in `brave_browser_main_parts`.
* Fix boolean logic
* Make `IsBackgroundVideoPlaybackEnabled` method more readable
* Remove unneeded predefined default value from XML
* Refactor logic and remove old code
* Enable background video playback preference by default
* Remove unused constant
* [Android] New Mobile Bookmarks homepage setting
* [Android] Mobile bookmarks string correction
* [Android] Code review suggestions
* Replaces direct patch with bytecode and adds eol
* Moves test method from dummy to the main class
* Direct patch xmls and typo fix
* BaseJUnit4ClassRunner to ChromeJUnit4ClassRunner for tests
* Fixes presubmit issues for tests
* Move java classes into brave/browser for quick_search_engines
* Move serach_engines resources to brave/browser/search_engines
* Add translations files for search_engines android string
* Add dimens
Add a function to load favicons
* Add close menu id for quick search
* Add missing deps
* Move quick search engines changes to brave/browser/quick_search_engines
* Remove comments for BUILD.gn
Related Chromium changes:
https://source.chromium.org/chromium/chromium/src/+/f8de93495c1d5e041d25dfd02d60f03ff1fabeed
[Android TRM] Remove R.id.tab_resumption_module_container_stub.
In crrev.com/c/5297855, the Tab Resumption Module was integrated into
the Magic Stack. Therefore it no longer needs the ViewStub
R.id.tab_resumption_module_container_stub as the top level layout, but
it still lingers. This CL deletes the now useless ViewStub.
Bug: 1515325
Change-Id: I358b64ef57c267629230578cf8dc5b28af3d7dfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5734353https://source.chromium.org/chromium/chromium/src/+/28cde898edae21f1b807d3e0e43d62701837ac7a
[Android TRM] Remove feature and most of the code.
This CL removes the Android Tab Resumption Module:
* Remove chrome/browser/tab_resumption.
* Remove flags and configs.
* Remove 5 UI strings: IDS_TAB_RESUMPTION_MODULE_*,
IDS_N_{MINUTES,HOURS}_AGO_NARROW.
* Remove resources.
Need to keep for metrics:
* tools/metrics/histograms/enums.xml entry.
Out of scope of this CL; TODO in follow-ups:
* NTP Customization features and tests involving the TRM (will remove in
follow-up).
* Keep IDS_TAB_RESUMPTION_MODULE_SEE_MORE "See more": This got reused by
Tab Switcher.
* Keep IDS_HOME_MODULES_TAB_RESUMPTION_TITLE "Continue with this tab" /
"Continue with these tabs": Used by Single Tab Module.
Unaffected:
* TRM still exists on Desktop and iOS. Tab data sync from Android
continue to work same as before.
Bug: 400479323, 400479745
Change-Id: I38cc101c361c761d38dff931b7ab6d15960836fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6408054
FirstRunFlowSequencer.onFlowIsKnown() argument is changed from bundle to boolean
down_arrow drawable was used at
//chrome/browser/ui/android/signin/java/res/layout/signin_view.xml
and now is also removed
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/aae9d74edf5532ed12952d4961a7ee20c3c6b092
[Android] Remove SyncConsent fragments and activity
This cl removes the following classes:
- SyncConsentFragmentBase
- SyncConsentFragment
- SyncConsentFirstRunFragment
- SyncConsentActivity
- All xml resources related to these classes
FirstRunFlowSequencer.onFlowIsKnown() argument is changed from bundle
to boolean.
Bug: 350461111
Change-Id: If1ad68f40e98f843d42f1b3903878c22af6ed2cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6169618
* Add support for diferent variants
* Remove omnibox highlight which shows up right after onboarding
* Add different variants function
* Add search widget promo on NTP
* Add notification permission changes
* Update widget promo UI
* Update wdp check
Resolve presubmit issue
- Moved address bar to bottom on NTP
- Moved menu and updated menu icons and texts
- Added request for relaunch when bottom navigation controls are enabled
- UI and visual improvements
* Add an option to allow users to take screenshots in private mode
* Update strings for settings option and format code
* Update title/description for private tab screenshot option
* Open settings to set default browser app from main menu
* Add conditions for app open count & dialog
* Remove notifications for set as default
* Add conditions for days timer
* Add changes to support < android 10 devices
* Add comments and refactor functions
* Add rewards 3.0 feature flag
* Add a function to check for rewards 3.0 flag
Update entry points for rewards with rewards 3.0 flag
* Add RewardsPageActivity/RewardsCustomTabRootUiCoordinator to show rewards 3.0 changes in custom tab
* Address rewards reset for rewards 3.0
* Add activity transition for rewards page
* Remove onBackPressed override
* Add close button to close the rewards panel as we have disabled back press
Update close button position on the page
* Add creator changes for rewards 3.0
Remove logs
Add null check
Remove changes for backpress
* Add changes for handling creators
Encode Url for creators
* Add open url native fucntion
* Add bubble in query params
* Add bytecode changes for BaseCustomTabActivity
Add native function to open url into rewards_page_ui
* Update copyright header year
* Update close icon for rewards page
Remove comments and refactor changes
* Address naming related changes
* Add test for bytecode changes
Resolve rebase error
* Update changes to use TabUtils open tab
* Remove close button
* Add FullScreenCustomTabActivity
Chromium change:
https://chromium.googlesource.com/chromium/src/+/18371dfa10268ba754ca5cbd75beda9038f82503
[omnibox] Rename Android secure state icons to reflect their function.
The omnibox secure state indicator was refreshed last year to show a page info icon instead of a lock icon. As of https://crrev.com/c/5982459, the refreshed state became the only state for the omnibox indicator but the icon was still named "refresh" and the old lock icon was still in use in other surfaces.
This CL changes the icon names to "page_info" and "lock" to clearly distinguish them.
Change-Id: Ic7175efccbed0dbbd1523827873b26c4209b4e67
* Adds a settings to show SafeBrowsing errors under Developer options on Android
* Update browser/ui/android/strings/android_brave_strings.grd
Co-authored-by: Francois Marier <francois@brave.com>
* Fixes a header
---------
Co-authored-by: Francois Marier <francois@brave.com>
Serg