Commit Graph
8 Commits
Author SHA1 Message Date
vadims ac92cda1c1 Improve test coverage for HTTPS upgrade exception matching (#33765)
Covered with tests the HTTPS upgrade exceptions logic, updated comments
with logic information.

Resolves: https://github.com/brave/brave-browser/issues/49186
---------

Signed-off-by: Vadym Struts <vstruts@brave.com>
2026-02-27 16:08:06 +01:00
Brian Johnson 85d24ea01e Fix loading of https exception service (#32448)
The existing code only lazy loaded the service when the feature was disabled, now it makes the necessary checks in the methods.
2025-11-21 17:21:01 -08:00
Claudio DeSouza 51604f40d0 [cr143] Several GURL methods returning string_view
This migration has been effected in upstream, but several places in our
codebase got broken by this transition. This change makes several parts
of our codebase more friendly to passing `string_view`.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/0e1784e3cf990560b173f40338e582f50aba0e85

commit 0e1784e3cf990560b173f40338e582f50aba0e85
Author: Charlie Harrison <csharrison@chromium.org>
Date:   Fri Oct 3 11:04:26 2025 -0700

    RELAND: Migrate GURL::path() and friends to return string_view

    This relands crrev.com/c/7003625. Missing cases were found by staring
    at the output of `git grep` for the whole codebase.

    Origin description:
    Also migrates some last remaining callers of the std::string APIs.
    This completes phase 1 of crbug.com/448174617.

    Bug: 448174617
    Change-Id: I7f24f81d1fbf129d8b0dd94f4cf948626deab933
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7007010
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Charlie Harrison <csharrison@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1524878}
2025-11-18 11:18:41 -05:00
cdesouza-chromium 4ffbda2340 [CodeHealth] Apply performance-move-const-arg (#26497)
This check has detected a few places where the use of `std::move` has
been completely misleading. In one of them we are potentially incurring
in a bug, as we are moving a shared callback that is being used in a
loop.

https://clang.llvm.org/extra/clang-tidy/checks/performance/move-const-arg.html

Resolves https://github.com/brave/brave-browser/issues/42230
2024-11-12 12:08:03 -05:00
Brian Johnson 46f1c77b4c Deprecate old patterns for component installers (#25206)
Deprecate old patterns for component installers
2024-08-19 17:40:29 -07:00
Claudio DeSouza be214871df Remove uses of StringPiece and its variants
Upstream is set to deprecated, and delete all occurrences of
`base::StringPiece`, and replace it with `std::string_view`, and
according correspondent types.

This change removes the use of `base::StringPiece`, and of the headers
as well across the Brave codebase.
2023-09-22 16:26:38 +03:00
Arthur Edelstein fdf93a5f3f don't upgrade to https before exceptions list is loaded (#17111) 2023-02-08 20:24:32 -08:00
Arthur Edelstein 98b811e1ae HTTPS by default for Desktop (#16521)
HTTPS by default on Desktop

- Disabled, Standard, Strict modes
- Controlled by global and per-site shields settings
- Merge UI with HTTPS-Only Mode
- Behind HttpsByDefault feature flag
- Browser tests for each setting
2023-02-08 07:00:54 -05:00