Relocate the WASM workspace from ui/webui/resources/wasm/ to
third_party/wasm/, following the convention of third_party/rust/.
This is a plain move with path updates — no structural changes to
the workspace, crate locations within it, or build targets.
This fixes an issue for some people where update_patches generates conflicting diffs with what is in the repo. This standardizes the diff algorithm for mm files so it should be the same for everyone
Overlaying upstream's chromeos IDs range alone doesn't work any more and
pushes IDs above the 2^16-1 range.
This change adds a pre-processing step to upstream's
"default_resource_ids" action in //tools/gritsettings/BUILD.gn. The
pre-processing filters out all items in
tools/gritsettings/resource_ids.spec that have chromeos, ash, or glic in
the path. This reduces the ID range taken by the upstream down to,
currently, under 51,000. With Brave IDs moved to start at 53,000, they
now end under 59,000.
Moves the IDL file into chromium_src, patches BUILD.gn to use
chromium_src override. IDL output rebuilt at `./src` directory
using `python3 ./tools/win/update_idl.py`
Using https://github.com/brave/brave-core/pull/109 as a guide
Also includes `.gitattributes` fix which prevents differences found
w/ filecmp.cmpfiles in MIDL compilation.
We should have git configured with core.autocrlf = false on Windows
which will allow .gitattributes to control how files are checked out and
added. Chromium seems to be using this approach as well.
Copied from src/.gitattributes and removed unneeded lines.
Added:
*.css
*.icon
*.patch
*.ts
*.tsx
*.xtb
Added CRLF files:
win_build_output/midl/google_update/*/*.c text eol=crlf
win_build_output/midl/google_update/*/*.h text eol=crlf
test/data/tor/tor_control/*_win/controlport text eol=crlf
This is prompted by CI failing on cr93 branch while parsing an idl
file on Windows after applying our patch that is checked out with
CRLF:
C:/brave-browser/src/brave/vendor/depot_tools/bootstrap-2@3_8_10_chromium_20_bin/python3/bin/python3.exe ../../tools/json_schema_compiler/compiler.py ../../chrome/common/extensions/api/developer_private.idl --root=../../ --destdir=gen --namespace=extensions::api::%(namespace)s --generator=cpp --include-rules=extensions/common/api:extensions::api::%(namespace)s
../../chrome\common\extensions\api\developer_private.idl(235) : Unexpected EoF reached after
boolean isSplitMode;
^
'canning error. Illegal character '
Traceback (most recent call last):
File "../../tools/json_schema_compiler/compiler.py", line 211, in <module>
result = GenerateSchema(opts.generator, file_paths, opts.root, opts.destdir,
File "../../tools/json_schema_compiler/compiler.py", line 98, in GenerateSchema
type_generator = CppTypeGenerator(api_model,
File "C:\bb3\brave-browser\src\tools\json_schema_compiler\cpp_type_generator.py", line 35, in __init__
self._default_namespace = list(model.namespaces.values())[0]
IndexError: list index out of range
Anthony Tseng