Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
68,814 Commits 1 Branch 0 Tags
4b64817c2d11dda85e1fa71af2fac19dc771c2da
Commit Graph
4913 Commits
Author SHA1 Message Date
AlexeyBarabash 2b0ccf3e13 [cr136][Android] New reloadButtonCoordinator arg TopToolbarCoordinator.ctor 
reloadButtonCoordinator - component that encapsulates interactions with a reload button. It only presents on tablet

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/59fc77b83719670de5f45e057834add82fdbdb9d

	[Reload Button] Extract animations into MVC

	This CL extracts fade animation logic from location bar
	and moves it into the ReloadButtonCoordinator. This way
	model accurately represents the state of the view.

	Passing ReloadButtonCoordinator to ToolbarTablet is required
	because TopToolbarCoordinator doesn't have coordinators for
	other buttons yet, hence controlling animations in it is not
	possible.

	Bug: 402347979
	Change-Id: Ic80ec34ef27e6e426c274f5d9615c74aff7d4523
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6357763
 2025-04-16 09:30:26 +01:00
AlexeyBarabash e8477779c8 [cr136][Android] Changed signature for inner class ContentSettingsResources$ResourceItem.ctor 
New args are:
- iconBlocked;
- enabledPrimaryText;
- disabledPrimaryText.

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/f3a7cf3e829c9b418af31f404ee45b8916f955b2

	[Site Settings] Update radio button primary texts

	This CL changed primary text for the radio buttons and added missing
	description for FILE_EDITING.

	UI design: go/site-settings-ui-design

	Binary-Size: Size increase is unavoidable. (Introduced a bench of new text strings for site settings, will remove the old one after feature launched)
	Bug: 41494473
	Change-Id: I499efea57df107f68cd29ffade267a259073cb08
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6329624
 2025-04-16 09:30:25 +01:00
AlexeyBarabash 507ded849b [cr136][Android] Upstream rolled new libs conflicting with Brave 
These libs:
- transport-backend-cct
- transport-runtime
- firebase-encoders-proto
were added to Chromium.

Build as-is caused obvious errors like

Type com.google.android.datatransport.backend.cct.BuildConfig is defined multiple times:
obj/third_party/android_deps/google_android_datatransport_transport_backend_cct_java__classes.dex.jar:classes.dex,
obj/brave/third_party/android_deps/com_google_android_datatransport_transport_backend_cct_java__classes.dex.jar:classes.dex

Removed libs from Brave repository in a favour of Chromium's.

The libs transport-backend-cct and transport-runtime now have newer versions:

was at Brave                          	now at Chromium
-----------------------------------+------------------------------------
transport-backend-cct-3.1.9.aar    | transport-backend-cct-4.0.0.aar
transport-runtime-3.1.9.aar        | transport-runtime-4.0.0.aar
firebase-encoders-proto-16.0.0.jar | firebase-encoders-proto-16.0.0.jar

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/c831169ac493f309ae18a87b8b2664a8645ca03f

	Reland "Android: Roll Play Services & Firebase libraries"

	This reverts commit 0b505caeef89375d7968d5a8ecb2b6cf1f8b3e08.

	Reason for reland: Disabled test

	Original change's description:
	> Revert "Android: Roll Play Services & Firebase libraries"
	>
	> This reverts commit 8a74cfbd255229e08dc62e9902acce757838718f.
	>
	> Reason for revert:
	> LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5973291891163136
	>
	> Sample build with failed test: https://ci.chromium.org/b/8721019037836053169
	> Affected test(s):
	> [ninja://chrome/test:android_browsertests/OfferNotificationControllerAndroidBrowserTestForMessagesUi.MessageShown](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:android_browsertests%2FOfferNotificationControllerAndroidBrowserTestForMessagesUi.MessageShown?q=VHash%3A6328d82a7531181f)
	>
	> If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5973291891163136&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6331243&type=BUG
	>
	> Original change's description:
	> > Android: Roll Play Services & Firebase libraries
	> >
	> > No-Try due to flakes.
	> >
	> > Binary-Size: Internal size unaffected.
	> > No-Try: true
	> > Bug: 40219991
	> > Change-Id: I1036dea23368a3465370d54294fd8b947dc50806
	> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6331243
	> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
	> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
	> > Owners-Override: Andrew Grieve <agrieve@chromium.org>
	> > Cr-Commit-Position: refs/heads/main@{#1429706}
	> >
	>
	> Bug: 40219991
	> No-Presubmit: true
	> No-Tree-Checks: true
	> No-Try: true
	> Change-Id: I6f3fff9309854031aa147d628b77060631b07036
	> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6337362
	> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
	> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
	> Owners-Override: Andrew Grieve <agrieve@chromium.org>
	> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
	> Cr-Commit-Position: refs/heads/main@{#1429842}

	Binary-Size: Internal size unaffected.
	Bug: 40219991, 402163619
	Change-Id: Ifcf51bd4e130665ffbb1fac92bf4a93661c0d9de
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6340607
 2025-04-16 09:30:24 +01:00
AlexeyBarabash c8368ca4ca [cr136][Android] New priceDropNotificationManager arg at bookmark related methods 
- BraveBookmarkManagerCoordinator.ctor;
- BookmarkManagerMediator.ctor;
- BookmarkUtils.addOrEditBookmark.

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/cf3a7a258cecf2a1b99b91c68198e79947fb0f50

	[bookmarks] Plumb PriceDropNotificationmanager through as a DEP

	Bug: 395908100
	Change-Id: I52dc928de628fca742f988d084c058b7fe58884b
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6336456
 2025-04-16 09:30:24 +01:00
AlexeyBarabash e60d279473 [cr136][Android] Adjusted BravePrivacySettingsTest as Phone-as-a-Security-Key was removed 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/284f46a02e5f4e76f0011f030a89dd7706852a9a

	Delete Android Phone-as-a-Security-Key settings fragment

	It was disabled since M133 as this functionality is now provided by
	GmsCore.

	Fixed: 377475533
	Change-Id: If804dbc47e8f9683c54c23c9e6c7a2652f867e8d
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6323023
 2025-04-16 09:30:23 +01:00
AlexeyBarabash 71594edc9e [cr136][Android] New openInBrowserRunnable arg at BaseCustomTabRootUiCoordinator.ctor 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d25e13535f220bff71bcfe80380ec601166cca19

	[mtb-cct] Add 'Open in browser' action button

	A new ButtonDataProvider for the action 'Open in browser' feature
	that opens the current custom tab in BrApp. The radio button to
	manually set this option is also added to Setting 'Toolbar Shortcut'.

	Bug: 394103836
	Change-Id: I994cc50cb721614500a1dd8b7b39766138e32d04
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6307283
 2025-04-16 09:30:22 +01:00
AlexeyBarabash 290d8493e4 [cr136][Android] SyncConsent fragments and activity were removed 
FirstRunFlowSequencer.onFlowIsKnown() argument is changed from bundle to boolean

down_arrow drawable was used at
//chrome/browser/ui/android/signin/java/res/layout/signin_view.xml
and now is also removed

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/aae9d74edf5532ed12952d4961a7ee20c3c6b092

	[Android] Remove SyncConsent fragments and activity

	This cl removes the following classes:
	- SyncConsentFragmentBase
	- SyncConsentFragment
	- SyncConsentFirstRunFragment
	- SyncConsentActivity
	- All xml resources related to these classes

	FirstRunFlowSequencer.onFlowIsKnown() argument is changed from bundle
	to boolean.

	Bug: 350461111
	Change-Id: If1ad68f40e98f843d42f1b3903878c22af6ed2cb
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6169618
 2025-04-16 09:30:22 +01:00
AlexeyBarabash e45553cfc7 [cr136][Android] New bookmarkManagerOpener arg at some methods 
Affected:
- BookmarkManagerCoordinator ctor
- BookmarkManagerMediator.ctor
- BookmarkToolbarCoordinator.ctor
- BookmarkUtils.addOrEditBookmark

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/26a0184c4164dddd38d0145a846c513dd740bead

	[bookmarks] Extract more activity-launching functions to opener class

	Bug: 395908100
	Change-Id: If8a28925f8b1365822c35d43e4ddcd6afc364ee1
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6291735
 2025-04-16 09:30:22 +01:00
AlexeyBarabash 512ab6a6c3 [cr136][Android] BookmarkManagerCoordinator ctor signature was changed 
bookmarkManagerOpener instead of openBookmarkComponentName

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/26a0184c4164dddd38d0145a846c513dd740bead

	[bookmarks] Extract more activity-launching functions to opener class

	Bug: 395908100
	Change-Id: If8a28925f8b1365822c35d43e4ddcd6afc364ee1
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6291735
 2025-04-16 09:30:22 +01:00
Deep Pandya 84d545f648 Resolve BraveBookmarkActivity crash (#28616) 2025-04-14 10:16:58 -04:00
Deep Pandya 2cfff090f4 Update changes for always on to auto reconnect (#28615) 
* Update changes for always on to auto reconnect

* ADd quotes to hightlight Block connections without VPN
 2025-04-13 23:16:06 +02:00
Deep Pandya 9ab567c852 Resolve encoding issue (#28622) 2025-04-12 02:26:48 +02:00
Simone Arpe f369bb2e44 Retrieve profile using dependency injection in Wallet settings (#28608) 
Retrieve profile using dependency injection rather than static method
 2025-04-11 16:24:15 +02:00
Aleksei Khoroshilov 4bc5f98325 Fix xml license check (#28575) 
* Fix xml license header check.

* Format.

* Update some license headers to match the required format.
 2025-04-10 12:34:45 +07:00
Deep Pandya 59c1151ac1 Remove request to relaunch app for stats and top sites (#28571) 2025-04-08 22:12:05 -04:00
Deep Pandya 5b8422fd8c Resolve custom tab activity hidden bottom bar issue (#28549) 
* Resolve custom tab activity issue which hides bottom toolbar

* Only show bottom controls when bottom toolbar is enabled

Refactor activity finish

* override finish to make sure of activity closure
 2025-04-08 20:53:24 -04:00
Deep Pandya bcb8a0a129 [Android] Yahoo phase 2 (#28494) 
* Add changes to change DSE to yahoo

* Add pref for DSE change migration

* Update yahoo jp keyword

Remove log

* Update conditions for the phase 2 check
 2025-04-07 21:07:18 -04:00
Deep Pandya 2b756daa09 Android onboarding variants (#28426) 
* Add support for diferent variants

* Remove omnibox highlight which shows up right after onboarding

* Add different variants function

* Add search widget promo on NTP

* Add notification permission changes

* Update widget promo UI

* Update wdp check

Resolve presubmit issue
 2025-04-03 10:52:03 -04:00
Artem Samoilenko 0898ccd2dc [Android] Prsubmit issue fix 2025-04-02 16:05:59 -04:00
Artem Samoilenko 656c1f4355 [Android] Fix for menu position in overview mode 2025-04-02 15:56:40 -04:00
Deep Pandya 9fd91d3235 Add notification permission for rewards 3.0 (#28453) 
Limit ask for the permission to 3 times
 2025-04-02 03:58:43 +02:00
Serg 1415725462 An attempt to fix a crash on template_url_service pointer access on Android (#28448) 
* An attempt to fix a crash on template_url_service pointer access on Android
 2025-04-01 21:54:34 -04:00
AlexeyBarabash 94b880c97f Revert 'Disable refresh of Brave Leo at the panel #21117' (#28369) 
Revert 'Disable refresh of Brave Leo at the panel #21117'; fixes brave/brave-browser#45026
 2025-04-01 18:39:15 +03:00
Deep Pandya 0035b7d0f4 Change yahoo search jp position in QSE (#28427) 
* Change yahoo search jp position

* Resolve presubmit error
 2025-04-01 11:28:25 -04:00
Kamil Jozwiak 78a1dcce95 Merge pull request #28416 from brave/maxk-1.77.x-release-l10n-master 
Updated l10n for 1.77.x release (lowered to master).
 2025-03-31 22:30:23 -04:00
Kamil Jozwiak add3eacccb Merge pull request #28371 from brave/maxk-1.77.x-release-l10n 
Updated l10n for 1.77.x release.
 2025-03-31 17:02:18 -04:00
Artem Samoilenko 2e7944d3e9 [Android] Update colors for Address bar setting and empty state icons 2025-03-31 14:39:09 -04:00
Deep Pandya 2ad51c8065 Remove chrome widgets (#27724) 
* Remove chrome widgets

Add bytecode changes for quick action search widget

* Add patch to remove chrome widgets from manifest

* Add bytecode tests for method exists

* Update AndroidManifest patch

* Add lint suppression for R.drawable.hairline_border

* Update Bytecode test

* Add classes to apk_for_test

* Add QuickActionSearchWidgetProviderDino test flag

Add QuickActionSearchWidgetProviderSearch test flag
 2025-03-31 18:34:40 +02:00
Deep Pandya 5f0b8bbe5d Change yahoo search JP position to top (#28402) 2025-03-31 18:29:58 +02:00
Deep Pandya 35c1670b5f Add DSE check for yahoo JP (#28376) 
* Add DSE check for yahoo JP

* Remove logs

* Add deps for prefs
 2025-03-31 03:46:00 -04:00
Deep Pandya f521eb37d2 Fix the CustomTabActivity freezing issue caused by touch events (#28374) 
* Fix the CustomTabActivity freezing issue caused by touch events being blocked during the enter animation.

* Add supression for unused variable
 2025-03-28 21:54:21 -04:00
Artem Samoilenko 58b5cece04 [Android] Update file names for icons to match Figma 2025-03-27 14:16:28 -04:00
Artem Samoilenko d0a6a9a06e [Android] Update icon names to match Figma 2025-03-27 13:10:04 -04:00
Artem Samoilenko 760174f5e7 [Android] If statement optimization (code review suggestion) 2025-03-27 09:11:24 -04:00
Artem Samoilenko 152d7a4103 [Android] Additional improvements for bottom address bar 
- Moved address bar to bottom on NTP
- Moved menu and updated menu icons and texts
- Added request for relaunch when bottom navigation controls are enabled
- UI and visual improvements
 2025-03-27 09:11:22 -04:00
AlexeyBarabash 71c38d5249 Fixed BraveManageSyncSettingsTest Android tests (#28335) 
Fixed BraveManageSyncSettingsTest Android tests 

fixes brave/brave-browser#43285
 2025-03-27 13:22:32 +02:00
AlexeyBarabash ff83351b09 Changed presubmit rules severity to error for more rules (p3) (#26924) 
Changed presubmit rules severity to error for:
- AvoidStarImport;
- ModifierOrder;
- RedundantImport;
- PackageName;
- SimplifyBooleanExpression;
- SimplifyBooleanReturn;
- TypeName;
- ConstantName.
 2025-03-25 16:57:47 +02:00
Jay Harris d8e73170c8 [Omnibox]: Hide OnDeviceHeadProvider suggestions when top suggestion are disabled (#28094) 
* [Omnibox]: Hide OnDeviceHeadProvider suggestions when top suggestions are disabled

* Setup OnDeviceHeadModel
 2025-03-24 09:33:38 +01:00
Terry Mancey f1545f26f0 [ads] NTT metric reporting (#28080) 
* [ads] Report new tab page ad metrics via confirmation with an optional fallback to P3A

* [ads] Always serve new tab page ads through the component

* [ads] Do not frequency cap last served new tab page ad

* [ads] Deprecate redundant conditon matcher code

* [ads] Transition to v4 confirmation endpoint

* [ads] Include firstTime in the confirmation payload if it is the first impression for the campaign

* [ads] Deprecate HTTP_IM_A_TEAPOT

* [ads] Do not load unnecessary resources

* [ads] Migrate P3A opted-in status

* [ads] Deprecate AdInfoMatchesSponsoredImage

* [ads] Add ad events to brave://ads-internals

* [ads] Optimize firstTime database query

* [ads] Purge ad events when opting out

* [ads] Add grace period

* [ads] General code health

* [ads] Purge Brave News ads for all users when opting out
 2025-03-21 17:01:23 +01:00
Deep Pandya 86e6934b52 Remove search engine onboarding (#28230) 
* Remove search engine onboarding

* Remove onUrlFocusChange callback
 2025-03-21 00:15:47 -04:00
Deep Pandya 637c20608e Add an option to remove Leo from quick search engine bar (#28229) 2025-03-20 14:29:57 -04:00
Max Karolinskiy 0bdf57bb1c Merge pull request #28208 from brave/cr135.x 
Upgrade from Chromium 135.0.7049.17 to Chromium 135.0.7049.26
 2025-03-20 10:24:05 -04:00
Deep Pandya c6cad964b8 Resolve search engine onboarding selection (#28206) 
* Resolve search engine onboarding selection

* Resolve presubmit issue
 2025-03-20 08:16:25 +01:00
AlexeyBarabash ad504cefe0 [cr136][Android] New arg at ChromeDialog.ctor - shouldPadForWindowInsets 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/1ba995f4717a3293bb336a6869d4b6e7ec4cc292

	[E2E] Wraps ChromeDialog with EdgeToEdgeBaseLayout

	Wraps ChromeDialog with EdgeToEdgeBaseLayout so that ChromeDialog has
	the correct padding for the status bar.

	Before:
	http://screencast/cast/NDU3MDg1MTAyNTM1NDc1MnwwN2M2ODVlYS1iNA

	After:
	http://screencast/cast/NTY4MjM0NTgxMzIxMzE4NHw0MzhmOWIxYi03Nw
	http://screencast/cast/NTkzODc2MjI3Mjk5NzM3Nnw5MzMzZGMzMi00Ng

	Bug: 399276320
	Change-Id: I37db9102a2a07f5416ffbd37549565bc127de8f2
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6336801
 2025-03-19 18:08:45 -04:00
AlexeyBarabash 498a827e46 Fixed Tabs menu position for some languages (#27982) 
* Fixed Tabs menu position for some languages; fixes brave/brave-browser#44274

* Test for main preferences order on Android
 2025-03-19 20:52:30 +02:00
Simone Arpe ca2dd2319d Modify Chromium files to fix PIP behavior (#27849) 2025-03-19 19:46:21 +01:00
Artem Samoilenko 66c943d90a [Android] Move BraveUrlConstants out of embedder_support component 
`BraveUrlConstants` does not extend anything and thus does not belong to `embedder_support` component.
 2025-03-18 20:02:25 -04:00
Artem Samoilenko eaf84bbfbf [Android] Remove unused bytecode tests 2025-03-18 20:02:22 -04:00
Artem Samoilenko 3a8d19a428 [Android] New c-tor signature for StatusBarColorController 
Chromium change:
https://chromium.googlesource.com/chromium/src/+/6b88305d9871a487e87b7eb9991f5fbe36940d85

[TSLO] Fix status bar coloration in desktop windowing mode

The status bar currently always uses the default tab strip background
color on a tablet when the strip is visible irrespective of the focus
state of the activity window. The strip background color changes from
the default for an unfocused desktop window and if the status bar is
contiguous with an unfocused desktop window, it incorrectly still uses
the default color that is applied only to a focused tab strip.

This CL makes an update to ensure that the status bar uses the same
color applied to the tab strip, which can be impacted by the activity
focus state.

Before:
https://screenshot.googleplex.com/9uKWnPUYcouZFSm
After:
https://screenshot.googleplex.com/AQVoLoAkvwqVvQG

Bug: 393443576
 2025-03-18 20:02:19 -04:00
Artem Samoilenko 37134ad086 [Android] Rename appearance settings resource 
Chromium change:
https://chromium.googlesource.com/chromium/src/+/791fd6f95c875db2e132bee7f831563c690fe001

Add "Theme" settings menu option to new "Appearance" settings page.

This CL adds the "Theme" settings menu option to the new "Appearance"
settings page. In a follow up CL, a pref summary will be added as well.

Design: http://shortn/_oxzSbwNuTe

NO_IFTTT=New check

Bug: 397775252
 2025-03-18 20:02:15 -04:00