The NavigatorPluginsFixed feature is now unconditionally enabled, so
we need to add some extra code to make sure that we always rely on
Brave's farbling mechanism, instead of returning upstream's fixed
plugins data.
Chromium change:
https://github.com/chromium/chromium/commit/c2abba012946a341b479821594eccaf45c893b3f
commit c2abba012946a341b479821594eccaf45c893b3f
Author: Mason Freed <masonf@chromium.org>
Date: Tue Nov 16 00:38:55 2021 +0000
Remove the NavigatorPluginsFixed feature flag
This feature shipped successfully in M94, with no reported bugs.
As such, this CL removes the feature flags. Note that the various
uses of |should_return_fixed_plugin_data_| need to stay, as they
are still used to re-enable the dynamic plugin lists for apps,
which is controlled via:
GetSettings()->GetAllowNonEmptyNavigatorPlugins()
until at least June, 2022.
Bug: 1171373,1164635
This is useful for local servers especially like Ganache when it is reset
Note that I acknowledge that it would be nicer to be able to clear per
network, but that can be done in a future task based on demand.
This lowers 1.34.x l10n update for 1.33.x release. This change removes
the original commit's changes to upstream localization files because
1.34.x has Cr96 and this commit is intended for Cr97.
Fixesbrave/brave-browser#20029
From cr97 on, having this feature enabled means that the browser will
attempt to reach the Optimization Guide Server every now and then at
the https://optimizationguide-pa.googleapis.com endpoint, as it was
detected by the npm run network-audit command:
[:ERROR:brave_network_audit_browsertest.cc(151)] NETWORK AUDIT FAIL:https://optimizationguide-pa.googleapis.com/v1:GetModels?key=dummytoken
[:ERROR:brave_network_audit_browsertest.cc(151)] NETWORK AUDIT FAIL:https://optimizationguide-pa.googleapis.com/v1:GetModels?key=dummytoken
[...]
[:ERROR:brave_network_audit_browsertest.cc(151)] NETWORK AUDIT FAIL:https://optimizationguide-pa.googleapis.com/v1:GetModels?key=dummytoken
../../brave/browser/net/brave_network_audit_browsertest.cc:249: Failure
Value of: PerformNetworkAuditProcess(events)
Actual: false
Expected: true
network-audit FAILED. Import /home/mario/work/brave-rebases/brave-browser/src/network_log.json in chrome://net-internals for more details.
Stack trace:
#0 0x55f213f6cc10 brave::(anonymous namespace)::BraveNetworkAuditTest::TearDownInProcessBrowserTestFixture()
#1 0x55f215bda3be content::BrowserTestBase::SetUp()
#2 0x55f215bd741e InProcessBrowserTest::SetUp()
This patch disables the kkOptimizationHints feature. TBD if this is
needed.
This patch disables the kRemoteOptimizationGuideFetching features that
are otherwise enabled by default, avoiding this URL requests.
PS: I couldn't pinpoint yet where exactly in Chromium 97 this started
happening, but I can consistently reproduce it on my local cr97 branch
setting kMaxTimeoutPerLoadedURL in brave_network_audit_browsertest.cc
to at least 20 seconds, while this doesn't happen on cr96 even when
using the default timeout of 5 minutes, so it's cr97-related.
This feature has launched by default upstream but we still need to
disable it as per request from the Security team, so we basically
bring back the previous behaviour via a chromium_src override, plus
a small patch to adapt javascript_frameworks_ukm_observer.cc.
Chromium change:
https://github.com/chromium/chromium/commit/34af795689999a2670d0238dedb5892b35e1642b
commit 34af795689999a2670d0238dedb5892b35e1642b
Author: Nicolás Peña Moreno <npm@chromium.org>
Date: Wed Oct 27 21:22:47 2021 +0000
Remove flag for framework detection
The feature is enabled by default, and the flag is no longer needed.
Bug: 1006274
This feature is now being enabled by default for Linux, Windows and
Mac, which is interfering with Brave's own internal tranlate engine,
so we now need to explicitly disable it.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/15e59cc7caed2b3e0401bcc6b8b4fa3fa94a07f9
commit 15e59cc7caed2b3e0401bcc6b8b4fa3fa94a07f9
Author: mcrouse <mcrouse@google.com>
Date: Wed Oct 20 17:38:30 2021 +0000
[LangID] Enable TFLite Language Detection by default on Desktop.
This enables language detection by default on desktop.
Note: This also changes how tests for translate browsertests works
in cases that relying on content/language detection is not necessary.
This makes the test more reliable and less bulky. We likely want
to improve this over time but this gets us to a point we can
enable the model on ToT.
This is fully behind Finch control and we will keep it
that way for safety for a few milestones.
Bug: 1159144
Feature switch has been removed.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/1746a920a7ddafcff0f8ea5ddb6d75e54cb7a21a
commit 1746a920a7ddafcff0f8ea5ddb6d75e54cb7a21a
Author: David Benjamin <davidben@chromium.org>
Date: Thu Oct 14 17:16:57 2021 +0000
Unwind kLegacyTLSEnforced feature flag
The feature shipped, so we no longer need the flag. This doesn't change
behavior, just unwinds the old feature flag to toggle the existing
interstitial.
Bug: 1044750
Chromium change:
https://chromium.googlesource.com/chromium/src/+/1307bd02195bd73a52ab0651ef3d629d619deb33
commit 1307bd02195bd73a52ab0651ef3d629d619deb33
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Oct 18 18:52:40 2021 +0000
GMC: Rename chrome/app/global_media_controls_strings to avoid collision
With the addition of the new global media controls component, we now
have two different grdp files named global_media_controls_strings:
components/global_media_controls_strings.grdp and
chrome/app/global_media_controls_strings.grdp
This CL renames the chrome/app one to gmc_strings.grdp
Bug: 1260955
* Add support for default feature state override.
* Convert runtime feature overrides to static overrides.
* Support overrides set via a single macro instantiation.
* Remove unused include.
Mario Sanchez Prada