Chromium change:
https://source.chromium.org/chromium/chromium/src/+/383df85481f84629bac8d7f45713012b88aceaa6
commit 383df85481f84629bac8d7f45713012b88aceaa6
Author: Daniel Cheng <dcheng@chromium.org>
Date: Sat Oct 2 03:28:01 2021 +0000
Make helper macros behave consistently for //content/public UserData types
X_USER_DATA_KEY_DECL() requires a semicolon while X_USER_DATA_KEY_IMPL()
does not. This CL changes it so they both consistently require a
semicolon.
The comments have also been updated to:
- reflect the updated macro usage to consistently require semicolons
- simply the friend declaration, which does not need to qualify the
base class template with the `content::` namespace nor explicitly
specify the base class template's type parameter.
Macro cleanups outside //content/public/browser were generated using the
following commands:
sed -z -i 's|\nNAVIGATION_HANDLE_USER_DATA_KEY_IMPL([ \n]*\([^)]\+\))|\nNAVIGATION_HANDLE_USER_DATA_KEY_IMPL(\1);|g' $(git gs NAVIGATION_HANDLE_USER_DATA_KEY_IMPL --name-only | grep -v navigation_handle_user_data.h)
sed -z -i 's|\nPAGE_USER_DATA_KEY_IMPL([ \n]*\([^)]\+\))|\nPAGE_USER_DATA_KEY_IMPL(\1);|g' $(git gs PAGE_USER_DATA_KEY_IMPL --name-only | grep -v page_user_data.h)
sed -z -i 's|\nRENDER_DOCUMENT_HOST_USER_DATA_KEY_IMPL([ \n]*\([^)]\+\))|\nRENDER_DOCUMENT_HOST_USER_DATA_KEY_IMPL(\1);|g' $(git gs RENDER_DOCUMENT_HOST_USER_DATA_KEY_IMPL --name-only | grep -v render_document_host_user_data.h)
sed -z -i 's|\nWEB_CONTENTS_USER_DATA_KEY_IMPL([ \n]*\([^)]\+\))|\nWEB_CONTENTS_USER_DATA_KEY_IMPL(\1);|g' $(git gs WEB_CONTENTS_USER_DATA_KEY_IMPL --name-only | grep -v web_contents_user_data.h)
Bug: 1254987
It's chrome/browser/sync/sync_service_factory.cc now.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/ff4e5f6e2d335450d95d29be8496d2f65471a3d2
commit ff4e5f6e2d335450d95d29be8496d2f65471a3d2
Author: Victor Hugo Vianna Silva <victorvianna@google.com>
Date: Tue Jun 1 20:12:14 2021 +0000
Rename chrome/'s ProfileSyncServiceFactory to SyncServiceFactory
The goal of this factory is to return a SyncService. This follows
the naming convention of other keyed services that have an abstract
interface.
Bug: 1201272
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/930e2af1d16616915d2190503be1ccee143e1b53
[sync] Rename term 'secondary' with 'explicit' wrt passphrase
No behavioral changes, it's a fully automated replacement of the term.
The new name is consistent with other code like
syncer::IsExplicitPassphrase(). This logic returns true mainly for
custom passphrase users but also for the legacy
frozen-implicit-passphrase users (very similar to custom passphrase).
Change-Id: Id7ccbfaeef8fa995ca669e6040ef276bd18c0d3b
Bug: 1016715
https://chromium.googlesource.com/chromium/src/+/adfb75d061f224d12b009e31f4fc10b7da964868
[sync] Rename IsEncryptEverythingAllowed to IsCustomPassphraseAllowed
No behavior is changed. This better reflects the meaning of this
method.
Bug: None
base::ScopedObserver is being deprecated on Chromium 93, so we need
to migrate to either ScopedObservation or ScopedMultiSourceObservation
depending on whether one or multiple sources are being observed.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/3a35c513e236f28ba817b6667c9c973163241ebd
commit 3a35c513e236f28ba817b6667c9c973163241ebd
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Thu Jun 3 16:34:54 2021 +0000
Remove redundant base/scoped_observer.h includes.
ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
a single source.
- base::ScopedMultiSourceObservation for observers that do or may
observe more than a single source.
Bug: 1145565
Resolves https://github.com/brave/brave-browser/issues/16371
Needed to avoid build errors like
../../brave/browser/android/preferences/brave_pref_service_bridge.cc:56:7: error: invalid use of incomplete type 'GURL'
Chromium change:
https://chromium.googlesource.com/chromium/src/+/b455227428979e24f66de2f45c9180f33f4a8adf
[sync] Rewrite setSyncEncryption() chrome://settings JS API
This API was called when the user created a new sync encryption passphrase
or entered an existing one. This CL improves both its semantics and
implementation.
- Instead of having a set_new_passphrase flag to distinguish new/existing
passphrases, the API is split in set[Encryption/Decryption]Passphrase().
The implementations are mostly disjoint and there's a clear separation
now (the old code would even ignore set_new_passphrase sometimes). This
also mimics the signatures from other layers.
- As per the linked bug, the APIs now receive only what's necessary (the
passphrase string) instead of an entire SyncPrefs object.
- Following a suggestion from an old TODO [1], the "return values" are
now simply whether the passphrase was successfully set or not, instead
of returning what the behavior of the UI should be (PageStatus). This
makes them less coupled with the existing callers.
- The Profile.SyncCustomize histogram is now recorded closer to where the
passphrase updates happen. This may ultimately cause changes in the
metric, but at least something meaningful will be recorded now. Seems the
histogram wasn't actively watched anyways (it expired twice). The obscure
buckets SYNC_ENCRYPT and SYNC_PASSPHRASE are also respectively renamed to
SYNC_CREATED_NEW_PASSPHRASE and SYNC_ENTERED_EXISTING_PASSPHRASE.
Mario Sanchez Prada