No need to use the templated syntax anymore.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/e0fc463ca6d8dedd64bb520779aa367c0831581b
commit e0fc463ca6d8dedd64bb520779aa367c0831581b
Author: Daniel Cheng <dcheng@chromium.org>
Date: Fri Oct 1 00:37:41 2021 +0000
Update base::DoNothing() / base::NullCallback() to use a type tag.
This allows both helpers to be used in contexts where the original
helper required templated arguments to be explicitly specified,
generally leading to more concise code.
However, since base::DoNothing() only returns a type tag now, it can no
longer be used as a functor with base::BindOnce/base::BindRepeating.
In general, this seems to be a net neutral to slight positive change:
the lambda version is actually shorter—though some might argue less
readable—and it generates more efficient code since running the callback
now jumps through one less thunk.
Bug: 1252980
Chromium change:
https://chromium.googlesource.com/chromium/src/+/21667acc2a3c5fe6738899fb494248c583bcc230
Rename ProfileSyncService to SyncServiceImpl in Android code
No behavior is changed. Do the following renamings:
- ProfileSyncService.java -> SyncServiceImpl.java
- profile_sync_service_android.h -> sync_service_android_bridge.h
- FakeProfileSyncService.java -> FakeSyncServiceImpl.java (and
corresponding *WithFakeProfileSyncService test files)
Moreover
- Update the documentation of *sync_service_android_bridge.h
Bug: 1201272
Chromium change:
https://chromium.googlesource.com/chromium/src/+/d8ef96e6b8d1de5c4441c8b7df1dab8ef9142290
Remove ProfileSyncServiceAndroid::Init()
This method is basically a way to check whether the native
ProfileSyncService is null. If so, JNI_ProfileSyncService_Init()
destroys ProfileSyncServiceAndroid immediately.
Instead, let's check first and then construct the object if PSS is
non-null. ProfileSyncServiceAndroid now only has 2 deps (the native and
java services), both set on construction.
The CL also does some minor readability improvements to
profile_sync_service_android.cc.
Bug: None
They are in components/sync/driver/sync_service_impl.{cc,h} now.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/b77854267a62e9208b1ac5ceb4167387ec7c56cc
commit b77854267a62e9208b1ac5ceb4167387ec7c56cc
Author: Victor Hugo Vianna Silva <victorvianna@google.com>
Date: Fri Jun 4 09:15:21 2021 +0000
Reland "Rename ProfileSyncService to SyncServiceImpl"
Reason for reland: Original CL was reverted to unwind other changes.
Original change's description:
> Rename ProfileSyncService to SyncServiceImpl
>
> Renaming related classes like ProfileSyncServiceAndroid and
> ProfileSyncServiceHarness is left for next CLs. We also use this CL as
> an opportunity to hide the implementation class when possible:
> - Some includes for sync_service_impl.h are removed if unnecessary, or
> replaced with sync_service.h.
> - Even comments referring to SyncServiceImpl are updated to refer to
> the interface if the layer isn't aware SyncServiceImpl is being used.
>
> The CL also adds one missing include for <string> in
> fake_server_helper_android.cc to address one IWYU presubmit warning.
Bug: 1201272
It's chrome/browser/sync/sync_service_factory.cc now.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/ff4e5f6e2d335450d95d29be8496d2f65471a3d2
commit ff4e5f6e2d335450d95d29be8496d2f65471a3d2
Author: Victor Hugo Vianna Silva <victorvianna@google.com>
Date: Tue Jun 1 20:12:14 2021 +0000
Rename chrome/'s ProfileSyncServiceFactory to SyncServiceFactory
The goal of this factory is to return a SyncService. This follows
the naming convention of other keyed services that have an abstract
interface.
Bug: 1201272
base::ScopedObserver is being deprecated on Chromium 93, so we need
to migrate to either ScopedObservation or ScopedMultiSourceObservation
depending on whether one or multiple sources are being observed.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/3a35c513e236f28ba817b6667c9c973163241ebd
commit 3a35c513e236f28ba817b6667c9c973163241ebd
Author: Sigurdur Asgeirsson <siggi@chromium.org>
Date: Thu Jun 3 16:34:54 2021 +0000
Remove redundant base/scoped_observer.h includes.
ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
a single source.
- base::ScopedMultiSourceObservation for observers that do or may
observe more than a single source.
Bug: 1145565
Resolves https://github.com/brave/brave-browser/issues/16371
Component //brave/*
ERROR at //brave/browser/sync/brave_profile_sync_service_delegate.cc:13:11: Include not allowed.
^-----------------------------------------------------
It is not in any dependency of
//brave/browser/sync:sync
The include file is in the target(s):
//chrome/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/browser/sync/brave_profile_sync_service_delegate.cc:14:11: Include not allowed.
^-------------------------------------------------
It is not in any dependency of
//brave/browser/sync:sync
The include file is in the target(s):
//chrome/browser:browser
which should somehow be reachable.
```
inherited from existing file in a target that already had check_includes = false
fix https://github.com/brave/brave-browser/issues/12976
Mario Sanchez Prada