The TabStrip::ShouldHideCloseButtonForTab() method has been removed
upstream. To preserve the behavior to show close button on inactive tabs
only on hover added an additional chromium_src override to tab.cc
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/bc1aac74a88ad9ce554f048b6404b9e72383c832
commit bc1aac74a88ad9ce554f048b6404b9e72383c832
Author: Taylor Bergquist <tbergquist@chromium.org>
Date: Thu Nov 4 21:40:49 2021 +0000
Remove stacked tabs from the rest of TabStrip.
Bug: 1250061
Constructors and Create methods no longer expect a raw pointer.
Chromium change:
https://github.com/chromium/chromium/commit/49e30ea02860a4b573e2c7309429c0a5b3a740e2
commit 49e30ea02860a4b573e2c7309429c0a5b3a740e2
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Thu Oct 28 20:31:56 2021 +0000
[reland] Use correct source_site_instance if navigating via context menu
Before this CL there would be a discrepancy - navigation via the context
menu could be associated both 1) with the subframe where the right click
happened and 2) with the focused frame. In particular,
RenderViewContextMenuBase::OpenURLWithExtraHeaders would set
`open_url_params.initiator_origin` based on the subframe, while setting
`open_url_params.source_site_instance` based on the focused frame
obtained by ChromeWebContentsViewDelegateViews::BuildMenu via a call to
`web_contents->GetFocusedFrame()`. Typically both frames (context menu
frame and the focused frame) would be the same, but in some scenarios
the main frame could retain the focus even while a subframe is opening a
context menu.
This CL modifies ChromeWebContentsViewDelegateViews::ShowContextMenu and
ChromeWebContentsViewDelegateMac::ShowContextMenu so that they forward
the original subframe to the BuildMenu method (rather than replacing it
with the WebContents). Most of the other changes in the CL are just a
cascading consequence of changing the parameter type of BuildMenu. This
way the context menu is associated with a single frame (removing the
focused frame from the considerations).
Bug: 1257907
This method was added in commit 88fbb5cc23 [1] as a way to initialize
the WebUIBubbleManagerT<WalletPanelUI> using the current anchor view,
but that initialization was removed later on in commit 3cd2a7f076 [2],
leaving the method just assigning a local |anchor_view| variable that
never gets used now.
This is now leading to a -Werror,-Wunused-but-set-variable error when
compiling, so this patch removes the method and all its callpoints.
[1] https://github.com/brave/brave-core/commit/88fbb5cc23
[2] https://github.com/brave/brave-core/commit/3cd2a7f076
The buttons used for the Brave VPN in the toolbar and app menu were
lacking an accessible name, which was triggering a crash on startup
on DCHECK-enabled builds.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/a62d2cead48795f0cfc53d35dcdca66f4e236bb3
commit a62d2cead48795f0cfc53d35dcdca66f4e236bb3
Author: Peter Boström <pbos@chromium.org>
Date: Thu Oct 7 21:14:44 2021 +0000
Reland "Enable Views OnPaint() A11y DCHECKs"
This reverts commit 32985fb4404d1c7aa41053d8f4d21ed729afbb98.
Reason for revert: Relanding with additional skip-check annotations.
Original change's description:
> Revert "Enable Views OnPaint() A11y DCHECKs"
>
> This reverts commit c95dcbbb8ef6577342acfd2d9a3a0af9ee54502b.
>
> Reason for revert: Suspected culprit for failures on linux-chromeos-dbg. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/25787/overview
>
>
> Original change's description:
> > Enable Views OnPaint() A11y DCHECKs
> >
> > This annotates MessageBoxView which was the hard-to-find culprit of
> > ChromeDriverTest.testSendTextToAlert. Presumably the test is set up to
> > generate display a zero-length message?
> >
> > This change is likely to get reverted as more issues are found in the
> > field. If you see this commit because your specific UI/dialog started
> > crashing, please see views::kSkipAccessibilityPaintChecks to temporarily
> > disable the DCHECK for your UI rather than reverting the mechanism for
> > detecting these errors. Do follow that up with removal of that property
> > and make sure that focusable UI always has accessible names that can be
> > read by screenreaders.
> >
> > Bug: 1218186
> > Change-Id: Id5e19fa7ccca844c599740b6849a3721604a5ee8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209106
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Commit-Queue: Peter Boström <pbos@chromium.org>
> > Auto-Submit: Peter Boström <pbos@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#928920}
>
> Bug: 1218186
> Change-Id: I9abaef4c2abfa1d853be8933d700e11a727dbc97
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3210369
> Reviewed-by: Meredith Lane <meredithl@chromium.org>
> Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
> Owners-Override: Meredith Lane <meredithl@chromium.org>
> Auto-Submit: Meredith Lane <meredithl@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#929035}
Bug: 1218186
Changed timing for calling GetNativeTheme().
It should be called after NativeTheme is available for view.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/93850eca7ee7369c0600f9558649d521b8f6d2eb
commit 93850eca7ee7369c0600f9558649d521b8f6d2eb
Author: tom <tluk@chromium.org>
Date: Mon Jul 19 17:39:29 2021
[views] Add CHECK to prevent fallthrough to global NativeTheme
This CL adds a CHECK to View::GetNativeTheme() to catch any
remaining fallthrough to the global NativeTheme instance.
Bug: 1056756
The instances of SideButtonView and its subclasses will turn into
focusable elements that are now required to have an accessible name
available, or screen readers will not be able to see their content.
To fix this (plus crashes on DCHECK-enabled builds), we add a new
parameter to the constructor of SideButtonView to allow us set an
accesible name, and use for such name the same text we're using for
for the buttons' tooltips (e.g. Brave Talk, Wallet, Settings...).
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/a62d2cead48795f0cfc53d35dcdca66f4e236bb3
commit a62d2cead48795f0cfc53d35dcdca66f4e236bb3
Author: Peter Boström <pbos@chromium.org>
Date: Thu Oct 7 21:14:44 2021 +0000
Reland "Enable Views OnPaint() A11y DCHECKs"
This reverts commit 32985fb4404d1c7aa41053d8f4d21ed729afbb98.
Reason for revert: Relanding with additional skip-check annotations.
Original change's description:
> Revert "Enable Views OnPaint() A11y DCHECKs"
>
> This reverts commit c95dcbbb8ef6577342acfd2d9a3a0af9ee54502b.
>
> Reason for revert: Suspected culprit for failures on linux-chromeos-dbg. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/25787/overview
>
>
> Original change's description:
> > Enable Views OnPaint() A11y DCHECKs
> >
> > This annotates MessageBoxView which was the hard-to-find culprit of
> > ChromeDriverTest.testSendTextToAlert. Presumably the test is set up to
> > generate display a zero-length message?
> >
> > This change is likely to get reverted as more issues are found in the
> > field. If you see this commit because your specific UI/dialog started
> > crashing, please see views::kSkipAccessibilityPaintChecks to temporarily
> > disable the DCHECK for your UI rather than reverting the mechanism for
> > detecting these errors. Do follow that up with removal of that property
> > and make sure that focusable UI always has accessible names that can be
> > read by screenreaders.
> >
> > Bug: 1218186
> > Change-Id: Id5e19fa7ccca844c599740b6849a3721604a5ee8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209106
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Commit-Queue: Peter Boström <pbos@chromium.org>
> > Auto-Submit: Peter Boström <pbos@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#928920}
>
> Bug: 1218186
> Change-Id: I9abaef4c2abfa1d853be8933d700e11a727dbc97
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3210369
> Reviewed-by: Meredith Lane <meredithl@chromium.org>
> Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
> Owners-Override: Meredith Lane <meredithl@chromium.org>
> Auto-Submit: Meredith Lane <meredithl@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#929035}
Bug: 1218186
The LabelButton used for the Brave Rewards button in the toolbar was
lacking an accessible name, which was triggering a crash on startup
on DCHECK-enabled builds.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/a62d2cead48795f0cfc53d35dcdca66f4e236bb3
commit a62d2cead48795f0cfc53d35dcdca66f4e236bb3
Author: Peter Boström <pbos@chromium.org>
Date: Thu Oct 7 21:14:44 2021 +0000
Reland "Enable Views OnPaint() A11y DCHECKs"
This reverts commit 32985fb4404d1c7aa41053d8f4d21ed729afbb98.
Reason for revert: Relanding with additional skip-check annotations.
Original change's description:
> Revert "Enable Views OnPaint() A11y DCHECKs"
>
> This reverts commit c95dcbbb8ef6577342acfd2d9a3a0af9ee54502b.
>
> Reason for revert: Suspected culprit for failures on linux-chromeos-dbg. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/25787/overview
>
>
> Original change's description:
> > Enable Views OnPaint() A11y DCHECKs
> >
> > This annotates MessageBoxView which was the hard-to-find culprit of
> > ChromeDriverTest.testSendTextToAlert. Presumably the test is set up to
> > generate display a zero-length message?
> >
> > This change is likely to get reverted as more issues are found in the
> > field. If you see this commit because your specific UI/dialog started
> > crashing, please see views::kSkipAccessibilityPaintChecks to temporarily
> > disable the DCHECK for your UI rather than reverting the mechanism for
> > detecting these errors. Do follow that up with removal of that property
> > and make sure that focusable UI always has accessible names that can be
> > read by screenreaders.
> >
> > Bug: 1218186
> > Change-Id: Id5e19fa7ccca844c599740b6849a3721604a5ee8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209106
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Commit-Queue: Peter Boström <pbos@chromium.org>
> > Auto-Submit: Peter Boström <pbos@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#928920}
>
> Bug: 1218186
> Change-Id: I9abaef4c2abfa1d853be8933d700e11a727dbc97
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3210369
> Reviewed-by: Meredith Lane <meredithl@chromium.org>
> Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
> Owners-Override: Meredith Lane <meredithl@chromium.org>
> Auto-Submit: Meredith Lane <meredithl@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#929035}
Bug: 1218186
This is where the utility functions we need live now.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/65ef1ad3db744620652a74f6847938b7bbb3adc8
commit 65ef1ad3db744620652a74f6847938b7bbb3adc8
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Oct 7 03:12:33 2021 +0000
Move ui/gfx/transform*,rrect*,mask_filter_info* into ui/gfx/geometry
This allows blink code to use these types without needing to depend
on ui/gfx.
Split out geometry conversion functions from ui/gfx/skia_util.h into
ui/gfx/geometry/skia_conversions.h.
Split //ui/gfx:geometry_skia into //ui/gfx:gfx_skia and
//ui/gfx/geometry:geometry_skia.
This doesn't change depending code except for cc/.
Bug: 738465
We can rely on the APIs of OmniboxViewViews and OmniboxEditModel now.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/3da9d9153abbc366ce1c4f8e7a93f35dcab1a834
commit 3da9d9153abbc366ce1c4f8e7a93f35dcab1a834
Author: Orin Jaworski <orinj@google.com>
Date: Fri Oct 1 02:35:35 2021 +0000
[omnibox] Eliminate OmniboxPopupModel by merging into OmniboxEditModel
This CL removes the OmniboxPopupModel entirely. The file remains only
for OmniboxPopupSelection and its related methods, which are still
in common use. Forwarding methods in OmniboxEditModel now contain
the implementations previously in OmniboxPopupModel. The one unified
model now controls the state related to the popup. Presence of
a non-nullptr popup view is now the way to determine whether popup
state is relevant within the model.
Bug: 1208026
Linking to a search query to highlight the Speedreader setting
only works if we us use the localized string presented by the
ui. Currently 8 of 47 locales translate this.
Fixup for #9580.
We have two options here: (1) Point to
brave://settings?search=speedreader, which will highlight the
Speedreader setting, or (2) or provide a pointer to
brave://settings/appearance. I went with the former because it makes the
setting a bit easier to identify. There isn't a way to link to a
specific setting.
Resolves https://github.com/brave/brave-browser/issues/17216
Mario Sanchez Prada